GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-99370: Prefer LIBDIR from sysconfig when locating libpython for test by zooba · Pull Request #99523 · python/cpython

Conversation

@zooba

@zooba zooba commented Nov 16, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This ensures that tests pass when the runtime has been installed.

  • Issue: In python3.11 getpath.py calculates zip path with default prefix in a venv which breaks venv created fron non-installed python #99370

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@zooba
pythongh-99370: Prefer LIBDIR from sysconfig when locating libpython …
fd6f008 
…for test
@zooba
zooba requested a review from vsajip as a code owner November 16, 2022 00:42
@bedevere-bot bedevere-bot added awaiting core review tests Tests in the Lib/test dir labels Nov 16, 2022
@zooba zooba added needs backport to 3.11 only security fixes and removed tests Tests in the Lib/test dir labels Nov 16, 2022
@bedevere-bot bedevere-bot mentioned this pull request Nov 16, 2022
In python3.11 getpath.py calculates zip path with default prefix in a venv which breaks venv created fron non-installed python #99370
Closed
@zooba zooba added skip news 🔨 test-with-buildbots Test PR w/ buildbots; report in status section labels Nov 16, 2022
@bedevere-bot

bedevere-bot commented Nov 16, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @zooba for commit fd6f008 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 16, 2022
@zooba

zooba commented Nov 16, 2022

Copy link
Copy Markdown
Member Author

The buildbot failures all seem to be because of another change that will be fixed by #99543
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@zooba
zooba merged commit 7c57857 into python:main Nov 16, 2022
@miss-islington

miss-islington commented Nov 16, 2022

Copy link
Copy Markdown
Contributor

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting core review label Nov 16, 2022
@zooba
zooba deleted the gh-99370 branch November 16, 2022 21:41
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 16, 2022
@zooba @miss-islington
pythongh-99370: Prefer LIBDIR from sysconfig when locating libpython …
14eafdd 
…for test (pythonGH-99523)

(cherry picked from commit 7c57857)

Co-authored-by: Steve Dower <[email protected]>
@bedevere-bot

bedevere-bot commented Nov 16, 2022

Copy link
Copy Markdown

GH-99550 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Nov 16, 2022
@bedevere-bot

bedevere-bot commented Nov 16, 2022

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Windows10 3.x has failed when building commit 7c57857.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/146/builds/3990) and take a look at the build logs.
  4. Check if the failure is related to this commit (7c57857) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/146/builds/3990

Failed tests:

  • test_threading

Summary of the results of the build (if available):

==

Click to see traceback logs 
remote: Enumerating objects: 9, done.        
remote: Counting objects:  11% (1/9)        
remote: Counting objects:  22% (2/9)        
remote: Counting objects:  33% (3/9)        
remote: Counting objects:  44% (4/9)        
remote: Counting objects:  55% (5/9)        
remote: Counting objects:  66% (6/9)        
remote: Counting objects:  77% (7/9)        
remote: Counting objects:  88% (8/9)        
remote: Counting objects: 100% (9/9)        
remote: Counting objects: 100% (9/9), done.        
remote: Compressing objects:  25% (1/4)        
remote: Compressing objects:  50% (2/4)        
remote: Compressing objects:  75% (3/4)        
remote: Compressing objects: 100% (4/4)        
remote: Compressing objects: 100% (4/4), done.        
remote: Total 5 (delta 4), reused 1 (delta 1), pack-reused 0        
From https://github.com/python/cpython
 * branch            main       -> FETCH_HEAD
Note: checking out '7c57857340befcb90394bc347c904ca62049b684'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b <new-branch-name>

HEAD is now at 7c57857... gh-99370: Prefer LIBDIR from sysconfig when locating libpython for test (GH-99523)
Switched to and reset branch 'main'

Could Not Find D:\buildarea\3.x.bolen-windows10\build\Lib\*.pyc
The system cannot find the file specified.
Could Not Find D:\buildarea\3.x.bolen-windows10\build\PCbuild\python*.zip

Fatal Python error: _PyInterpreterState_GET: the function must be called with the GIL held, after Python initialization and before Python finalization, but the GIL is released (the current Python thread state is NULL)
Python runtime state: initialized

Current thread 0x00002dcc (most recent call first):
  <no Python frame>

Thread 0x00003164 (most recent call first):
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\test_threading.py", line 847 in test_frame_tstate_tracing
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\unittest\case.py", line 579 in _callTestMethod
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\unittest\case.py", line 623 in run
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\unittest\case.py", line 678 in __call__
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\unittest\suite.py", line 122 in run
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\unittest\suite.py", line 84 in __call__
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\unittest\suite.py", line 122 in run
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\unittest\suite.py", line 84 in __call__
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\unittest\suite.py", line 122 in run
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\unittest\suite.py", line 84 in __call__
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\unittest\runner.py", line 208 in run
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\support\__init__.py", line 1100 in _run_suite
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\support\__init__.py", line 1226 in run_unittest
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\libregrtest\runtest.py", line 281 in _test_module
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\libregrtest\runtest.py", line 317 in _runtest_inner2
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\libregrtest\runtest.py", line 360 in _runtest_inner
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\libregrtest\runtest.py", line 235 in _runtest
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\libregrtest\runtest.py", line 265 in runtest
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\libregrtest\main.py", line 352 in rerun_failed_tests
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\libregrtest\main.py", line 754 in _main
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\libregrtest\main.py", line 709 in main
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\libregrtest\main.py", line 773 in main
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\__main__.py", line 2 in <module>
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\runpy.py", line 88 in _run_code
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\runpy.py", line 198 in _run_module_as_main

Extension modules: _testcapi, _wmi (total: 2)

Cannot open file 'D:\buildarea\3.x.bolen-windows10\build\test-results.xml' for upload

Could Not Find D:\buildarea\3.x.bolen-windows10\build\PCbuild\python*.zip
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington added a commit that referenced this pull request Nov 16, 2022
@miss-islington @zooba
gh-99370: Prefer LIBDIR from sysconfig when locating libpython for te…
0014ce7 
…st (GH-99523)

(cherry picked from commit 7c57857)

Co-authored-by: Steve Dower <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vsajip vsajip Awaiting requested review from vsajip vsajip is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@zooba @bedevere-bot @miss-islington
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.