GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-99593: Add tests for Unicode C API by serhiy-storchaka · Pull Request #99594 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Nov 19, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Add tests for Unicode C API #99593

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-bot bedevere-bot mentioned this pull request Nov 19, 2022
Add tests for Unicode C API #99593
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Nov 19, 2022
@serhiy-storchaka
serhiy-storchaka requested review from encukou and vstinner November 19, 2022 11:37
@serhiy-storchaka

serhiy-storchaka commented Nov 19, 2022

Copy link
Copy Markdown
Member Author

I have found a bug during testing. I'll extract it into a separate issue later.

I'll write the remaining tests after some rest.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@serhiy-storchaka
pythongh-99593: Add tests for Unicode C API
8bf0e29
@serhiy-storchaka
serhiy-storchaka force-pushed the test-unicode-capi3 branch from b6bfd11 to 8bf0e29 Compare November 19, 2022 11:46
vstinner
vstinner reviewed Nov 19, 2022
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want me to review this PR, can you please split it into smaller PR? Like start with a shorter PR, wait until it's merged, then move to the next one.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@serhiy-storchaka serhiy-storchaka added needs backport to 3.10 needs backport to 3.11 only security fixes labels Nov 20, 2022
@serhiy-storchaka serhiy-storchaka mentioned this pull request Nov 20, 2022
gh-99612: Fix PyUnicode_DecodeUTF8Stateful() for ASCII-only data #99613
Merged
@serhiy-storchaka

serhiy-storchaka commented Nov 21, 2022

Copy link
Copy Markdown
Member Author

I'll split it on three parts:

  • higher-level C API corresponding to str methods
  • lower-level C API
  • codecs
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner

vstinner commented Nov 21, 2022

Copy link
Copy Markdown
Member

I'll split it on three parts:

Are you talking about creating 3 PRs modifying the same files, or do you consider to have separated C and Python files for "higher-level C API corresponding to str methods"? Maybe it's just fine to put most "unicode" tests in "unicode.c" and "unicode.py" tests.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@serhiy-storchaka

serhiy-storchaka commented Nov 21, 2022

Copy link
Copy Markdown
Member Author

As you suggested, I'll add codecs tests in a separate Python file. The rest of tests will be in Lib/test/test_capi/test_unicode.py.

All wrappers will be defined in Modules/_testcapi/unicode.c. It is nice that it was separated from _testcapi.c.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@serhiy-storchaka

serhiy-storchaka commented Nov 23, 2022 •
edited by erlend-aasland
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author
  • gh-99593: Add tests for Unicode C API (part 1) #99651
  • gh-99593: Add tests for Unicode C API (part 2) #99868
  • gh-99593: Add tests for Unicode C API (part 3) serhiy-storchaka/cpython#20
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@hugovk hugovk removed the needs backport to 3.10 label Apr 7, 2023
@erlend-aasland

erlend-aasland commented Jun 29, 2023

Copy link
Copy Markdown
Contributor

Since part 1 and 2 are merged, and part 3 (gh-104728) is in the queue, I recon we can close this :)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@serhiy-storchaka serhiy-storchaka closed this Jun 29, 2023
@serhiy-storchaka
serhiy-storchaka deleted the test-unicode-capi3 branch June 29, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner left review comments
@encukou encukou Awaiting requested review from encukou

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review needs backport to 3.11 only security fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@serhiy-storchaka @vstinner @erlend-aasland @hugovk @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.