GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||
GeezerVison is showing github.com — gh-99593: Add tests for Unicode C API by serhiy-storchaka · Pull Request #99594 · python/cpython Conversation
|
|
I have found a bug during testing. I'll extract it into a separate issue later. I'll write the remaining tests after some rest. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
b6bfd11 to
8bf0e29
Compare
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
If you want me to review this PR, can you please split it into smaller PR? Like start with a shorter PR, wait until it's merged, then move to the next one.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I'll split it on three parts:
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Are you talking about creating 3 PRs modifying the same files, or do you consider to have separated C and Python files for "higher-level C API corresponding to str methods"? Maybe it's just fine to put most "unicode" tests in "unicode.c" and "unicode.py" tests. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
As you suggested, I'll add codecs tests in a separate Python file. The rest of tests will be in All wrappers will be defined in |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Since part 1 and 2 are merged, and part 3 (gh-104728) is in the queue, I recon we can close this :) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.