GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-99593: Add tests for Unicode C API (part 3) by serhiy-storchaka · Pull Request #104728 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented May 21, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Add tests for codecs.

  • Issue: Add tests for Unicode C API #99593

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
pythongh-99593: Add tests for Unicode C API (part 3)
f3c2360 
Add tests for codecs.
@serhiy-storchaka serhiy-storchaka added skip news needs backport to 3.11 only security fixes labels May 21, 2023
@bedevere-bot bedevere-bot added the awaiting core review label May 21, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 21, 2023
Add tests for Unicode C API #99593
Closed
corona10
corona10 reviewed May 22, 2023
View reviewed changes
Comment thread Modules/_testcapi/unicode.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka
Fix buld on Windows.
8ae2fb8
erlend-aasland
erlend-aasland approved these changes Jun 29, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jun 29, 2023
@erlend-aasland erlend-aasland mentioned this pull request Jun 29, 2023
gh-99593: Add tests for Unicode C API #99594
Closed
@serhiy-storchaka
Merge branch 'main' into test-unicode-capi-part3
486f261
@serhiy-storchaka
serhiy-storchaka merged commit 51ea664 into python:main Jul 10, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Jul 10, 2023
@miss-islington

miss-islington commented Jul 10, 2023

Copy link
Copy Markdown
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka
serhiy-storchaka deleted the test-unicode-capi-part3 branch July 10, 2023 11:04
@miss-islington

miss-islington commented Jul 10, 2023

Copy link
Copy Markdown
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 51ea664d18938645521bdd128a3c55f9c197644c 3.11
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned serhiy-storchaka Jul 10, 2023
@AlexWaygood AlexWaygood added the needs backport to 3.12 only security fixes label Jul 10, 2023
@miss-islington

miss-islington commented Jul 10, 2023

Copy link
Copy Markdown
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Jul 10, 2023

Copy link
Copy Markdown
Contributor

Sorry @serhiy-storchaka, I had trouble checking out the 3.12 backport branch.
Please retry by removing and re-adding the "needs backport to 3.12" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 51ea664d18938645521bdd128a3c55f9c197644c 3.12
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood AlexWaygood added needs backport to 3.12 only security fixes and removed needs backport to 3.12 only security fixes labels Jul 10, 2023
@miss-islington

miss-islington commented Jul 10, 2023

Copy link
Copy Markdown
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Jul 10, 2023

Copy link
Copy Markdown
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 51ea664d18938645521bdd128a3c55f9c197644c 3.12
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka serhiy-storchaka removed the needs backport to 3.11 only security fixes label Jul 10, 2023
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Jul 10, 2023
@serhiy-storchaka
[3.12] pythongh-99593: Add tests for Unicode C API (part 3) (pythonGH…
f40e37a 
…-104728)

Add tests for codecs..
(cherry picked from commit 51ea664)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-bot

bedevere-bot commented Jul 10, 2023

Copy link
Copy Markdown

GH-106595 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jul 10, 2023
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Jul 10, 2023
@serhiy-storchaka
[3.12] pythongh-99593: Add tests for Unicode C API (part 3) (pythonGH…
d282c4e 
…-104728)

Add tests for codecs.
(cherry picked from commit 51ea664)

Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka added a commit that referenced this pull request Jul 10, 2023
@serhiy-storchaka
[3.12] gh-99593: Add tests for Unicode C API (part 3) (GH-104728) (GH…
2da967e 
…-106595)

Add tests for codecs.
(cherry picked from commit 51ea664)
@serhiy-storchaka serhiy-storchaka removed their assignment Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10 corona10 corona10 left review comments
@erlend-aasland erlend-aasland erlend-aasland approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@serhiy-storchaka @miss-islington @bedevere-bot @corona10 @erlend-aasland @AlexWaygood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.