GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-99578: Fix refleak in _imp.create_builtin() by vstinner · Pull Request #99642 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Nov 21, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Fix a reference leak in _imp.create_builtin() after the creation of the first sub-interpreter.

  • Issue: gc_decref: Assertion "gc_get_refs(g) > 0" failed #99578

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
vstinner requested review from brettcannon, encukou, ericsnowcurrently, ncoghlan and warsaw as code owners November 21, 2022 10:28
@bedevere-bot bedevere-bot mentioned this pull request Nov 21, 2022
gc_decref: Assertion "gc_get_refs(g) > 0" failed #99578
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Nov 21, 2022
@vstinner vstinner added needs backport to 3.10 needs backport to 3.11 only security fixes and removed awaiting core review labels Nov 21, 2022
@vstinner
gh-99578: Fix refleak in _imp.create_builtin()
6480924 
Fix a reference bug in _imp.create_builtin() after the creation of
the first sub-interpreter for modules "builtins" and "sys".
@vstinner
vstinner merged commit cb2ef8b into python:main Nov 21, 2022
@miss-islington

miss-islington commented Nov 21, 2022

Copy link
Copy Markdown
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner deleted the create_builtin branch November 21, 2022 11:14
@bedevere-bot

bedevere-bot commented Nov 21, 2022

Copy link
Copy Markdown

GH-99643 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 21, 2022
@vstinner @miss-islington
pythongh-99578: Fix refleak in _imp.create_builtin() (pythonGH-99642)
0d488df 
Fix a reference bug in _imp.create_builtin() after the creation of
the first sub-interpreter for modules "builtins" and "sys".
(cherry picked from commit cb2ef8b)

Co-authored-by: Victor Stinner <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Nov 21, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 21, 2022
@vstinner @miss-islington
pythongh-99578: Fix refleak in _imp.create_builtin() (pythonGH-99642)
690efd9 
Fix a reference bug in _imp.create_builtin() after the creation of
the first sub-interpreter for modules "builtins" and "sys".
(cherry picked from commit cb2ef8b)

Co-authored-by: Victor Stinner <[email protected]>
@bedevere-bot

bedevere-bot commented Nov 21, 2022

Copy link
Copy Markdown

GH-99644 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Nov 21, 2022
miss-islington added a commit that referenced this pull request Nov 21, 2022
@miss-islington @vstinner
gh-99578: Fix refleak in _imp.create_builtin() (GH-99642)
9dda902 
Fix a reference bug in _imp.create_builtin() after the creation of
the first sub-interpreter for modules "builtins" and "sys".
(cherry picked from commit cb2ef8b)

Co-authored-by: Victor Stinner <[email protected]>
miss-islington added a commit that referenced this pull request Nov 21, 2022
@miss-islington @vstinner
gh-99578: Fix refleak in _imp.create_builtin() (GH-99642)
37dbbb2 
Fix a reference bug in _imp.create_builtin() after the creation of
the first sub-interpreter for modules "builtins" and "sys".
(cherry picked from commit cb2ef8b)

Co-authored-by: Victor Stinner <[email protected]>
@ericsnowcurrently ericsnowcurrently mentioned this pull request Nov 21, 2022
create_builtin() in _imp module trigger segfault if taking a builtin object as input #98354
Closed
@erlend-aasland erlend-aasland mentioned this pull request Apr 5, 2023
test_pickle/test_pickletools fail when running tests sequentially. #103247
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner
@encukou encukou Awaiting requested review from encukou
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner
@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@vstinner @miss-islington @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.