GeezerVison

Copy link

Copy Markdown

Contributor

kumaraditya303 requested a review from giampaolo December 13, 2022 06:20

serhiy-storchaka reviewed Jan 30, 2023

View reviewed changes

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

6t8k requested review from serhiy-storchaka and removed request for giampaolo January 30, 2023 20:34

serhiy-storchaka approved these changes Aug 16, 2023

View reviewed changes

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

….5 behavior (pythonGH-99802)

Restore following CPython <= 3.10.5 behavior of shutil.make_archive()
that went away as part of pythongh-93160:

Do not create an empty archive if root_dir is not a directory, and, in
that case, raise FileNotFoundError or NotADirectoryError regardless
of format choice. Beyond the brought-back behavior, the function may
now also raise these exceptions in dry_run mode.
(cherry picked from commit a86df29)

Co-authored-by: 6t8k <[email protected]>

…<= 3.10.5 behavior (pythonGH-99802)

Restore following CPython <= 3.10.5 behavior of shutil.make_archive()
that went away as part of pythongh-93160:

Do not create an empty archive if root_dir is not a directory, and, in
that case, raise FileNotFoundError or NotADirectoryError regardless
of format choice. Beyond the brought-back behavior, the function may
now also raise these exceptions in dry_run mode..
(cherry picked from commit a86df29)

Co-authored-by: 6t8k <[email protected]>

…0.5 behavior (GH-99802) (GH-107999)

Restore following CPython <= 3.10.5 behavior of shutil.make_archive()
that went away as part of gh-93160:

Do not create an empty archive if root_dir is not a directory, and, in
that case, raise FileNotFoundError or NotADirectoryError regardless
of format choice. Beyond the brought-back behavior, the function may
now also raise these exceptions in dry_run mode.
(cherry picked from commit a86df29)

Co-authored-by: 6t8k <[email protected]>

…0.5 behavior (GH-99802) (#107998)

gh-99203: shutil.make_archive(): restore select CPython <= 3.10.5 behavior (GH-99802)

Restore following CPython <= 3.10.5 behavior of shutil.make_archive()
that went away as part of gh-93160:

Do not create an empty archive if root_dir is not a directory, and, in
that case, raise FileNotFoundError or NotADirectoryError regardless
of format choice. Beyond the brought-back behavior, the function may
now also raise these exceptions in dry_run mode.
(cherry picked from commit a86df29)

Co-authored-by: 6t8k <[email protected]>

6t8k deleted the gh-99203 branch August 16, 2023 19:49