GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-89653: PEP 670: Convert macros to functions by vstinner · Pull Request #99843 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Nov 28, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Convert macros to static inline functions to avoid macro pitfalls,
like duplication of side effects:

  • DK_ENTRIES()
  • DK_UNICODE_ENTRIES()
  • PyCode_GetNumFree()
  • PyFloat_AS_DOUBLE()
  • PyInstanceMethod_GET_FUNCTION()
  • PyMemoryView_GET_BASE()
  • PyMemoryView_GET_BUFFER()
  • PyMethod_GET_FUNCTION()
  • PyMethod_GET_SELF()
  • PySet_GET_SIZE()
  • _PyHeapType_GET_MEMBERS()

Changes:

  • Add also assertions in some functions using "CAST" macro to check
    the type of the arguments when Python is built with assertions
    (debug build).
  • Remove an outdated comment in unicodeobject.h.
  • PyCode_GetNumFree() doesn't cast its argument: the replaced macro
    already required the exact type PyCodeObject*.
  • PyCode_GetNumFree() casts PyCode_GetNumFree.co_nfreevars from int
    to Py_ssize_t to be future proof, and because Py_ssize_t is
    commonly used in the C API.
  • Issue: [C API] PEP 670: Convert macros to functions in the Python C API #89653

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@vstinner vstinner added the skip news label Nov 28, 2022
@bedevere-bot bedevere-bot mentioned this pull request Nov 28, 2022
[C API] PEP 670: Convert macros to functions in the Python C API #89653
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Nov 28, 2022
@vstinner

vstinner commented Nov 28, 2022

Copy link
Copy Markdown
Member Author

cc @erlend-aasland

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner
gh-89653: PEP 670: Convert macros to functions
5442376
Convert macros to static inline functions to avoid macro pitfalls,
like duplication of side effects:

* DK_ENTRIES()
* DK_UNICODE_ENTRIES()
* PyCode_GetNumFree()
* PyFloat_AS_DOUBLE()
* PyInstanceMethod_GET_FUNCTION()
* PyMemoryView_GET_BASE()
* PyMemoryView_GET_BUFFER()
* PyMethod_GET_FUNCTION()
* PyMethod_GET_SELF()
* PySet_GET_SIZE()
* _PyHeapType_GET_MEMBERS()

Changes:

* Add also assertions in some functions using "CAST" macro to check
  the type of the arguments when Python is built with assertions
  (debug build).
* Remove an outdated comment in unicodeobject.h.
* PyCode_GetNumFree() doesn't cast its argument: the replaced macro
  already required the exact type PyCodeObject*.
* PyCode_GetNumFree() casts PyCode_GetNumFree.co_nfreevars from int
  to Py_ssize_t to be future proof, and because Py_ssize_t is
  commonly used in the C API.
@vstinner

vstinner commented Nov 28, 2022

Copy link
Copy Markdown
Member Author

I changed PyCode_GetNumFree() return type to Py_ssize_t.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner
Reformat _PyHeapType_GET_MEMBERS()
f1594c1
erlend-aasland
erlend-aasland approved these changes Nov 28, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Nov 28, 2022
@vstinner

vstinner commented Nov 28, 2022

Copy link
Copy Markdown
Member Author

See also PR #99844.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner
vstinner merged commit 02f72b8 into python:main Nov 28, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Nov 28, 2022
@vstinner
vstinner deleted the static_inline branch November 28, 2022 15:40
@vstinner

vstinner commented Nov 28, 2022

Copy link
Copy Markdown
Member Author

Merged, thanks for the review @erlend-aasland.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@vstinner @erlend-aasland @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.