GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Use _Py_RVALUE() in macros by vstinner · Pull Request #99844 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Nov 28, 2022

Copy link
Copy Markdown
Member

The following macros are modified to use _Py_RVALUE(), so they can no longer be used as l-value:

  • DK_LOG_SIZE()
  • _PyCode_CODE()
  • _PyList_ITEMS()
  • _PyTuple_ITEMS()
  • _Py_SLIST_HEAD()
  • _Py_SLIST_ITEM_NEXT()

_PyCode_CODE() is private and other macros are part of the internal C API.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner vstinner added skip issue skip news labels Nov 28, 2022
@bedevere-bot bedevere-bot added the awaiting core review label Nov 28, 2022
@vstinner vstinner mentioned this pull request Nov 28, 2022
gh-89653: PEP 670: Convert macros to functions #99843
Merged
@vstinner
Use _Py_RVALUE() in macros
aef02d9 
The following macros are modified to use _Py_RVALUE(), so they can no
longer be used as l-value:

* DK_LOG_SIZE()
* _PyCode_CODE()
* _PyList_ITEMS()
* _PyTuple_ITEMS()
* _Py_SLIST_HEAD()
* _Py_SLIST_ITEM_NEXT()

_PyCode_CODE() is private and other macros are part of the internal C
API.
@vstinner

vstinner commented Nov 28, 2022

Copy link
Copy Markdown
Member Author

PR rebased to fix a conflict.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner merged commit 7bae15c into python:main Nov 28, 2022
@bedevere-bot bedevere-bot removed the awaiting core review label Nov 28, 2022
@vstinner
vstinner deleted the rvalue branch November 28, 2022 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.