GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] gh-82836: fix private network check (GH-97733) by miss-islington · Pull Request #99887 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Nov 29, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Fixes private checks for network objects. The previous method would incorrectly return True for a private check in cases such as "0.0.0.0/0".
(cherry picked from commit ed39109)

Co-authored-by: Pete Wicken [email protected]

  • Issue: ipaddress.ip_network('0.0.0.0/0').is_private == True #82836

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JamoBox @miss-islington
pythongh-82836: fix private network check (pythonGH-97733)
a6f937c 
Fixes private checks for network objects. The previous method would incorrectly return True for a private check in cases such as "0.0.0.0/0".
(cherry picked from commit ed39109)

Co-authored-by: Pete Wicken <[email protected]>
This was referenced Nov 29, 2022
ipaddress.ip_network('0.0.0.0/0').is_private == True #82836
Closed
gh-82836: fix private network check #97733
Merged
@bedevere-bot bedevere-bot added type-bug An unexpected behavior, bug, or error awaiting review labels Nov 29, 2022
gpshead
gpshead approved these changes Nov 29, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Nov 29, 2022
@miss-islington
miss-islington merged commit 8dafefc into python:3.11 Nov 29, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Nov 29, 2022
@miss-islington
miss-islington deleted the backport-ed39109-3.11 branch November 29, 2022 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@miss-islington @gpshead @bedevere-bot @JamoBox
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.