GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-82836: fix private network check by JamoBox · Pull Request #97733 · python/cpython

Conversation

@JamoBox

@JamoBox JamoBox commented Oct 2, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Fixes private checks for network objects. The previous method would incorrectly return True for a private check in cases such as "0.0.0.0/0".

  • Issue: ipaddress.ip_network('0.0.0.0/0').is_private == True #82836

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@JamoBox
pythongh-82836: fix private network check
652b43f
Fixes private checks for network objects. The previous method would incorrectly return True for a private check in cases such as "0.0.0.0/0".
@bedevere-bot bedevere-bot added the awaiting review label Oct 2, 2022
blurb-it Bot and others added 4 commits October 2, 2022 12:38
@blurb-it
📜🤖 Added by blurb_it.
b8164c4
@JamoBox
Fix NEWS
3042e65
@JamoBox
Fix typo in test
e218eef
@JamoBox
Improve docstring for is_private
c814b41
@JamoBox JamoBox mentioned this pull request Oct 2, 2022
ipaddress.ip_network('0.0.0.0/0').is_private == True #82836
Closed
JelleZijlstra
JelleZijlstra reviewed Oct 4, 2022
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2022-10-02-12-38-22.gh-issue-82836.OvYLmC.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

JamoBox and others added 2 commits October 4, 2022 22:05
@JamoBox @JelleZijlstra
Update Misc/NEWS.d/next/Library/2022-10-02-12-38-22.gh-issue-82836.Ov…
406a7bc
…YLmC.rst

Co-authored-by: Jelle Zijlstra <[email protected]>
@JamoBox
Merge branch 'fix-issue-82836' of https://github.com/JamoBox/cpython …
26be8a0
…into fix-issue-82836
@JamoBox

JamoBox commented Nov 15, 2022

Copy link
Copy Markdown
Contributor Author

@JelleZijlstra / @ammaraskar - are you able to take a look at this with the fixes in mind?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@JelleZijlstra
JelleZijlstra self-requested a review November 15, 2022 19:10
JelleZijlstra
JelleZijlstra reviewed Nov 16, 2022
View reviewed changes

@JelleZijlstra JelleZijlstra left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good and the tests are thorough, but I'm not sufficiently familiar with the module to merge this.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
gpshead
gpshead approved these changes Nov 29, 2022
View reviewed changes
Comment thread Lib/test/test_ipaddress.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Lib/test/test_ipaddress.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Nov 29, 2022
@gpshead gpshead added type-bug An unexpected behavior, bug, or error stdlib Standard Library Python modules in the Lib/ directory needs backport to 3.11 only security fixes labels Nov 29, 2022
@gpshead
gpshead merged commit ed39109 into python:main Nov 29, 2022
@miss-islington

miss-islington commented Nov 29, 2022

Copy link
Copy Markdown
Contributor

Thanks @JamoBox for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the awaiting merge label Nov 29, 2022
@bedevere-bot

bedevere-bot commented Nov 29, 2022

Copy link
Copy Markdown

GH-99887 is a backport of this pull request to the 3.11 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Nov 29, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 29, 2022
@JamoBox @miss-islington
pythongh-82836: fix private network check (pythonGH-97733)
a6f937c
Fixes private checks for network objects. The previous method would incorrectly return True for a private check in cases such as "0.0.0.0/0".
(cherry picked from commit ed39109)

Co-authored-by: Pete Wicken <[email protected]>
miss-islington added a commit that referenced this pull request Nov 29, 2022
@miss-islington @JamoBox
gh-82836: fix private network check (GH-97733)
8dafefc
Fixes private checks for network objects. The previous method would incorrectly return True for a private check in cases such as "0.0.0.0/0".
(cherry picked from commit ed39109)

Co-authored-by: Pete Wicken <[email protected]>
carljm added a commit to carljm/cpython that referenced this pull request Dec 1, 2022
@carljm
Merge branch 'main' into fixinspect
12f7659
* main: (112 commits)
  pythongh-99894: Ensure the local names don't collide with the test file in traceback suggestion error checking (python#99895)
  pythongh-99612: Fix PyUnicode_DecodeUTF8Stateful() for ASCII-only data (pythonGH-99613)
  Doc: Add summary line to isolation_level & autocommit sqlite3.connect params (python#99917)
  pythonGH-98906 ```re``` module: ```search() vs. match()``` section should mention ```fullmatch()``` (pythonGH-98916)
  pythongh-89189: More compact range iterator (pythonGH-27986)
  bpo-47220: Document the optional callback parameter of weakref.WeakMethod (pythonGH-25491)
  pythonGH-99905: Fix output of misses in summarize_stats.py execution counts (pythonGH-99906)
  pythongh-99845: PEP 670: Convert PyObject macros to functions (python#99850)
  pythongh-99845: Use size_t type in __sizeof__() methods (python#99846)
  pythonGH-99877)
  Fix typo in exception message in `multiprocessing.pool` (python#99900)
  pythongh-87092: move all localsplus preparation into separate function called from assembler stage (pythonGH-99869)
  pythongh-99891: Fix infinite recursion in the tokenizer when showing warnings (pythonGH-99893)
  pythongh-99824: Document that sqlite3.connect implicitly open a transaction if autocommit=False (python#99825)
  pythonGH-81057: remove static state from suggestions.c (python#99411)
  Improve zip64 limit error message (python#95892)
  pythongh-98253: Break potential reference cycles in external code worsened by typing.py lru_cache (python#98591)
  pythongh-99127: Allow some features of syslog to the main interpreter only (pythongh-99128)
  pythongh-82836: fix private network check (python#97733)
  Docs: improve accuracy of socketserver reference (python#24767)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra left review comments
@gpshead gpshead gpshead approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

stdlib Standard Library Python modules in the Lib/ directory type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@JamoBox @miss-islington @bedevere-bot @gpshead @JelleZijlstra
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.