GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-99955: standardize return values of functions in assembler and optimizer. by iritkatriel · Pull Request #99956 · python/cpython

Conversation

@iritkatriel

@iritkatriel iritkatriel commented Dec 2, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The individual commit may be easier to review.

  • Issue: error handling in the compiler is inconsistent #99955

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
iritkatriel added 6 commits December 2, 2022 16:55
@iritkatriel
is_exit_without_lineno return bool
c6d7ab9
@iritkatriel
merge_const_one returns -1/0
3056e23
@iritkatriel
assemble_emit returns -1/0
5f9f813
@iritkatriel
write_location_info_entry and assemble_emit_location return -1/0
aba26dc
@iritkatriel
assemble_exception_table and assemble_emit_exception_table_entry retu…
7210938 
…rn -1/0
@iritkatriel
assemble_init return -1/0
38b3c98
@iritkatriel
iritkatriel requested a review from markshannon as a code owner December 2, 2022 17:00
@bedevere-bot bedevere-bot mentioned this pull request Dec 2, 2022
error handling in the compiler is inconsistent #99955
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Dec 2, 2022
@markshannon markshannon changed the title gh-99955: standardize return values of functions in assemebler and optimizer. gh-99955: standardize return values of functions in assembler and optimizer. Dec 2, 2022
@markshannon

markshannon commented Dec 2, 2022

Copy link
Copy Markdown
Member

Thanks for doing this.
Does this cover everything in compile.c that used the 0/1 style return?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
markshannon
markshannon approved these changes Dec 2, 2022
View reviewed changes

@markshannon markshannon left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the functions changed are static, so you can skip the news item.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Dec 2, 2022
@iritkatriel

iritkatriel commented Dec 2, 2022

Copy link
Copy Markdown
Member Author

Thanks for doing this.
Does this cover everything in compile.c that used the 0/1 style return?

It doesn't cover any of the code-gen function, just optimizer and assembler.

code-gen uses 0/1, and the RETURN_IF_FALSE macro, which I think we should either do without or turn into RETURN_IF_ERROR (which would be -1).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel iritkatriel added skip news interpreter-core (Objects, Python, Grammar, and Parser dirs) labels Dec 2, 2022
@iritkatriel
iritkatriel merged commit ab02262 into python:main Dec 2, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon markshannon approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

interpreter-core (Objects, Python, Grammar, and Parser dirs) skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@iritkatriel @markshannon @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.