Description

iritkatriel

opened on Dec 2, 2022

Issue body actions

In compile.c some function return 0 for failure and 1 for success, and some return -1 for failure and 0 for success.

Should be -1 / 0 consistently.

Linked PRs

• gh-99955: standardize return values of functions in assembler and optimizer. #99956
• gh-99955: standardize return values of functions in compiler's code-gen #100010
• gh-99955: undef ERROR and SUCCESS before redefining (fixes sanitizer warning) #100215
• gh-99955: use SUCCESS/ERROR return values in optimizer and assembler. Use RETURN_IF_ERROR where appropriate. Fix a couple of bugs. #101412

Activity

1. iritkatriel

   added

   type-featureA feature request or enhancementA feature request or enhancement

   on Dec 2, 2022
2. iritkatriel

   added a commit that references this issue on Dec 2, 2022

   gh-99955: standardize return values of functions in assembler and opt…

   ab02262
3. ramvikrams commented on Dec 3, 2022

   

   ramvikrams

   on Dec 3, 2022

   Contributor

   More actions

   can I still work on this or is it done
4. iritkatriel commented on Dec 3, 2022

   

   iritkatriel

   on Dec 3, 2022

   MemberAuthor

   More actions

   I’m working on it, it’s mostly done. Assigning to myself to finish.
5. iritkatriel

   self-assigned this

   on Dec 3, 2022
6. iritkatriel

   changed the title [-]error handling in the compiler in inconsistent[/-] [+]error handling in the compiler is inconsistent[/+] on Dec 3, 2022
7. ramvikrams commented on Dec 3, 2022

   

   ramvikrams

   on Dec 3, 2022

   Contributor

   More actions

   ok
8. iritkatriel

   added 3 commits that reference this issue on Dec 12, 2022

   gh-99955: standardize return values of functions in compiler's code-g…

   e4ea33b

   pythongh-99955: undef ERROR and SUCCESS before redefining (fixes sani…

   a903bf8

   gh-99955: undef ERROR and SUCCESS before redefining (fixes sanitizer …

   985a710
9. carljm

   added a commit that references this issue on Dec 14, 2022

   Merge branch 'main' into typedocs

   53d33a1
10. iritkatriel

    closed this as completedon Jan 8, 2023
11. iritkatriel

    reopened this on Jan 29, 2023
12. iritkatriel

    added a commit that references this issue on Jan 29, 2023

    pythongh-99955: use SUCCESS/ERROR return values in optimizer and asse…

    df283cd
13. iritkatriel

    closed this as completedin #101412on Jan 31, 2023
14. iritkatriel

    added a commit that references this issue on Jan 31, 2023

    gh-99955: use SUCCESS/ERROR return values in optimizer and assembler.…

    af7b2db
15. mdboom

    added a commit that references this issue on Jan 31, 2023

    pythongh-99955: use SUCCESS/ERROR return values in optimizer and asse…

    e30789d
16. carljm

    added a commit that references this issue on Jan 31, 2023

    Merge branch 'main' into inlinecomp2

    ed3209b

Issue actions