GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] gh-60203: Always pass True/False as boolean arguments in tests (GH-99983) by miss-islington · Pull Request #99986 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Dec 4, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Unless we explicitly test non-bool values.
(cherry picked from commit 76f43fc)

Co-authored-by: Serhiy Storchaka [email protected]

  • Issue: Using new 'bool' format character #60203

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka @miss-islington
pythongh-60203: Always pass True/False as boolean arguments in tests (p…
6a0c576 
…ythonGH-99983)

Unless we explicitly test non-bool values.
(cherry picked from commit 76f43fc)

Co-authored-by: Serhiy Storchaka <[email protected]>
@miss-islington
miss-islington requested review from 1st1, asvetlov and gpshead as code owners December 4, 2022 12:29
This was referenced Dec 4, 2022
Using new 'bool' format character #60203
Closed
gh-60203: Always pass True/False as boolean arguments in tests #99983
Merged
@bedevere-bot bedevere-bot added skip news awaiting review labels Dec 4, 2022
serhiy-storchaka
serhiy-storchaka approved these changes Dec 4, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Dec 4, 2022
@miss-islington
miss-islington merged commit 7aa87bb into python:3.11 Dec 4, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Dec 4, 2022
@miss-islington
miss-islington deleted the backport-76f43fc-3.11 branch December 4, 2022 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes
@gpshead gpshead Awaiting requested review from gpshead gpshead is a code owner
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@miss-islington @serhiy-storchaka @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.