GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-60203: Always pass True/False as boolean arguments in tests by serhiy-storchaka · Pull Request #99983 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Dec 4, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Unless we explicitly test non-bool values.

  • Issue: Using new 'bool' format character #60203

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
pythongh-60203: Always pass True/False as boolean arguments in tests
e7fc154 
Unless we explicitly test non-bool values.
@serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir skip news needs backport to 3.10 needs backport to 3.11 only security fixes labels Dec 4, 2022
@serhiy-storchaka
serhiy-storchaka requested a review from gpshead December 4, 2022 09:04
@serhiy-storchaka
serhiy-storchaka requested review from 1st1, asvetlov, gvanrossum and kumaraditya303 as code owners December 4, 2022 09:04
@bedevere-bot bedevere-bot mentioned this pull request Dec 4, 2022
Using new 'bool' format character #60203
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Dec 4, 2022
@serhiy-storchaka
serhiy-storchaka merged commit 76f43fc into python:main Dec 4, 2022
@miss-islington

miss-islington commented Dec 4, 2022

Copy link
Copy Markdown
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting core review label Dec 4, 2022
@serhiy-storchaka
serhiy-storchaka deleted the bool-cleanup2 branch December 4, 2022 12:29
@miss-islington

miss-islington commented Dec 4, 2022

Copy link
Copy Markdown
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 76f43fc09af29401cc0cec7710b03e4dbf8a4578 3.10
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Dec 4, 2022

Copy link
Copy Markdown

GH-99986 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned serhiy-storchaka Dec 4, 2022
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Dec 4, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 4, 2022
@serhiy-storchaka @miss-islington
pythongh-60203: Always pass True/False as boolean arguments in tests (p…
6a0c576 
…ythonGH-99983)

Unless we explicitly test non-bool values.
(cherry picked from commit 76f43fc)

Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Dec 4, 2022
@serhiy-storchaka
[3.10] pythongh-60203: Always pass True/False as boolean arguments in…
f279305 
… tests (pythonGH-99983)

Unless we explicitly test non-bool values..
(cherry picked from commit 76f43fc)

Co-authored-by: Serhiy Storchaka <[email protected]>
@serhiy-storchaka serhiy-storchaka mentioned this pull request Dec 4, 2022
[3.10] gh-60203: Always pass True/False as boolean arguments in tests… #99989
Merged
@bedevere-bot

bedevere-bot commented Dec 4, 2022

Copy link
Copy Markdown

GH-99989 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Dec 4, 2022
miss-islington added a commit that referenced this pull request Dec 4, 2022
@miss-islington @serhiy-storchaka
gh-60203: Always pass True/False as boolean arguments in tests (GH-99983
7aa87bb 
)

Unless we explicitly test non-bool values.
(cherry picked from commit 76f43fc)

Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka added a commit that referenced this pull request Dec 4, 2022
@serhiy-storchaka
[3.10] gh-60203: Always pass True/False as boolean arguments in tests (…
ac78128 
…GH-99983) (GH-99989)

Unless we explicitly test non-bool values.
(cherry picked from commit 76f43fc)
@serhiy-storchaka serhiy-storchaka removed their assignment Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead Awaiting requested review from gpshead gpshead is a code owner
@1st1 1st1 Awaiting requested review from 1st1
@asvetlov asvetlov Awaiting requested review from asvetlov
@gvanrossum gvanrossum Awaiting requested review from gvanrossum
@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@serhiy-storchaka @miss-islington @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.