GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Update `patchcheck` description by EvanLai88 · Pull Request #1031 · python/devguide

Conversation

@EvanLai88

@EvanLai88 EvanLai88 commented Jan 15, 2023

Copy link
Copy Markdown
Contributor

patchcheck.py, reindent.py are moved from Tools\scripts\ to Tools\patchcheck\
Ref: python/cpython#98186

reindent-rst.py are deleted.
whitespaces in docs are handled by patchcheck.py itself
Ref: python/cpython#97675

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
EvanLai88 added 2 commits January 15, 2023 14:38
@EvanLai88
Update path to patchcheck.py
c4ec567
@EvanLai88
Update path to reindent.py and clear deleted file
35ecd7c
CAM-Gerlach
CAM-Gerlach reviewed Jan 15, 2023
View reviewed changes

@CAM-Gerlach CAM-Gerlach left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe worth updating the CPython source file paths in this section to use :cpy-file:, so that the actual files are linked directly, and in the future linkcheck will report a warning if they are ever moved or deleted again?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread getting-started/pull-request-lifecycle.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@EvanLai88 @CAM-Gerlach
Link with :cpy-file: directly
7c801b9 
Co-authored-by: C.A.M. Gerlach <[email protected]>
CAM-Gerlach
CAM-Gerlach approved these changes Jan 16, 2023
View reviewed changes

@CAM-Gerlach CAM-Gerlach left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks, FWIW

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@CAM-Gerlach
CAM-Gerlach requested a review from ezio-melotti January 16, 2023 03:40
ezio-melotti
ezio-melotti approved these changes Jan 16, 2023
View reviewed changes
@ezio-melotti
ezio-melotti merged commit 55b0c14 into python:main Jan 16, 2023
@EvanLai88
EvanLai88 deleted the patchcheck-py branch February 3, 2023 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CAM-Gerlach CAM-Gerlach CAM-Gerlach approved these changes
@ezio-melotti ezio-melotti ezio-melotti approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@EvanLai88 @CAM-Gerlach @ezio-melotti
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.