GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-97669: Remove outdated example scripts by vstinner · Pull Request #97675 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Sep 30, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Remove outdated example scripts. Copy them from Python 3.11 if you still need them.

Removed scripts:

  • byext.py
  • byteyears.py
  • cleanfuture.py
  • copytime.py
  • crlf.py
  • db2pickle.py
  • dutree.doc
  • dutree.py
  • find-uname.py
  • find_recursionlimit.py
  • finddiv.py
  • findlinksto.py
  • findnocoding.py
  • fixcid.py
  • fixdiv.py
  • fixheader.py
  • fixnotice.py
  • fixps.py
  • get-remote-certificate.py
  • google.py
  • highlight.py
  • ifdef.py
  • import_diagnostics.py
  • lfcr.py
  • linktree.py
  • lll.py
  • mailerdaemon.py
  • make_ctype.py
  • mkreal.py
  • objgraph.py
  • pdeps.py
  • pickle2db.py
  • pindent.py
  • pysource.py
  • reindent-rst.py
  • rgrep.py
  • suff.py
  • texi2html.py
  • which.py

Changes:

  • Remove test_fixcid, test_lll, test_pdeps and test_pindent of test.test_tools.
  • Remove get-remote-certificate.py changelog entry, since the script was removed.
  • FYI there is a copy of crlf.py in Lib/test/test_lib2to3/data/.
  • Issue: Remove outdated Tools/scripts/ example scripts #97669

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
vstinner requested review from a team, brettcannon, encukou, ericsnowcurrently, ncoghlan and warsaw as code owners September 30, 2022 12:47
@bedevere-bot bedevere-bot added the awaiting core review label Sep 30, 2022
@vstinner vstinner mentioned this pull request Sep 30, 2022
gh-97669: Remove outdated example scripts #97674
Closed
@vstinner

vstinner commented Sep 30, 2022

Copy link
Copy Markdown
Member Author

Here is a first PR to remove scripts which look outdated to me. The remaining ones might be useful or are referenced in other parts of Python, so I prefer to write separated PRs for the other scripts that I plan to remove.

Since my first version, I restored md5sum.py and parse_html5_entities.py removed by mistake. I alsot restored untabify.py since it's used by patchcheck.py.

Note: first I created PR #97674 on the branch name "main" which is not convenient, so I closed it and created this PR instead.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner mentioned this pull request Sep 30, 2022
Remove outdated Tools/scripts/ example scripts #97669
Closed
@ericsnowcurrently

ericsnowcurrently commented Sep 30, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

It would be good to preserve at least some of these before this PR (or other PRs) get merged. See my post at https://discuss.python.org/t/remove-outdated-tools-scripts-scripts/19571/22.

I'm okay with simply finding the scripts on the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
gvanrossum
gvanrossum approved these changes Oct 3, 2022
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might preserve these too (in the same repo) but not right now. Go ahead with the removal though.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Oct 3, 2022
@vstinner

vstinner commented Oct 3, 2022

Copy link
Copy Markdown
Member Author

I might preserve these too (in the same repo) but not right now. Go ahead with the removal though.

Once most scripts will be removed and a copy of these scripts will be created, we can document the removal in What's New In Python 3.12 with a link to this copy.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@warsaw

warsaw commented Oct 3, 2022

Copy link
Copy Markdown
Member

mailerdaemon.py can probably be replaced (possibly with some wrapper code) with flufl.bounce.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
gpshead
gpshead approved these changes Oct 3, 2022
View reviewed changes
gvanrossum
gvanrossum approved these changes Oct 3, 2022
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. I expect that we may be removing one or two scripts that are still depended on by some platform or workflow, but that's okay -- we'll just restore those when we get complaints.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@gvanrossum

gvanrossum commented Oct 3, 2022

Copy link
Copy Markdown
Member

And yes, these are now also in my https://github.com/gvanrossum/old-demos repo.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ezio-melotti
ezio-melotti reviewed Oct 4, 2022
View reviewed changes
Comment thread Misc/NEWS.d/next/Tools-Demos/2022-09-30-14-30-12.gh-issue-97669.gvbgcg.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
gh-97669: Remove outdated example scripts
483b623 
Remove outdated example scripts of the Tools/scripts/ directory. A
copy can be found in the old-demos project:
https://github.com/gvanrossum/old-demos

Removed scripts (39):

* byext.py
* byteyears.py
* cleanfuture.py
* copytime.py
* crlf.py
* db2pickle.py
* dutree.doc
* dutree.py
* find-uname.py
* find_recursionlimit.py
* finddiv.py
* findlinksto.py
* findnocoding.py
* fixcid.py
* fixdiv.py
* fixheader.py
* fixnotice.py
* fixps.py
* get-remote-certificate.py
* google.py
* highlight.py
* ifdef.py
* import_diagnostics.py
* lfcr.py
* linktree.py
* lll.py
* mailerdaemon.py
* make_ctype.py
* mkreal.py
* objgraph.py
* pdeps.py
* pickle2db.py
* pindent.py
* pysource.py
* reindent-rst.py
* rgrep.py
* suff.py
* texi2html.py
* which.py

Changes:

* Remove test_fixcid, test_lll, test_pdeps and test_pindent
  of test.test_tools.
* Remove get-remote-certificate.py changelog entry, since the script
  was removed.

Note: there is a copy of crlf.py in Lib/test/test_lib2to3/data/.
@vstinner

vstinner commented Oct 4, 2022

Copy link
Copy Markdown
Member Author

I completed to doc to mention the removal in What's New in Python 3.12 with a link to https://github.com/gvanrossum/old-demos
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner merged commit 6cbbc26 into python:main Oct 4, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Oct 4, 2022
@vstinner
vstinner deleted the remove_scripts branch October 4, 2022 08:49
@vstinner

vstinner commented Oct 4, 2022

Copy link
Copy Markdown
Member Author

Ok, I removed a first batch of outdated scripts.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner added a commit that referenced this pull request Oct 11, 2022
@vstinner
gh-97669: Remove outdated example scripts (#97675) (#98167)
e0ae9dd 
Remove outdated example scripts of the Tools/scripts/ directory:

* gprof2html.py
* md5sum.py
* nm2def.py
* pathfix.py
* win_add2path.py

Remove test_gprof2html, test_md5sum and test_pathfix of test_tools.
@EvanLai88 EvanLai88 mentioned this pull request Jan 15, 2023
Update patchcheck description python/devguide#1031
Merged
@arhadthedev arhadthedev mentioned this pull request Apr 29, 2023
Remove non-existing tools from Sundry skiplist #103991
Merged
@methane methane mentioned this pull request Sep 29, 2026
win_add2path.py does not add user site directory #71883
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezio-melotti ezio-melotti ezio-melotti left review comments
@gpshead gpshead gpshead approved these changes
@gvanrossum gvanrossum gvanrossum approved these changes
@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner
@encukou encukou Awaiting requested review from encukou
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner
@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@vstinner @ericsnowcurrently @warsaw @gvanrossum @gpshead @ezio-melotti @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.