GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Update location of the stable_abi.py script by encukou · Pull Request #1103 · python/devguide

Conversation

@encukou

@encukou encukou commented May 30, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Fixes: #1102

📚 Documentation preview 📚: https://cpython-devguide--1103.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@encukou
Update location of the stable_abi.py script
895cd13
@encukou encukou mentioned this pull request May 30, 2023
Instructions for adding a new definition to the limited API don't work on platforms without make #1102
Closed
AlexWaygood
AlexWaygood reviewed May 30, 2023
View reviewed changes
Comment thread developer-workflow/c-api.rst
.. code-block:: shell

./python ./Tools/scripts/stable_abi.py --all ./Misc/stable_abi.toml
./python ./Tools/build/stable_abi.py --all ./Misc/stable_abi.toml

@AlexWaygood AlexWaygood May 30, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one still fails on my machine with a fresh build of 3.12 FYI:

> python ./Tools/build/stable_abi.py --all ./Misc/stable_abi.toml
Running Debug|x64 interpreter...
Traceback (most recent call last):
  File "C:\Users\alexw\coding\cpython\Tools\build\stable_abi.py", line 757, in <module>
    main()
  File "C:\Users\alexw\coding\cpython\Tools\build\stable_abi.py", line 723, in main
    results['unixy_check'] = do_unixy_check(manifest, args)
                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\alexw\coding\cpython\Tools\build\stable_abi.py", line 394, in do_unixy_check
    present_macros = gcc_get_limited_api_macros(['Include/Python.h'])
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\alexw\coding\cpython\Tools\build\stable_abi.py", line 526, in gcc_get_limited_api_macros
    sysconfig.get_config_var("CC").split()
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'split'

But at least the instructions now point to scripts that actually exist 😆

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@encukou

encukou commented May 30, 2023

Copy link
Copy Markdown
Member Author

Whoa! I've meant to exclude that on Windows, but apparently I forgot!

(un)fortunately there currently aren't any extra checks to run on Windows, so as a workaround, instead of --all you can:

  • use --generate-all
  • check that git diff is empty
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou

encukou commented May 30, 2023

Copy link
Copy Markdown
Member Author

Issue: python/cpython#105091
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou
encukou merged commit 940cc97 into python:main May 30, 2023
@encukou
encukou deleted the sa-loc branch May 30, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygood AlexWaygood AlexWaygood left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Instructions for adding a new definition to the limited API don't work on platforms without make

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@encukou @AlexWaygood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.