Description

encukou

opened on May 30, 2023

Issue body actions

The --all command from the devguide fails on Windows.

--all should only enable unixy_check on Unixy platforms.

Linked PRs

• gh-105091: stable_abi.py: Remove "Unixy" check from --all on other platforms #105092
• [3.12] gh-105091: stable_abi.py: Remove "Unixy" check from --all on other platforms (GH-105092) #105133

Activity

1. encukou

   added

   type-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error

   buildThe build process and cross-buildThe build process and cross-build

   on May 30, 2023
2. encukou commented on May 30, 2023

   

   encukou

   on May 30, 2023

   MemberAuthor

   More actions

   @AlexWaygood Could you wrap

   cpython/Tools/build/stable_abi.py

   Line 687 in bd98b65

   args.unixy_check = True

   in if UNIXY: and check if it solves the issue?
3. AlexWaygood commented on May 30, 2023

   

   AlexWaygood

   on May 30, 2023

   Member

   More actions

   @AlexWaygood Could you wrap

   cpython/Tools/build/stable_abi.py

   Line 687 in bd98b65

   args.unixy_check = True

   in if UNIXY: and check if it solves the issue?

   Yup, this fixes things on my machine!

   --- a/Tools/build/stable_abi.py
   +++ b/Tools/build/stable_abi.py
   @@ -684,7 +684,8 @@ def main():
   
        if args.all:
            run_all_generators = True
   -        args.unixy_check = True
   +        if UNIXY:
   +            args.unixy_check = True
   
        try:
            file = args.file.open('rb')
4. encukou

   added 2 commits that reference this issue on May 30, 2023

   pythongh-105091: stable_abi.py: Remove "Unixy" check from --all on ot…

   a4687da

   gh-105091: stable_abi.py: Remove "Unixy" check from --all on other pl…

   0656d23
5. encukou

   closed this as completedon May 30, 2023
6. carljm

   added a commit that references this issue on May 30, 2023

   Merge branch 'main' into superbadgetattro

   24e1159
7. miss-islington

   added a commit that references this issue on May 31, 2023

   pythongh-105091: stable_abi.py: Remove "Unixy" check from --all on ot…

   56ec4a7
8. encukou

   added a commit that references this issue on May 31, 2023

   [3.12] gh-105091: stable_abi.py: Remove "Unixy" check from --all on o…

   4729100

Issue actions