GeezerVison is showing github.com — Update deps and build instructions wrt. libmpdecimal by erlend-aasland · Pull Request #1313 · python/devguide
Conversation
erlend-aasland
commented
Apr 29, 2024
•
edited by github-actions
Bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
erlend-aasland
changed the title
macOS: Recommend building with system installed libmpdecimal
Update deps and build instructions wrt. libmpdecimal
Apr 29, 2024
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, although, once we change the configure default for --with-system-libmpdec there really wouldn't need to be a separate recipe for 3.13, as long as people didn't care which version of libmpdec is being used.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
erlend-aasland reacted with thumbs up emoji
|
Thanks for the review!
LGTM, although, once we change the configure default for --with-system-libmpdec there really wouldn't need to be a separate recipe for 3.13, [...]
Yep.
[...] as long as people didn't care which version of libmpdec is being used.
I don't think the devguide recipe is the place for that user group; for people who care about a particular version of a build dependency, we have https://docs.python.org/3/using/configure.html 1.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
zware
Awaiting requested review from zware
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.