GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Added copyright link for the devguide by jablonskidev · Pull Request #665 · python/devguide

Conversation

jablonskidev commented Mar 20, 2021

Copy link

Copy Markdown

Contributor

In order to resolve issues #652 and #653 in the devguide (which are duplicates of each other), we added a theme variable to python_docs_theme/layout.html in PR #67. This will allow all users of the python-docs-theme library to have more functionality and backwards compatibility. In addition, if users don't define a link for copyright information, then they won't have a broken link that leads to nowhere in their page footer.

In order to have the correct copyright link for the devguide specifically, we just needed to specify it in the html_theme_options dictionary in the devguide's conf.py, which I did in this commit.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Added copyright link for the devguide

ce0e204

In order to resolve issues python#652 and python#653 in the devguide (which are duplicates of each other), we added a theme variable to `python_docs_theme/layout.html` in PR python#67. This will allow all users of the python-docs-theme library to have more functionality and backwards compatibility. In addition, if users don't define a link for copyright information, then they won't have a broken link that leads to nowhere in their page footer.

In order to have the correct copyright link for the devguide specifically, we just needed to specify it in the `html_theme_options` dictionary in the devguide's `conf.py`, which I did in this commit.

the-knights-who-say-ni added the CLA signed label

Mar 20, 2021

jablonskidev commented Mar 20, 2021

Copy link

Copy Markdown

Contributor Author

@CAM-Gerlach The build failed because the changes to python_docs_theme/layout.html that we discussed in PR #67 for python-docs-theme have not yet been merged. Here's the error message:

From what I understand, I just need to wait for you to merge the changes to python_docs_theme/layout.html, and then we can test that the changes I'm proposing in this PR work.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

CAM-Gerlach commented Mar 21, 2021

Copy link

Copy Markdown

Member

Yup, exactly, except I'm not an org member, just a drive-by contributor, so I can't merge anything haha! That's up to @Mariatta , I assume, and depends on how you have your infra set up to pull in the theme (which I'm not really familiar with). Thanks!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

matrixise commented May 5, 2021

Copy link

Copy Markdown

Member

Hi @jablonskidev

Could you check with my python/python-docs-theme#67 (comment) ?

Thank you

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

CAM-Gerlach commented Dec 11, 2021

Copy link

Copy Markdown

Member

Hey, looks like the theme changes were merged @jablonskidev . Any chance this could get a rebuild?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

hugovk commented Jan 27, 2022

Copy link

Copy Markdown

Member

Let's close this because the devguide is now using the Furo theme instead (#679) which doesn't support the copyright_url option:

https://pradyunsg.me/furo/customisation/#theme-options

But thanks anyway for the PR!

CAM-Gerlach reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

hugovk closed this

Jan 27, 2022

CAM-Gerlach commented Jan 27, 2022

Copy link

Copy Markdown

Member

Oh well; so much for all that, heh.

hugovk reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

hugovk commented Jan 27, 2022

Copy link

Copy Markdown

Member

On the bright side, python_docs_theme was improved for others :)

CAM-Gerlach reacted with hooray emoji

All reactions

🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.