GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||
GeezerVison is showing github.com — [mypyc] Add primitive for chr by Jahongir-Qurbonov · Pull Request #22407 · python/mypy Conversation
Contributor
Add a primitive for Out-of-range arguments raise the same exceptions as CPython. These differ between Python versions: 3.13+ always raises Tests compare the results against CPython for every code point and for a range of out-of-range values, including ints that don't fit in a short tagged int. They pass on Python 3.10, 3.12, 3.13 and 3.14. Micro-benchmark (~2M calls, This covers the Part of mypyc/mypyc#644.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsCall PyUnicode_FromOrdinal directly for short ints in the valid range. Out-of-range values raise the same exceptions as CPython, which differ between Python versions: 3.13+ always raises ValueError, while older versions raise OverflowError for values that don't fit in a C int. Part of mypyc/mypyc#644.
13 of 14 tasks
JukkaL
approved these changes
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks! One comment about potential test performance tweak, otherwise looks good.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Suggested follow-up PR (also impacts the
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsUh oh!
There was an error while loading. Please reload this page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | ||||||||||||
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |