GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [mypyc] Add primitive for chr by Jahongir-Qurbonov · Pull Request #22407 · python/mypy

Conversation

@Jahongir-Qurbonov

@Jahongir-Qurbonov Jahongir-Qurbonov commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Add a primitive for chr(int). Short ints in the valid range call PyUnicode_FromOrdinal directly, instead of looking up builtins.chr and calling it through vectorcall with a boxed argument.

Out-of-range arguments raise the same exceptions as CPython. These differ between Python versions: 3.13+ always raises ValueError, while 3.12 and earlier raise OverflowError for values that don't fit in a C int.

Tests compare the results against CPython for every code point and for a range of out-of-range values, including ints that don't fit in a short tagged int. They pass on Python 3.10, 3.12, 3.13 and 3.14.

Micro-benchmark (~2M calls, chr(i) for i in range(32, 1024), the same module compiled before and after this change, Python 3.13): 0.065s -> 0.019s.

This covers the chr part of #15937, which has been inactive since 2024. ord(str) has since been added separately.

Part of mypyc/mypyc#644.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Jahongir-Qurbonov added 3 commits November 9, 2026 12:07
@Jahongir-Qurbonov
[mypyc] Add primitive for chr
f35801e
Call PyUnicode_FromOrdinal directly for short ints in the valid range.
Out-of-range values raise the same exceptions as CPython, which differ
between Python versions: 3.13+ always raises ValueError, while older
versions raise OverflowError for values that don't fit in a C int.

Part of mypyc/mypyc#644.
@Jahongir-Qurbonov
Fix chr() error type for non-short ints that fit in a C int on 32-bit…
7d77322
… platforms
@Jahongir-Qurbonov
Remove redundant chr() overflow test
34db537
@Jahongir-Qurbonov Jahongir-Qurbonov mentioned this pull request Nov 10, 2026
More primitives mypyc/mypyc#644
Open
13 of 14 tasks
JukkaL
JukkaL approved these changes Nov 12, 2026
View reviewed changes

@JukkaL JukkaL left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One comment about potential test performance tweak, otherwise looks good.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread mypyc/test-data/run-strings.test

def test_chr_all_code_points() -> None:
f: Any = chr
for i in range(0x110000):

@JukkaL JukkaL Nov 12, 2026

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested follow-up PR (also impacts the is* method PRs): Checking all the valid code points is a bit slow, especially through a dynamic code path. I think it would be better to check only a sample, e.g. every Nth code point larger than 0x10000 or something.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@Jahongir-Qurbonov Jahongir-Qurbonov Nov 12, 2026

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Done in #22448, and also in #22405 and #22406.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@JukkaL
JukkaL merged commit 33b8e5f into python:master Nov 12, 2026
19 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@Jahongir-Qurbonov Jahongir-Qurbonov mentioned this pull request Nov 12, 2026
[mypyc] Only check a sample of non-BMP code points in str tests #22448
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JukkaL JukkaL JukkaL approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Jahongir-Qurbonov @JukkaL
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.