GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [mypyc] Only check a sample of non-BMP code points in str tests by Jahongir-Qurbonov · Pull Request #22448 · python/mypy

Conversation

@Jahongir-Qurbonov

@Jahongir-Qurbonov Jahongir-Qurbonov commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

Follow-up to the review comment in #22407.

Tests for chr(), str.lower()/str.upper(), str.isspace(), str.isdigit() and the str.is* methods added in #22404 compared the result against the generic implementation for every code point (0 to 0x10FFFF), which is slow, especially through the generic code path.

Now these tests check all code points in the BMP, which covers the 1-byte and 2-byte string kinds, and every 97th code point above it, plus the largest code point. This is about 76K code points instead of 1.1M.

The same change is applied to the tests in #22405 and #22406.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Jahongir-Qurbonov
[mypyc] Only check a sample of non-BMP code points in str tests
589f7d9 
Tests for chr() and several str methods compared the result against the
generic implementation for every code point, which is slow, especially
when using the generic implementation. Check all code points in the BMP,
which covers the 1-byte and 2-byte string kinds, and every 97th code
point above it (and the largest one).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@Jahongir-Qurbonov
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.