GeezerVison

Copy link

Copy Markdown

Member

erictraut approved these changes Apr 24, 2023

View reviewed changes

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

gvanrossum reviewed Apr 24, 2023

View reviewed changes

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

JelleZijlstra commented Apr 25, 2023

View reviewed changes

erictraut reviewed Apr 25, 2023

View reviewed changes

JelleZijlstra commented Apr 26, 2023

View reviewed changes

JelleZijlstra marked this pull request as ready for review April 26, 2023 16:27

AlexWaygood reviewed Apr 26, 2023

View reviewed changes

gvanrossum approved these changes Apr 26, 2023

View reviewed changes

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

- TypeAlias(identifier name, typeparam* typeparams, expr value)
+ TypeAlias(expr name, typeparam* typeparams, expr value)

gvanrossum approved these changes Apr 27, 2023

View reviewed changes

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

class Foo[__T]:
    def method(self, val: __T): # Does this work?
        x: __T = val # Does this work?

>>> class A: pass
... 
>>> class Foo[__T](print(locals()) or A): pass
... 
{'_Foo__T': __T, '.generic_base': typing.Generic[__T], '.type_params': (__T,)}

AlexWaygood reviewed May 4, 2023

View reviewed changes

JelleZijlstra commented May 4, 2023

View reviewed changes

markshannon reviewed May 4, 2023

View reviewed changes

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

hauntsaninja reviewed May 5, 2023

View reviewed changes

JelleZijlstra deleted the pep695change branch May 8, 2023 18:21

…ython#3122)

- Lazy evaluation means that referencing a later type variable works at runtime
- Disallow walrus in TypeVar bounds, and also disallow yield/yield from/await
  in the same contexts
- Remove rejection of lambda lifting; that is the implementation we are using now
- Change the AST
- Change of direction on mangling
- More precise scoping rules

Co-authored-by: Alex Waygood <[email protected]>
Co-authored-by: Shantanu <[email protected]>

* Improve PEP 649's description of its semantics.

* Stipulate that name resolution for annotations
  under 649 must be *identical* to stock semantics.
* *Don't* specify exactly the mechanism that conformant
  implementations must use to implement 649.  Instead,
  *do* describe how CPython might do it, but leave the
  actual details of how to implement 649 up to each
  language implementation.
* Incorporate Jelle's suggestion that the formats for
  inspect.get_annotations() be in an enum.IntEnum.

* Fix lint.

* PEP 693: Postpone 3.12.0b1 by two weeks (#3139)

* PEP 695: Lazy evaluation, concrete scoping semantics, other changes (#3122)

- Lazy evaluation means that referencing a later type variable works at runtime
- Disallow walrus in TypeVar bounds, and also disallow yield/yield from/await
  in the same contexts
- Remove rejection of lambda lifting; that is the implementation we are using now
- Change the AST
- Change of direction on mangling
- More precise scoping rules

Co-authored-by: Alex Waygood <[email protected]>
Co-authored-by: Shantanu <[email protected]>

* Incorporate changes from feedback, mark Accepted.

* Fix PEP 12 header *order compliance*.  Wow.

* Fix Sphinx complaints.

* Make enum consistent, flesh out observed semantics.

* Add "Resolution" header, as pointed out by Hugo.

* Switch to other URL for Resolution header.

* Apply ``global_enum`` to ``inspect.AnnotationFormat``

* Final? text / semantics cleanup pass.

* "accept" -> "accepts".  Bettering my Englishes.

* Add new "post history" reflecting the updates.

* Update post history with all conversations, courtesy CAM!

Co-authored-by: C.A.M. Gerlach <[email protected]>

* Fix typo.  Thanks, Emily!

Co-authored-by: Emily Morehouse <[email protected]>

* Add "Discussions-To" header.  Thanks, CAM!

Co-authored-by: C.A.M. Gerlach <[email protected]>

* Attempt to satisfy "validate-post-history" hook.

---------

Co-authored-by: Hugo van Kemenade <[email protected]>
Co-authored-by: Jelle Zijlstra <[email protected]>
Co-authored-by: Alex Waygood <[email protected]>
Co-authored-by: Shantanu <[email protected]>
Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: C.A.M. Gerlach <[email protected]>
Co-authored-by: Emily Morehouse <[email protected]>