GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Infra: Use a list of authors in `peps.json` by AA-Turner · Pull Request #4226 · python/peps

Conversation

@AA-Turner

@AA-Turner AA-Turner commented Jan 24, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Closes #4211.

Alternatively, we could just use a different seperator (;)? The authors field of peps.json was originally intended for literal reproduction without any re-parsing, hence why I joined the alreay-parsed list of authors into a string.

A


📚 Documentation preview 📚: https://pep-previews--4226.org.readthedocs.build/peps.json

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@AA-Turner
Use a list of authors in peps.json
e99d6ef
@AA-Turner AA-Turner added the infra Core infrastructure for building and rendering PEPs label Jan 24, 2025
@AA-Turner
Refresh api/index
d72de34
@AA-Turner
AA-Turner requested a review from a team as a code owner January 24, 2025 00:27
@AA-Turner
AA-Turner requested review from hugovk and removed request for a team January 24, 2025 00:27
@hugovk

hugovk commented Jan 24, 2025

Copy link
Copy Markdown
Member

I think the first question is if we want to break backwards compatibility?

I lean to not breaking compatibility. If so, the other options are:

  • keep the authors string using a different separator (for example, ";")
  • keep the authors string and add a new array of author strings
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@warsaw

warsaw commented Jan 24, 2025

Copy link
Copy Markdown
Member

keep the authors string and add a new array of author strings

I'd vote for keeping authors as is, and adding (something like) author_list as the array of author strings to keep backward compatibility.

hugovk, davep, and encukou reacted with thumbs up emoji
All reactions
  • 👍 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@AA-Turner
Add a new field
31d8aeb
@AA-Turner

AA-Turner commented Jan 24, 2025

Copy link
Copy Markdown
Member Author

From a cursory search, it seems the vast majority of instances of peps.json in the wild are reproductions of the 723 example:

https://github.com/search?q=%22https%3A%2F%2Fpeps.python.org%2Fapi%2Fpeps.json%22+NOT+is%3Afork+NOT+is%3Aarchived&type=code

But sure, happy to add as a new field. The only negative would be the file size (~15% increase).

A

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@AA-Turner
Add author_list to the exemplar
fa0a645
hugovk
hugovk reviewed Jan 25, 2025
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a cursory search, it seems the vast majority of instances of peps.json in the wild are reproductions of the 723 example:

github.com/search?q=%22https%3A%2F%2Fpeps.python.org%2Fapi%2Fpeps.json%22+NOT+is%3Afork+NOT+is%3Aarchived&type=code

Here's a couple that would have broken (but I'm sure we could have convinced the authors to update :)

  • https://github.com/brettcannon/brettcannon/blob/42eb826a969bd9430053193e3fb5f74a43b74f77/free-labour.py#L309
  • https://github.com/JacobCoffee/byte/blob/336008fe8c42850d313c912f8e34a92bb02bffe4/byte_bot/byte/lib/utils.py#L430

But sure, happy to add as a new field. The only negative would be the file size (~15% increase).

Yep, I think 331K -> 368K is okay. Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

AA-Turner reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Comment thread pep_sphinx_extensions/pep_zero_generator/parser.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread pep_sphinx_extensions/pep_zero_generator/parser.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread peps/api/index.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread peps/api/index.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

@hugovk hugovk changed the title Use a list of authors in peps.json Infra: Use a list of authors in peps.json Jan 25, 2025
@hugovk hugovk mentioned this pull request Jan 26, 2025
Infra: only create peps.json at /api/peps.json #4231
Merged
AA-Turner added 3 commits February 1, 2025 09:54
@AA-Turner
Merge remote-tracking branch 'refs/remotes/upstream/main' into comma
cc936e9
@AA-Turner
Incorporate Hugo's request
0d3d770
@AA-Turner
typo
ed7127a
hugovk
hugovk approved these changes Feb 3, 2025
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread peps/api/index.rst
The structure is like:

.. code-block:: javascript
.. code-block:: typescript

@hugovk hugovk Feb 3, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does typescript give nicer formatting than javascript?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@AA-Turner AA-Turner Feb 3, 2025

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, especially since we now use Array<...>

Current:

image

Proposed:

image

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

hugovk reacted with rocket emoji
All reactions
  • 🚀 1 reaction
@AA-Turner
AA-Turner merged commit 686562b into python:main Feb 3, 2025
@AA-Turner
AA-Turner deleted the comma branch February 3, 2025 15:19
@davep davep mentioned this pull request Feb 4, 2025
Swap to using author_names rather than the janky authors splitter davep/peplum#29
Closed
ethanfurman pushed a commit to ethanfurman/peps that referenced this pull request Oct 8, 2026
@AA-Turner @ethanfurman
Infra: Use a list of authors in peps.json (python#4226)
d97a467
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

infra Core infrastructure for building and rendering PEPs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PEPs API: handle name with commas in CSV author list

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@AA-Turner @hugovk @warsaw
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.