GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — PEP 661: Amend to allow two customizations by JelleZijlstra · Pull Request #4968 · python/peps

Conversation

@JelleZijlstra

@JelleZijlstra JelleZijlstra commented May 10, 2026

Copy link
Copy Markdown
Member

These are changes I'd like to make during the beta phase (I'll post asking for SC approval).

  • Change is either:
    • To a Draft PEP
    • To an Accepted or Final PEP, with Steering Council approval
    • To fix an editorial issue (markup, typo, link, header, etc)
  • PR title prefixed with PEP number (e.g. PEP 123: Summary of changes)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JelleZijlstra
PEP 661: Amend to allow two customizations
b687905
@JelleZijlstra
JelleZijlstra requested a review from taleinat as a code owner May 10, 2026 22:48
@read-the-docs-community

read-the-docs-community Bot commented May 10, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Documentation build overview

📚 pep-previews | 🛠️ Build #32627747 | 📁 Comparing 7dd698f against latest (0cde95d)

  🔍 Preview build  

699 files changed · ± 699 modified

± Modified

  • pep-0001/index.html
  • pep-0002/index.html
  • pep-0003/index.html
  • pep-0004/index.html
  • pep-0005/index.html
  • pep-0006/index.html
  • pep-0007/index.html
  • pep-0008/index.html
  • pep-0009/index.html
  • pep-0010/index.html
  • and 689 more...
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra
C
7dd698f
@JelleZijlstra JelleZijlstra mentioned this pull request May 10, 2026
gh-148829: Make sentinels' repr and module customizable python/cpython#149654
Merged
@taleinat

taleinat commented May 11, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Both of these, customizable repr and setting __module__, were in earlier versions of the PEP and make sense.

Regarding making repr customizable by passing in an argument, LGTM.

Regarding making __module__ writeable, I find that a bit surprising. Have you considered adding another argument to sentinel()? That would be more in line with namedtuple and Enum which do this for similar reasons, and be more in line with sentinels being immutable. (I see Kyle made a similar comment in the PEP discussion.)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra

JelleZijlstra commented May 19, 2026

Copy link
Copy Markdown
Member Author

The SC approved this change.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra
JelleZijlstra merged commit 7dd79b1 into python:main May 19, 2026
5 checks passed

Uh oh!

There was an error while loading. Please reload this page.
JelleZijlstra added a commit to python/cpython that referenced this pull request May 19, 2026
@JelleZijlstra
gh-148829: Make sentinels' repr and module customizable (#149654)
0821803 
Implementation of python/peps#4968; still needs SC approval.
@miss-islington miss-islington mentioned this pull request May 19, 2026
[3.15] gh-148829: Make sentinels' repr and module customizable (GH-149654) python/cpython#150092
Merged
JelleZijlstra added a commit to python/cpython that referenced this pull request May 22, 2026
@miss-islington @JelleZijlstra
[3.15] gh-148829: Make sentinels' repr and module customizable (GH-14…
f523146 
…9654) (#150092)

Implementation of python/peps#4968.
(cherry picked from commit 0821803)

Co-authored-by: Jelle Zijlstra <[email protected]>
ethanfurman pushed a commit to ethanfurman/peps that referenced this pull request Oct 8, 2026
@JelleZijlstra @ethanfurman
PEP 661: Amend to allow two customizations (python#4968)
6d8bb83
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@taleinat taleinat Awaiting requested review from taleinat

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@JelleZijlstra @taleinat
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.