GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Make option to invert/modify colors for documentation pages · Issue #145 · python/python-docs-theme

Make option to invert/modify colors for documentation pages #145

New issue
Copy link
New issue
Copy link
Closed
Closed
Make option to invert/modify colors for documentation pages#145
Copy link

Description

@brandonardenwalli
brandonardenwalli
opened on Aug 14, 2023
Issue body actions

Feature or enhancement

When reading the docs page in dark mode with night shift, some variables are invisible to see. For example in https://docs.python.org/3/c-api/intro.html#types, int, long, double and char* are impossible to read without highlighting the text. This looks to affect any other parts of docs with same coloring too, for example all texts typedef on https://docs.python.org/3/c-api/typeobj.html page are practically invisible.

Environment:

Enable dark mode for system/browser (black background), AND enable night shift. I think there are multiple ways to do so, for example Windows has built in night shift mode to enable screen to be more orange (basically make screen have less blue light). For easiest reproduction, download f.lux and set color to 1900K (or as low as possible). Look at page again, and all the dark blue text, for example the type and typedef texts, became invisible.

Pitch

The docs will be much more readable and improve accessibility for bigger audience if the text colors can be modified. I'm not sure how much work this would require, but can be happy to provide feedback. Alternatively, if making the docs text configurable by end user is too much work, just hard code a more friendly color that is readable with dark mode and night shift enabled.

Let me know if you want more information!

Activity

  1. hugovk
    transferred this issue frompython/cpythonon Aug 14, 2023
  2. hugovk commented on Aug 14, 2023

    @hugovk
    hugovk
    on Aug 14, 2023
    Member
    More actions

    (I've transferred this from https://github.com/python/cpython to https://github.com/python/python-docs-theme)

    Thanks for the report!

    This is a contrast bug, already fixed in #133 and released in https://github.com/python/python-docs-theme/releases/tag/2023.7, but we had to skip that release due to #144 / #141.

    Let's revert #141 so we can make a new release.

  3. brandonardenwalli commented on Aug 15, 2023

    @brandonardenwalli
    brandonardenwalli
    on Aug 15, 2023 · Hidden as off-topic
    Author
    show commentMore actions
  4. hugovk commented on Aug 15, 2023

    @hugovk
    hugovk
    on Aug 15, 2023 · Hidden as off-topic
    show commentMore actions
  5. brandonardenwalli commented on Aug 16, 2023

    @brandonardenwalli
    brandonardenwalli
    on Aug 16, 2023 · Hidden as off-topic
    Author
    show commentMore actions
  6. hugovk commented on Oct 19, 2023

    @hugovk
    hugovk
    on Oct 19, 2023
    Member
    More actions

    This has now been released and deployed, and the contrast is now improved. Thanks!

  7. hugovk
    closed this as completedon Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      You are visitor 01402503 — GeezerVison does not store the pages you look up.
      Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.