GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Dark theme · Issue #43 · python/python-docs-theme

Dark theme #43

New issue
Copy link
New issue
Copy link
Closed
#44
Closed
Dark theme#43
#44
Copy link

Description

@vitaly-zdanevich
vitaly-zdanevich
opened on Feb 1, 2020
Issue body actions

Please save our eyes. And batteries. Do not ignore this property of useragent https://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-color-scheme

Cross-defect with https://bugs.python.org/issue39518

Reacted by Nils K, Maciej Wiatr, Hugo van Kemenade, Hugo Valencia Vargas, dariush-bahrami, Pedro Fonini, Jonathan , Václav Brožík, AliQ, Alex Wright and 9 more

Activity

  1. opensource-assist commented on Feb 3, 2020

    @opensource-assist
    opensource-assist
    on Feb 3, 2020
    More actions

    @vitaly-zdanevich
    How about this?

  2. vitaly-zdanevich commented on Feb 4, 2020

    @vitaly-zdanevich
    vitaly-zdanevich
    on Feb 4, 2020
    Author
    More actions

    I know about such extensions, but this is only for desktop browser. Youtube has dark theme, Google Calendar has dark theme on mobile - this is basic feature, dark theme is not for beauty - dark theme is against pain in eyes.

    You need to add maybe 10 lines of CSS. I can do it if you approve me.

  3. opensource-assist commented on Feb 4, 2020

    @opensource-assist
    opensource-assist
    on Feb 4, 2020
    More actions

    @vitaly-zdanevich

    I know about such extensions, but this is only for desktop browser. Youtube has dark theme, Google Calendar has dark theme on mobile - this is basic feature, dark theme is not for beauty - dark theme is against pain in eyes.

    You need to add maybe 10 lines of CSS. I can do it if you approve me.

    Why don't you do the PR on CPython's repo? The docs are served in there.

  4. vitaly-zdanevich commented on Feb 4, 2020

    @vitaly-zdanevich
    vitaly-zdanevich
    on Feb 4, 2020
    Author
    More actions

    But theme is in this repository.

  5. septatrix commented on Feb 5, 2020

    @septatrix
    septatrix
    on Feb 5, 2020
    Contributor
    More actions

    If you don't mind I'd like to work on this issue and make a pull request with some design drafts...

    Reacted by Aurora Lanes
  6. vitaly-zdanevich commented on Feb 5, 2020

    @vitaly-zdanevich
    vitaly-zdanevich
    on Feb 5, 2020
    Author
    More actions

    Ok.

  7. septatrix commented on Feb 5, 2020

    @septatrix
    septatrix
    on Feb 5, 2020
    Contributor
    More actions

    Just pushed a first draft if you want to take a look (#44)...

    Reacted by Hugo Valencia Vargas, Helio Machado and Oleg Iarygin
    Reacted by Hugo van Kemenade, Helio Machado and Paulo Ferreira de Castro
  8. flying-sheep commented on Oct 25, 2022

    @flying-sheep
    flying-sheep
    on Oct 25, 2022
    More actions

    What’s missing before #44 will be merged?

  9. hugovk commented on Oct 25, 2022

    @hugovk
    hugovk
    on Oct 25, 2022
    Member
    More actions

    We're currently blocked due to lack of clarity whether we can use Sphinx 3 or need to keep support for 1.8:

    #44 (comment)

  10. AA-Turner commented on Oct 25, 2022

    @AA-Turner
    AA-Turner
    on Oct 25, 2022
    Member
    More actions

    It was resolved to 3.2 (python/cpython#93337), though the pin to python-docs-theme==2022.1 should probably be introduced and backported to all non EOL versions, which are currently all unpinned (https://github.com/python/cpython/blob/3.7/Doc/requirements.txt#L18)

    A

    Reacted by Hugo van Kemenade and Bengt Lüers
  11. septatrix commented on Nov 4, 2022

    @septatrix
    septatrix
    on Nov 4, 2022
    Contributor
    More actions

    I should have time to rebase the PR on the current master this weekend

    Reacted by Mike Lui, Tristan Koch and Paulo Ferreira de Castro
  12. hugovk
    closed this as completedin #44on Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      You are visitor 01402503 — GeezerVison does not store the pages you look up.
      Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.