GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Reduce footer margin only for desktop by hugovk · Pull Request #106 · python/python-docs-theme

Conversation

@hugovk

@hugovk hugovk commented Feb 6, 2023

Copy link
Copy Markdown
Member

Fixes #100.

The margin above the footer is currently reduced by 2em.

Desktop

This makes sense for desktop widths (1024+ pixels). With the reduction:

Screenshot image

If it was removed for desktop there's a bigger gap between the "Quick search" box and the copyright line:

Screenshot image

Mobile

But on mobile (< 1024 pixels), it hides the copyright line:

Screenshot image

So let's remove this margin only for desktops:

Screenshot image

Demo build

https://hugovk-python-docs-theme.readthedocs.io/en/fix-footer-demo/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hugovk hugovk added the bug label Feb 6, 2023
@hugovk hugovk mentioned this pull request Feb 6, 2023
Footer nav and copyright text not visible at low viewport widths in docs #100
Closed
@hugovk
Reduce footer only for desktop
9913e1d
@hugovk
hugovk force-pushed the fix-footer branch from f84219d to 9913e1d Compare February 13, 2023 11:05
@hugovk

hugovk commented Feb 13, 2023

Copy link
Copy Markdown
Member Author

Rebased on main to check the RTD deploy preview (#70 / #105)... success! ✅

https://python-docs-theme-previews--106.org.readthedocs.build/en/106/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ezio-melotti
ezio-melotti reviewed Feb 13, 2023
View reviewed changes
Comment thread python_docs_theme/static/pydoctheme.css
}
}

@media (min-width: 1024px) {

@ezio-melotti ezio-melotti Feb 13, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested this in landscape mode (assuming that's supported)?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@hugovk hugovk Feb 13, 2023

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's a narrow landscape mode (iPhone SE):

image

And a wide landscape mode (iPad Air):

image

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ezio-melotti reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
pradyunsg
pradyunsg approved these changes Feb 13, 2023
View reviewed changes
@hugovk
hugovk merged commit b84c913 into python:main Feb 16, 2023
@hugovk
hugovk deleted the fix-footer branch February 16, 2023 11:42
@hugovk hugovk mentioned this pull request Mar 6, 2023
New release? #109
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezio-melotti ezio-melotti ezio-melotti left review comments
@pradyunsg pradyunsg pradyunsg approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Footer nav and copyright text not visible at low viewport widths in docs

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@hugovk @pradyunsg @ezio-melotti
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.