Description

hugovk

opened on Mar 6, 2023

Issue body actions

The last release was https://github.com/python/python-docs-theme/releases/tag/2022.1 in January 2022.

There's been a few bug fixes merged since then:

• 2022.1...main

Notably:

• Fix problem with monospace rendering in Vivaldi #104
• Fix mobile nav obstructing content #96
• Reduce footer margin only for desktop #106
• Append a hash ?digest to CSS files for cache-busting #108

My main motivation for a release is the dark theme: #44

I think it's ready for merge and release, but if we want to be safe, I suggest we make one release with the bugfixes, followed by another with the dark theme. That gives us the option to easily rollback in case there are any big issues.

cc @JulienPalard and @Mariatta :)

Reacted by Maciej Olko

Activity

1. JulienPalard

   closed this as completedin #110on Mar 10, 2023
2. JulienPalard commented on Mar 10, 2023

   

   JulienPalard

   on Mar 10, 2023

   Member

   More actions

   Tag pushed, build one, testing one last time by building cpython doc with it locally...

   $ cd cpython/Doc
   $ make venv
   $ ./venv/bin/pip install ../../python-docs-theme/dist/python_docs_theme-2023.3-py3-none-any.whl 
   $ make htmlview

   Looks good to me, uploading to pypi.
3. hugovk commented on Mar 13, 2023

   

   hugovk

   on Mar 13, 2023

   MemberAuthor

   More actions

   Please could we have a new bugfix release with #113 to fix #108 (comment)?

   It's causing docs build errors for 3.10 for example at python/cpython#102638.
4. JulienPalard commented on Mar 13, 2023

   

   JulienPalard

   on Mar 13, 2023

   Member

   More actions

   Working on it!
5. JulienPalard commented on Mar 13, 2023

   

   JulienPalard

   on Mar 13, 2023

   Member

   More actions

   @hugovk done.

   Reacted by Maciej Olko

   Reacted by Maciej Olko
6. hugovk commented on Mar 13, 2023

   

   hugovk

   on Mar 13, 2023

   MemberAuthor

   More actions

   I restarted https://github.com/python/cpython/actions/runs/4403319435 and it passed now.

   Thank you!

   Reacted by Maciej Olko

   Reacted by Maciej Olko

Issue actions