GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Sphinx 6.2 fix: add nav.contents where that div.topic is used by hugovk · Pull Request #138 · python/python-docs-theme

Conversation

@hugovk

@hugovk hugovk commented Jul 27, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Fixes #132 by applying the same fix as sphinx-doc/sphinx@5806f0a.

See #132 (comment) for details.

Compare:

  • Before: https://docs.python.org/3.13/library/asyncio-task.html
  • After: https://python-docs-theme-previews--138.org.readthedocs.build/en/138/library/asyncio-task.html
Before After

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland reacted with rocket emoji
All reactions
  • 🚀 1 reaction
@hugovk
Sphinx 6.2 fix: add nav.contents where that div.topic is used
cd41ccd
@hugovk hugovk added the bug label Jul 27, 2023
@hugovk
hugovk marked this pull request as ready for review July 27, 2023 10:54
@hugovk hugovk mentioned this pull request Jul 27, 2023
Dark mode: topic background colour not applied in Sphinx 6.2.0 #132
Closed
AA-Turner
AA-Turner approved these changes Jul 27, 2023
View reviewed changes
@hugovk
hugovk merged commit 4e88b11 into python:main Jul 30, 2023
@hugovk
hugovk deleted the fix-dark-mode-topic-bg branch July 30, 2023 08:19
This was referenced Aug 24, 2023
Incorrectly highlighted paragraph in dark theme #149
Closed
Dark mode: Also give aside.topic a dark background #150
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AA-Turner AA-Turner AA-Turner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Dark mode: topic background colour not applied in Sphinx 6.2.0

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@hugovk @AA-Turner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.