GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Dark mode: Also give aside.topic a dark background by hugovk · Pull Request #150 · python/python-docs-theme

Conversation

@hugovk

@hugovk hugovk commented Aug 24, 2023

Copy link
Copy Markdown
Member

Fixes #149.

PR #138 added nav.contents to places where div.note and div.topic were given a dark background.

This new one:

image

isn't any of those. Instead it's an aside.topic:

image

Let's give it a dark background too:

image

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hugovk
Dark mode: Also give aside.topic a dark background
c39a9f1
@hugovk hugovk mentioned this pull request Aug 24, 2023
Incorrectly highlighted paragraph in dark theme #149
Closed
m-aciek
m-aciek approved these changes Aug 24, 2023
View reviewed changes
ezio-melotti
ezio-melotti approved these changes Aug 25, 2023
View reviewed changes
AA-Turner
AA-Turner approved these changes Aug 25, 2023
View reviewed changes
@hugovk
hugovk merged commit 3eb3746 into python:main Aug 25, 2023
@hugovk
hugovk deleted the dark-mode-aside-topic branch August 25, 2023 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AA-Turner AA-Turner AA-Turner approved these changes
@ezio-melotti ezio-melotti ezio-melotti approved these changes
+1 more reviewer
@m-aciek m-aciek m-aciek approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Incorrectly highlighted paragraph in dark theme

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@hugovk @AA-Turner @m-aciek @ezio-melotti
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.