GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||||
GeezerVison is showing github.com — Bugfix: quote monospace font by tusharsadhwani · Pull Request #85 · python/python-docs-theme Conversation
|
|
See https://twitter.com/sadhlife/status/1446060335979397120 for the sleuthing :) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Good work! As it happens, this is fixed in the upcoming Chrome 96: python/pythondotorg#1708 (comment) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Despite the upcoming fix in Chrome, this is such a simple fix, I think it's worth merging for people who will still be on Chrome < 96, even after Chrome 96 release.
(Plus for people using latest Chrome 94 now :)
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Oh this kind of bugs … ☹ |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thanks @tusharsadhwani and @nedbat! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I released it as python-docs-theme 2021-11 (I live in the future) and rebuilt https://docs.python.org/3/ so someone can check. Rebuild for other versions and languages will be automatically done in the next 24h. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
This "fix" broke the font for me. My Chrome on my Mac is now loading Helvetica for code rather than Courier. I can confirm that removing the quotes from |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Chrome, showing 3 different behaviours on 3 operating systems. A tale as old as time. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Perhaps the best fix is to just specify monospace. Why a fallback to sans-serif? Does any browser not have a monospace font that is used when you specify monospace? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Removing the quotes from monospace even with it being the only specified font breaks on current chrome mobile. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
So... Do we need one monospace with quotes and one monospace without quotes? 🙃
The problem seems to be desktop isn't picking up the "monospace" and falling back to sans-serif. If we remove sans-serif, it'll fall back to some system default, which will be some sans-serif or serif, but not monospace. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Okay, I tested on 3.9's page, and it seems just pre { font-family: monospace; } seems to work. Can someone test it on all 3 platforms, android mac and windows, that'd be great. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Noticed my Firefox 93.0 on win10 is weirded by |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
✨ This is an old work account. Please reference @brandonchinn178 for all future communication ✨ Can confirm, currently fonts on |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Can confirm, works fine. Even on mobile where just |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
There is (or was) a known problem with plain And necolas/normalize.css#519 (comment) suggests a reason, browsers looked for the fixed string |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Ah, that makes sense now. So I guess |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
MacOS Chrome 94 Both solutions work for me. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@beauremus Thanks a bunch. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.