GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix problem with monospace rendering in Vivaldi by ZedThree · Pull Request #104 · python/python-docs-theme

Conversation

@ZedThree

@ZedThree ZedThree commented Jan 30, 2023

Copy link
Copy Markdown
Contributor

Fixes #98

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ZedThree
Fix problem with monospace rendering in Vivaldi
15c8fc9 
Fixes python#98
@ghost

ghost commented Jan 30, 2023 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ezio-melotti
ezio-melotti reviewed Jan 30, 2023
View reviewed changes

@ezio-melotti ezio-melotti left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What browsers have you tested this with?
Do we know why the quoted `"monospace" was included and should we keep it somewhere in the list?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hugovk

hugovk commented Jan 31, 2023

Copy link
Copy Markdown
Member

Quoted "monospace" was added in #85 to workaround a Chrome bug, which was fixed in Chrome 96 (Nov 2021): python/pythondotorg#1708 (comment).

By now, there's very little usage of Chrome 96 and older versions. Chrome 96% is 0.04% at https://caniuse.com/usage-table, and it's something like 1.68% for 96 and older.

(It would be good if we could hook up PR previews on Read the Docs or Netlify, that would make testing easier.)
ezio-melotti reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ZedThree

ZedThree commented Jan 31, 2023

Copy link
Copy Markdown
Contributor Author

I tested with Vivaldi 5.6.2867.62 and Firefox 109.0
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hugovk
hugovk approved these changes Jan 31, 2023
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested building CPython docs locally using:

diff --git a/Doc/requirements.txt b/Doc/requirements.txt
index 134f39d6d7..c6d9c6a663 100644
--- a/Doc/requirements.txt
+++ b/Doc/requirements.txt
@@ -12,4 +12,4 @@ sphinxext-opengraph>=0.7.1
 
 # The theme used by the documentation is stored separately, so we need
 # to install that as well.
-python-docs-theme>=2022.1
+git+https://github.com/ZedThree/python-docs-theme@fix-monospace-vivaldi#egg=python-docs-theme

Looks fine on macOS Ventura 13.1 and Chrome 108:

image

And Safari 16.2:

image

And Firefox 109:

image

And Opera 93:

image

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hugovk

hugovk commented Jan 31, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

And I've put a preview build up at https://hugovk-cpython.readthedocs.io/en/python-docs-theme-pr-104/ if anyone else wants to test it.

Looks fine with Chrome 109 on Samsung S10 with Android 12.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ezio-melotti
ezio-melotti approved these changes Feb 2, 2023
View reviewed changes
@hugovk
hugovk merged commit f769cf3 into python:main Feb 6, 2023
@hugovk

hugovk commented Feb 6, 2023

Copy link
Copy Markdown
Member

Thank you!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ZedThree
ZedThree deleted the fix-monospace-vivaldi branch February 6, 2023 09:37
@hugovk hugovk mentioned this pull request Mar 6, 2023
New release? #109
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes
@ezio-melotti ezio-melotti ezio-melotti approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Weird monospace bug

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@ZedThree @hugovk @ezio-melotti
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.