GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix mobile nav obstructing content by philg314 · Pull Request #96 · python/python-docs-theme

Conversation

@philg314

@philg314 philg314 commented Aug 8, 2022

Copy link
Copy Markdown
Contributor

Instead of adding the height of .mobile-nav at the top of .document it is now added at the top of body.

Closes #95

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@philg314 @hugovk
Fix mobile nav obstructing content
a51bc0a
@hugovk
hugovk force-pushed the nav-margin branch from e005a18 to a51bc0a Compare February 13, 2023 11:12
@hugovk

hugovk commented Feb 13, 2023

Copy link
Copy Markdown
Member

(Rebased on main to retrigger the CI and create an RTD build preview: https://python-docs-theme-previews--96.org.readthedocs.build/en/96/)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

hugovk
hugovk approved these changes Feb 13, 2023
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing locally with the banner enabled on the 3.8 branch:

diff --git a/Doc/tools/templates/layout.html b/Doc/tools/templates/layout.html
index 98ccf42248..0151a00593 100644
--- a/Doc/tools/templates/layout.html
+++ b/Doc/tools/templates/layout.html
@@ -1,13 +1,11 @@
 {% extends "!layout.html" %}
 
 {% block header %}
-{%- if outdated %}
 <div id="outdated-warning" style="padding: .5em; text-align: center; background-color: #FFBABA; color: #6A0E0E;">
     {% trans %}This document is for an old version of Python that is no longer supported.
     You should upgrade, and read the {% endtrans %}
     <a href="/3/{{ pagename }}{{ file_suffix }}">{% trans %} Python documentation for the current stable release{% endtrans %}</a>.
 </div>
-{%- endif %}
 {% endblock %}
 
 {% block rootrellink %}

Before

After

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
pradyunsg
pradyunsg approved these changes Feb 13, 2023
View reviewed changes
@pradyunsg
pradyunsg merged commit 8e007f6 into python:main Feb 13, 2023
@pradyunsg

pradyunsg commented Feb 13, 2023

Copy link
Copy Markdown
Member

Thanks for the screenshots on this @hugovk! ^.^

hugovk reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@hugovk hugovk mentioned this pull request Mar 6, 2023
New release? #109
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes
@pradyunsg pradyunsg pradyunsg approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Documentation with responsive theme (3.8+) will hide "not supported" banner behind navbar for mobile layouts

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@philg314 @hugovk @pradyunsg
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.