GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Make slice generic by Sachaa-Thanasius · Pull Request #11637 · python/typeshed

Conversation

Sachaa-Thanasius commented Mar 20, 2024 •

edited by srittau

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Mainly doing this out of curiosity to see the primer hits.

EDIT: Would close #8647.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

jorenham and lorenzo-w reacted with heart emoji

All reactions

❤️ 2 reactions

Sachaa-Thanasius added 2 commits

March 20, 2024 10:17


          Make slice generic

Want to see the primer hits.


          Fix typo in _StartT as default for _StopT

Sachaa-Thanasius closed this

Mar 20, 2024

This comment has been minimized.

JelleZijlstra commented Mar 20, 2024

Copy link

Copy Markdown

Member

cc @cdce8p I think the primer hits suggest a mypy bug where it looks up "_StartT" in the wrong scope.

AlexWaygood reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

cdce8p commented Mar 20, 2024

Copy link

Copy Markdown

Contributor

cc @cdce8p I think the primer hits suggest a mypy bug where it looks up "_StartT" in the wrong scope.

Recursive TypeVar defaults was one of the things that didn't make it into 1.9.0 unfortunately. I did do some work on it already, but that isn't released yet: python/mypy#16878. Don't know if it's enough for slice yet though.

If you're interested, maybe that's also something for @AlexWaygood, a few weeks back I created a custom repo to upload dev releases of mypy to PyPI under the mypy-dev project name. They always track a mypy commit upstream and are great to test / use the lasted version (even in production if you feel like it). mypy --version still works as expected. I originally created it as it was unclear when 1.9.0 would actually be released. In the past the release frequency was also a bit more unpredictable.

https://github.com/cdce8p/mypy-dev
https://github.com/cdce8p/mypy-dev/releases

AlexWaygood reacted with heart emoji

All reactions

❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sachaa-Thanasius commented Mar 20, 2024

Copy link

Copy Markdown

Contributor Author

I just assumed my attempt at implementation was wrong and gave up. Should this be reopened, then?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

JelleZijlstra commented Mar 20, 2024

Copy link

Copy Markdown

Member

Thanks @cdce8p, I forgot that PR didn't make it into 1.9. Hopefully we'll have another release soon. Your mypy-dev project is interesting; maybe that's even something we could do on mypy itself. For example, we could have a weekly cron job uploading alpha releases.

@Sachaa-Thanasius I think we may be able to merge this PR after mypy 1.10 is released (when that will happen, I don't know). You can leave it open in the meantime and mark it as deferred. With some hackery it may be possible to point typeshed's CI at the mypy master branch so we can test earlier whether everything works as expected.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sachaa-Thanasius reopened this

Mar 21, 2024

Sachaa-Thanasius commented Mar 21, 2024

Copy link

Copy Markdown

Contributor Author

Understood. Should slice be changed in the runtime cpython as well to support __class_getitem__ via GenericAlias, or is this purely meant to be a typeshed thing? Not something I considered when originally opening this, but now that this actually has a chance of going somewhere . . .

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sachaa-Thanasius commented Mar 21, 2024

Copy link

Copy Markdown

Contributor Author

Also, sidenote: The pyright errors specifically for slice.stop and and the first overload of slice.__new__ (with text like the following) are the result of a bug that was fixed earlier today, I think:

Type parameter "_StopT" has a default type that refers to one or more type variables that are out of scope
    Type variable "_StartT" is not in scope

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This comment has been minimized.

cdce8p commented Mar 21, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

With some hackery it may be possible to point typeshed's CI at the mypy master branch so we can test earlier whether everything works as expected.

@Sachaa-Thanasius You could try to replace the mypy version listed in requirements-tests.txt.

typeshed/requirements-tests.txt

Line 8 in 5c75292

mypy==1.9.0

-mypy==1.9.0
+mypy-dev==1.10.0a2

That release tracks python/mypy@b013cc0 which was commited fairly recently to mypy master (5 days ago).

Update: Seems like the mypy primer doesn't work for it, unfortunately.

Sachaa-Thanasius reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

srittau added the status: deferred Issue or PR deferred until some precondition is fixed label

Mar 21, 2024


          Merge branch 'main' into generic-slice

956d74f

This comment has been minimized.


          Merge branch 'main' into generic-slice

ff3d6e7

This comment has been minimized.

cdce8p mentioned this pull request

Mar 24, 2024

TypeVar default refers to variables that are out of scope microsoft/pyright#7553

Closed


          Merge branch 'main' into generic-slice

3e52ed5

This comment has been minimized.


          Merge branch 'main' into generic-slice

307ed3c

This comment has been minimized.

Sachaa-Thanasius commented Apr 24, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor Author

Well, that's far more promising than before. Still not sure if this needs to be reflected in cpython by adding a __class_getitem__ to slice.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

srittau removed the status: deferred Issue or PR deferred until some precondition is fixed label

Apr 24, 2024

srittau commented Apr 24, 2024

Copy link

Copy Markdown

Collaborator

I've removed the Deferred label. I've just looked at spark primer output. The problem is on their side, since they reuse the start variable for different types.

Sachaa-Thanasius reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sachaa-Thanasius commented Apr 24, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor Author

The error that pyright is hitting is that the usage of itertools.starmap doesn't resolve the types of slice.

# Truncated setup.

from collections.abc import Iterator, Sequence
from itertools import combinations, repeat, starmap
from operator import getitem
from typing import TypeVar, cast

_T = TypeVar("_T")


# Actual function

def subslices(seq: Sequence[_T]) -> Iterator[Sequence[_T]]:
    slices = starmap(slice, combinations(range(len(seq) + 1), 2))
    reveal_type(slices)  # Type of "slices" is "starmap[slice[_StartT@slice, _StopT@slice, _StepT@slice]]"

    # Adding this cast removes the error on the final line:
    # slices = cast(starmap[slice[int, int, int | None]], slices)

    # And using a generator instead of starmap removes the error on the final line as well:
    # slices = (slice(*args) for args in combinations(range(len(seq) + 1), 2))

    return map(getitem, repeat(seq), slices)  # Long error.

Full playground example here to recreate the conditions of the error.

Might be more of a deficiency in the typing of starmap (or something else with pyright’s analysis) than anything with slice. Not sure how to fix it though.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

hamdanal commented Apr 27, 2024

Copy link

Copy Markdown

Contributor

I might be missing something obvious but it is not clear to me why the type of stop has to default to the type of start. At runtime start is None if it is not passed to the constructor:

$ cat t.py
from typing_extensions import reveal_type

s = slice(10)
reveal_type(s)
reveal_type(s.start)
reveal_type(s.stop)
reveal_type(s.step)
$ python t.py
Runtime type is 'slice'
Runtime type is 'NoneType'
Runtime type is 'int'
Runtime type is 'NoneType'

Similarly, the type of step should default to None.

So I would expect the definitions of the type variables to be:

_StartT = TypeVar("_StartT", default=None)
_StopT = TypeVar("_StopT", default=int)
_StepT = TypeVar("_StepT", default=None)

Gobot1234 reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sachaa-Thanasius commented May 3, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor Author

I won’t lie; I just copy-pasted the example implementation from PEP 696 without much thought, since this PR wasn’t originally opened with the intention of being merged. Haven’t double-checked since. Definitely will take another look though.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Merge branch 'main' into generic-slice

f451d34

AlexWaygood added 2 commits

October 24, 2024 12:39


          Merge branch 'main' into generic-slice

8c25be1


          fix failing test

15da628

github-actions Bot commented Oct 24, 2024

Copy link

Copy Markdown

Contributor

Diff from mypy_primer, showing the effect of this PR on open source code:

prefect (https://github.com/PrefectHQ/prefect)
- src/prefect/utilities/annotations.py:41: note:          def __getitem__(self, slice, /) -> tuple[Never, ...]
+ src/prefect/utilities/annotations.py:41: note:          def __getitem__(self, slice[Any, Any, Any], /) -> tuple[Never, ...]
- src/prefect/utilities/annotations.py:41: note:          def __getitem__(self, slice, /) -> Sequence[Never]
+ src/prefect/utilities/annotations.py:41: note:          def __getitem__(self, slice[Any, Any, Any], /) -> Sequence[Never]
- src/prefect/cli/cloud/__init__.py:326: note:     def __getitem__(self, SupportsIndex | slice, /) -> str
+ src/prefect/cli/cloud/__init__.py:326: note:     def __getitem__(self, SupportsIndex | slice[Any, Any, Any], /) -> str
- src/prefect/cli/deploy.py:1132: note:     def __setitem__(self, slice, Iterable[dict[Any, Any]], /) -> None
+ src/prefect/cli/deploy.py:1132: note:     def __setitem__(self, slice[Any, Any, Any], Iterable[dict[Any, Any]], /) -> None
- src/prefect/cli/deploy.py:1158: note:     def __setitem__(self, slice, Iterable[dict[Any, Any]], /) -> None
+ src/prefect/cli/deploy.py:1158: note:     def __setitem__(self, slice[Any, Any, Any], Iterable[dict[Any, Any]], /) -> None
- src/prefect/cli/deploy.py:1166: note:     def __setitem__(self, slice, Iterable[dict[Any, Any]], /) -> None
+ src/prefect/cli/deploy.py:1166: note:     def __setitem__(self, slice[Any, Any, Any], Iterable[dict[Any, Any]], /) -> None
- src/prefect/cli/deploy.py:1183: note:     def __getitem__(self, slice, /) -> list[dict[Any, Any]]
+ src/prefect/cli/deploy.py:1183: note:     def __getitem__(self, slice[Any, Any, Any], /) -> list[dict[Any, Any]]

werkzeug (https://github.com/pallets/werkzeug)
- tests/test_wrappers.py:522: note:     def __setitem__(self, slice, Iterable[tuple[str, str]], /) -> None
+ tests/test_wrappers.py:522: note:     def __setitem__(self, slice[Any, Any, Any], Iterable[tuple[str, str]], /) -> None
- tests/test_wrappers.py:563: note:     def __setitem__(self, slice, Iterable[tuple[str, str]], /) -> None
+ tests/test_wrappers.py:563: note:     def __setitem__(self, slice[Any, Any, Any], Iterable[tuple[str, str]], /) -> None

streamlit (https://github.com/streamlit/streamlit)
- lib/tests/streamlit/elements/lib/column_config_utils_test.py:385:13: note:     def __getitem__(self, Union[SupportsIndex, slice], /) -> str
+ lib/tests/streamlit/elements/lib/column_config_utils_test.py:385:13: note:     def __getitem__(self, Union[SupportsIndex, slice[Any, Any, Any]], /) -> str
- lib/tests/streamlit/runtime/state/query_params_test.py:264:37: note:         def __getitem__(self, slice, /) -> Tuple[Any, ...]
+ lib/tests/streamlit/runtime/state/query_params_test.py:264:37: note:         def __getitem__(self, slice[Any, Any, Any], /) -> Tuple[Any, ...]

ibis (https://github.com/ibis-project/ibis)
- ibis/selectors.py:678: error: Incompatible types in assignment (expression has type "Slice", variable has type "str | int | slice | Iterable[int | str]")  [assignment]
+ ibis/selectors.py:678: error: Incompatible types in assignment (expression has type "Slice", variable has type "str | int | slice[Any, Any, Any] | Iterable[int | str]")  [assignment]
- ibis/selectors.py:679: error: Argument 1 to "ColumnIndex" has incompatible type "int | slice | Iterable[int | str]"; expected "str | int | Slice | tuple[int | str, ...]"  [arg-type]
+ ibis/selectors.py:679: error: Argument 1 to "ColumnIndex" has incompatible type "int | slice[None, Any, None] | Iterable[int | str]"; expected "str | int | Slice | tuple[int | str, ...]"  [arg-type]
- ibis/expr/types/arrays.py:147: error: Argument 2 to "ArraySlice" has incompatible type "Any | int"; expected "Value[Integer, Any]"  [arg-type]
+ ibis/expr/types/arrays.py:147: error: Argument 2 to "ArraySlice" has incompatible type "int"; expected "Value[Integer, Any]"  [arg-type]

speedrun.com_global_scoreboard_webapp (https://github.com/Avasam/speedrun.com_global_scoreboard_webapp)
- backend/api/tournament_scheduler_api.py:327: note:     def __getitem__(self, slice, /) -> list[Any]
+ backend/api/tournament_scheduler_api.py:327: note:     def __getitem__(self, slice[Any, Any, Any], /) -> list[Any]
- backend/api/tournament_scheduler_api.py:331: note:     def __getitem__(self, slice, /) -> list[Any]
+ backend/api/tournament_scheduler_api.py:331: note:     def __getitem__(self, slice[Any, Any, Any], /) -> list[Any]
- backend/api/tournament_scheduler_api.py:335: note:     def __getitem__(self, slice, /) -> list[Any]
+ backend/api/tournament_scheduler_api.py:335: note:     def __getitem__(self, slice[Any, Any, Any], /) -> list[Any]

pandas (https://github.com/pandas-dev/pandas)
+ pandas/core/array_algos/transforms.py:41: error: Argument 2 to "slice" has incompatible type "int"; expected "None"  [arg-type]
+ pandas/core/array_algos/transforms.py:43: error: Argument 1 to "slice" has incompatible type "int"; expected "None"  [arg-type]
+ pandas/core/algorithms.py:1387: error: Argument 2 to "slice" has incompatible type "int"; expected "None"  [arg-type]
+ pandas/core/algorithms.py:1387: error: Argument 1 to "slice" has incompatible type "int"; expected "None"  [arg-type]
+ pandas/core/algorithms.py:1387: error: Argument 2 to "slice" has incompatible type "None"; expected "int"  [arg-type]
+ pandas/core/algorithms.py:1398: error: Argument 1 to "slice" has incompatible type "int"; expected "None"  [arg-type]
+ pandas/core/algorithms.py:1398: error: Argument 1 to "slice" has incompatible type "None"; expected "int"  [arg-type]
+ pandas/core/algorithms.py:1398: error: Argument 2 to "slice" has incompatible type "int"; expected "None"  [arg-type]
+ pandas/core/algorithms.py:1402: error: Argument 2 to "slice" has incompatible type "int"; expected "None"  [arg-type]
+ pandas/core/algorithms.py:1402: error: Argument 1 to "slice" has incompatible type "int"; expected "None"  [arg-type]
+ pandas/core/algorithms.py:1402: error: Argument 2 to "slice" has incompatible type "None"; expected "int"  [arg-type]
+ pandas/core/indexes/multi.py:2501: error: No overload variant of "range" matches argument types "None", "Any", "int"  [call-overload]
+ pandas/core/indexes/multi.py:2501: note: Possible overload variants:
+ pandas/core/indexes/multi.py:2501: note:     def __new__(cls, SupportsIndex, /) -> range
+ pandas/core/indexes/multi.py:2501: note:     def __new__(cls, SupportsIndex, SupportsIndex, SupportsIndex = ..., /) -> range
+ pandas/core/indexes/multi.py:3490: error: "int" has no attribute "step"  [attr-defined]
+ pandas/core/indexes/multi.py:3536: error: Incompatible types in assignment (expression has type "ndarray[Any, dtype[signedinteger[Any]]] | signedinteger[Any]", variable has type "int")  [assignment]
+ pandas/core/indexes/base.py:6690: error: Incompatible return value type (got "None", expected "int")  [return-value]

spark (https://github.com/apache/spark)
+ python/pyspark/sql/classic/column.py:414: error: Argument 1 to "substr" of "Column" has incompatible type "None"; expected "int | Column"  [arg-type]
+ python/pyspark/sql/connect/column.py:552: error: Argument 1 to "substr" of "Column" has incompatible type "None"; expected "int | Column"  [arg-type]

scipy (https://github.com/scipy/scipy)
+ scipy/optimize/_isotonic.py:125: error: Argument 3 to "slice" has incompatible type "int"; expected "None"  [arg-type]

freqtrade (https://github.com/freqtrade/freqtrade)
+ freqtrade/exchange/exchange.py:2901: error: Argument 1 to "slice" has incompatible type "None"; expected "int"  [arg-type]

discord.py (https://github.com/Rapptz/discord.py)
- discord/http.py:233: note:     def __setitem__(self, slice, Iterable[Embed], /) -> None
+ discord/http.py:233: note:     def __setitem__(self, slice[Any, Any, Any], Iterable[Embed], /) -> None

jax (https://github.com/google/jax)
+ jax/_src/numpy/lax_numpy.py:715: error: Argument 3 to "slice" has incompatible type "int"; expected "None"  [arg-type]
+ jax/_src/numpy/lax_numpy.py:1785: error: Argument 1 to "slice" has incompatible type "int"; expected "None"  [arg-type]
+ jax/_src/numpy/lax_numpy.py:1786: error: Argument 2 to "slice" has incompatible type "int"; expected "None"  [arg-type]
+ jax/experimental/sparse/bcoo.py:1990: error: Argument 1 to "slice" has incompatible type "int"; expected "None"  [arg-type]
+ jax/experimental/sparse/bcoo.py:1990: error: Argument 2 to "slice" has incompatible type "int"; expected "None"  [arg-type]
+ jax/experimental/sparse/bcoo.py:1990: error: Argument 3 to "slice" has incompatible type "int"; expected "None"  [arg-type]
+ jax/experimental/sparse/bcoo.py:1991: error: Argument 1 to "slice" has incompatible type "int"; expected "None"  [arg-type]
+ jax/experimental/sparse/bcoo.py:1991: error: Argument 2 to "slice" has incompatible type "int"; expected "None"  [arg-type]
+ jax/experimental/sparse/bcoo.py:1991: error: Argument 3 to "slice" has incompatible type "int"; expected "None"  [arg-type]
+ jax/experimental/sparse/bcoo.py:1995: error: Argument 1 to "slice" has incompatible type "int"; expected "None"  [arg-type]
+ jax/experimental/sparse/bcoo.py:1995: error: Argument 2 to "slice" has incompatible type "int"; expected "None"  [arg-type]
+ jax/experimental/sparse/bcoo.py:1995: error: Argument 3 to "slice" has incompatible type "int"; expected "None"  [arg-type]

xarray (https://github.com/pydata/xarray)
+ xarray/core/dataset.py: note: In member "tail" of class "Dataset":
+ xarray/core/dataset.py:3412: error: Argument 1 to "slice" has incompatible type "int"; expected "None"  [arg-type]
+ xarray/core/dataset.py: note: At top level:
+ xarray/core/dataset.py: note: In member "diff" of class "Dataset":
+ xarray/core/dataset.py:7957: error: Incompatible types in assignment (expression has type "dict[Hashable, slice[None, int, None]]", variable has type "dict[Hashable, slice[int, None, None]]")  [assignment]
+ xarray/core/dataset.py: note: At top level:
+ xarray/tests/test_backends.py: note: In member "test_write_region_mode" of class "ZarrBase":
+ xarray/tests/test_backends.py:3007: error: No overload variant of "to_zarr" of "Dataset" matches argument types "Any", "object", "Any", "dict[str, Any]"  [call-overload]
+ xarray/tests/test_backends.py:3007: note: Possible overload variants:
+ xarray/tests/test_backends.py:3007: note:     def to_zarr(self, store: MutableMapping[Any, Any] | str | PathLike[str] | None = ..., chunk_store: MutableMapping[Any, Any] | str | PathLike[Any] | None = ..., mode: Literal['w', 'w-', 'a', 'a-', 'r+', 'r'] | None = ..., synchronizer: Any = ..., group: str | None = ..., encoding: Mapping[Any, Any] | None = ..., *, compute: Literal[True] = ..., consolidated: bool | None = ..., append_dim: Hashable | None = ..., region: Mapping[str, slice[Any, Any, Any] | Literal['auto']] | Literal['auto'] | None = ..., safe_chunks: bool = ..., storage_options: dict[str, str] | None = ..., zarr_version: int | None = ..., zarr_format: int | None = ..., write_empty_chunks: bool | None = ..., chunkmanager_store_kwargs: dict[str, Any] | None = ...) -> ZarrStore
+ xarray/tests/test_backends.py:3007: note:     def to_zarr(self, store: MutableMapping[Any, Any] | str | PathLike[str] | None = ..., chunk_store: MutableMapping[Any, Any] | str | PathLike[Any] | None = ..., mode: Literal['w', 'w-', 'a', 'a-', 'r+', 'r'] | None = ..., synchronizer: Any = ..., group: str | None = ..., encoding: Mapping[Any, Any] | None = ..., *, compute: Literal[False], consolidated: bool | None = ..., append_dim: Hashable | None = ..., region: Mapping[str, slice[Any, Any, Any] | Literal['auto']] | Literal['auto'] | None = ..., safe_chunks: bool = ..., storage_options: dict[str, str] | None = ..., zarr_version: int | None = ..., zarr_format: int | None = ..., write_empty_chunks: bool | None = ..., chunkmanager_store_kwargs: dict[str, Any] | None = ...) -> Any
+ xarray/tests/test_backends.py:3007: error: Argument 1 to "isel" of "Dataset" has incompatible type "object"; expected "Mapping[Any, Any] | None"  [arg-type]

operator (https://github.com/canonical/operator)
- ops/framework.py:1304: note:          def __getitem__(self, slice, /) -> MutableSequence[Any]
+ ops/framework.py:1304: note:          def __getitem__(self, slice[Any, Any, Any], /) -> MutableSequence[Any]
- ops/framework.py:1304: note:          def __getitem__(self, slice, /) -> Sequence[Any]
+ ops/framework.py:1304: note:          def __getitem__(self, slice[Any, Any, Any], /) -> Sequence[Any]
- ops/framework.py:1307: note:          def __setitem__(self, slice, Iterable[Any], /) -> None
+ ops/framework.py:1307: note:          def __setitem__(self, slice[Any, Any, Any], Iterable[Any], /) -> None
- ops/framework.py:1311: note:          def __delitem__(self, slice, /) -> None
+ ops/framework.py:1311: note:          def __delitem__(self, slice[Any, Any, Any], /) -> None

colour (https://github.com/colour-science/colour)
- colour/continuous/signal.py:843: error: No overload variant of "__call__" of "_ComparisonOpLE" matches argument type "slice"  [call-overload]
+ colour/continuous/signal.py:843: error: No overload variant of "__call__" of "_ComparisonOpLE" matches argument type "slice[Any, Any, Any]"  [call-overload]
- colour/continuous/signal.py:844: error: No overload variant of "__call__" of "_ComparisonOpGE" matches argument type "slice"  [call-overload]
+ colour/continuous/signal.py:844: error: No overload variant of "__call__" of "_ComparisonOpGE" matches argument type "slice[Any, Any, Any]"  [call-overload]

pandas-stubs (https://github.com/pandas-dev/pandas-stubs)
+ tests/test_frame.py:224: error: Expression is of type "Any", not "DataFrame"  [assert-type]
+ tests/test_frame.py:225: error: Expression is of type "Any", not "DataFrame"  [assert-type]

kornia (https://github.com/kornia/kornia)
+ kornia/contrib/models/sam/architecture/mask_decoder.py:92: error: Argument 2 to "slice" has incompatible type "int"; expected "None"  [arg-type]

manticore (https://github.com/trailofbits/manticore)
- tests/wasm/json2mc.py:103: note:     def __getitem__(self, slice, /) -> list[Any]
+ tests/wasm/json2mc.py:103: note:     def __getitem__(self, slice[Any, Any, Any], /) -> list[Any]
+ manticore/native/memory.py:229: error: Unsupported operand types for <= ("int" and "None")  [operator]

dd-trace-py (https://github.com/DataDog/dd-trace-py)
- ddtrace/settings/config.py:888: note:     def __getitem__(self, SupportsIndex | slice, /) -> str
+ ddtrace/settings/config.py:888: note:     def __getitem__(self, SupportsIndex | slice[Any, Any, Any], /) -> str

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Hedge

0692cd0

github-actions Bot commented Oct 24, 2024

Copy link

Copy Markdown

Contributor

Diff from mypy_primer, showing the effect of this PR on open source code:

prefect (https://github.com/PrefectHQ/prefect)
- src/prefect/utilities/annotations.py:41: note:          def __getitem__(self, slice, /) -> tuple[Never, ...]
+ src/prefect/utilities/annotations.py:41: note:          def __getitem__(self, slice[Any, Any, Any], /) -> tuple[Never, ...]
- src/prefect/utilities/annotations.py:41: note:          def __getitem__(self, slice, /) -> Sequence[Never]
+ src/prefect/utilities/annotations.py:41: note:          def __getitem__(self, slice[Any, Any, Any], /) -> Sequence[Never]
- src/prefect/cli/cloud/__init__.py:326: note:     def __getitem__(self, SupportsIndex | slice, /) -> str
+ src/prefect/cli/cloud/__init__.py:326: note:     def __getitem__(self, SupportsIndex | slice[Any, Any, Any], /) -> str
- src/prefect/cli/deploy.py:1132: note:     def __setitem__(self, slice, Iterable[dict[Any, Any]], /) -> None
+ src/prefect/cli/deploy.py:1132: note:     def __setitem__(self, slice[Any, Any, Any], Iterable[dict[Any, Any]], /) -> None
- src/prefect/cli/deploy.py:1158: note:     def __setitem__(self, slice, Iterable[dict[Any, Any]], /) -> None
+ src/prefect/cli/deploy.py:1158: note:     def __setitem__(self, slice[Any, Any, Any], Iterable[dict[Any, Any]], /) -> None
- src/prefect/cli/deploy.py:1166: note:     def __setitem__(self, slice, Iterable[dict[Any, Any]], /) -> None
+ src/prefect/cli/deploy.py:1166: note:     def __setitem__(self, slice[Any, Any, Any], Iterable[dict[Any, Any]], /) -> None
- src/prefect/cli/deploy.py:1183: note:     def __getitem__(self, slice, /) -> list[dict[Any, Any]]
+ src/prefect/cli/deploy.py:1183: note:     def __getitem__(self, slice[Any, Any, Any], /) -> list[dict[Any, Any]]

werkzeug (https://github.com/pallets/werkzeug)
- tests/test_wrappers.py:522: note:     def __setitem__(self, slice, Iterable[tuple[str, str]], /) -> None
+ tests/test_wrappers.py:522: note:     def __setitem__(self, slice[Any, Any, Any], Iterable[tuple[str, str]], /) -> None
- tests/test_wrappers.py:563: note:     def __setitem__(self, slice, Iterable[tuple[str, str]], /) -> None
+ tests/test_wrappers.py:563: note:     def __setitem__(self, slice[Any, Any, Any], Iterable[tuple[str, str]], /) -> None

streamlit (https://github.com/streamlit/streamlit)
- lib/tests/streamlit/elements/lib/column_config_utils_test.py:385:13: note:     def __getitem__(self, Union[SupportsIndex, slice], /) -> str
+ lib/tests/streamlit/elements/lib/column_config_utils_test.py:385:13: note:     def __getitem__(self, Union[SupportsIndex, slice[Any, Any, Any]], /) -> str
- lib/tests/streamlit/runtime/state/query_params_test.py:264:37: note:         def __getitem__(self, slice, /) -> Tuple[Any, ...]
+ lib/tests/streamlit/runtime/state/query_params_test.py:264:37: note:         def __getitem__(self, slice[Any, Any, Any], /) -> Tuple[Any, ...]

ibis (https://github.com/ibis-project/ibis)
- ibis/selectors.py:678: error: Incompatible types in assignment (expression has type "Slice", variable has type "str | int | slice | Iterable[int | str]")  [assignment]
+ ibis/selectors.py:678: error: Incompatible types in assignment (expression has type "Slice", variable has type "str | int | slice[Any, Any, Any] | Iterable[int | str]")  [assignment]
- ibis/selectors.py:679: error: Argument 1 to "ColumnIndex" has incompatible type "int | slice | Iterable[int | str]"; expected "str | int | Slice | tuple[int | str, ...]"  [arg-type]
+ ibis/selectors.py:679: error: Argument 1 to "ColumnIndex" has incompatible type "int | slice[Any, Any, Any] | Iterable[int | str]"; expected "str | int | Slice | tuple[int | str, ...]"  [arg-type]

speedrun.com_global_scoreboard_webapp (https://github.com/Avasam/speedrun.com_global_scoreboard_webapp)
- backend/api/tournament_scheduler_api.py:327: note:     def __getitem__(self, slice, /) -> list[Any]
+ backend/api/tournament_scheduler_api.py:327: note:     def __getitem__(self, slice[Any, Any, Any], /) -> list[Any]
- backend/api/tournament_scheduler_api.py:331: note:     def __getitem__(self, slice, /) -> list[Any]
+ backend/api/tournament_scheduler_api.py:331: note:     def __getitem__(self, slice[Any, Any, Any], /) -> list[Any]
- backend/api/tournament_scheduler_api.py:335: note:     def __getitem__(self, slice, /) -> list[Any]
+ backend/api/tournament_scheduler_api.py:335: note:     def __getitem__(self, slice[Any, Any, Any], /) -> list[Any]

spark (https://github.com/apache/spark)
+ python/pyspark/sql/classic/column.py:414: error: Argument 1 to "substr" of "Column" has incompatible type "Any | None"; expected "int | Column"  [arg-type]
+ python/pyspark/sql/connect/column.py:552: error: Argument 1 to "substr" of "Column" has incompatible type "Any | None"; expected "int | Column"  [arg-type]

pandas (https://github.com/pandas-dev/pandas)
+ pandas/core/array_algos/transforms.py:41: error: Argument 2 to "slice" has incompatible type "int"; expected "None"  [arg-type]
+ pandas/core/algorithms.py:1387: error: Argument 2 to "slice" has incompatible type "int"; expected "None"  [arg-type]
+ pandas/core/algorithms.py:1387: error: Argument 1 to "slice" has incompatible type "int"; expected "None"  [arg-type]
+ pandas/core/algorithms.py:1387: error: Argument 2 to "slice" has incompatible type "None"; expected "int"  [arg-type]
+ pandas/core/algorithms.py:1398: error: Argument 1 to "slice" has incompatible type "None"; expected "int"  [arg-type]
+ pandas/core/algorithms.py:1398: error: Argument 2 to "slice" has incompatible type "int"; expected "None"  [arg-type]
+ pandas/core/algorithms.py:1402: error: Argument 2 to "slice" has incompatible type "int"; expected "None"  [arg-type]
+ pandas/core/algorithms.py:1402: error: Argument 1 to "slice" has incompatible type "int"; expected "None"  [arg-type]
+ pandas/core/algorithms.py:1402: error: Argument 2 to "slice" has incompatible type "None"; expected "int"  [arg-type]
+ pandas/core/indexes/multi.py:2501: error: Argument 1 to "range" has incompatible type "Any | None"; expected "SupportsIndex"  [arg-type]
+ pandas/core/indexes/base.py:6690: error: Incompatible return value type (got "Any | None", expected "int")  [return-value]

discord.py (https://github.com/Rapptz/discord.py)
- discord/http.py:233: note:     def __setitem__(self, slice, Iterable[Embed], /) -> None
+ discord/http.py:233: note:     def __setitem__(self, slice[Any, Any, Any], Iterable[Embed], /) -> None

freqtrade (https://github.com/freqtrade/freqtrade)
+ freqtrade/exchange/exchange.py:2901: error: Argument 1 to "slice" has incompatible type "None"; expected "int"  [arg-type]

xarray (https://github.com/pydata/xarray)
+ xarray/core/dataset.py: note: In member "tail" of class "Dataset":
+ xarray/core/dataset.py:3412: error: Argument 1 to "slice" has incompatible type "int"; expected "None"  [arg-type]
+ xarray/core/dataset.py: note: At top level:
+ xarray/core/dataset.py: note: In member "diff" of class "Dataset":
+ xarray/core/dataset.py:7957: error: Incompatible types in assignment (expression has type "dict[Hashable, slice[None, int, Any | None]]", variable has type "dict[Hashable, slice[int, None, Any | None]]")  [assignment]
+ xarray/core/dataset.py: note: At top level:
+ xarray/tests/test_backends.py: note: In member "test_write_region_mode" of class "ZarrBase":
+ xarray/tests/test_backends.py:3007: error: No overload variant of "to_zarr" of "Dataset" matches argument types "Any", "object", "Any", "dict[str, Any]"  [call-overload]
+ xarray/tests/test_backends.py:3007: note: Possible overload variants:
+ xarray/tests/test_backends.py:3007: note:     def to_zarr(self, store: MutableMapping[Any, Any] | str | PathLike[str] | None = ..., chunk_store: MutableMapping[Any, Any] | str | PathLike[Any] | None = ..., mode: Literal['w', 'w-', 'a', 'a-', 'r+', 'r'] | None = ..., synchronizer: Any = ..., group: str | None = ..., encoding: Mapping[Any, Any] | None = ..., *, compute: Literal[True] = ..., consolidated: bool | None = ..., append_dim: Hashable | None = ..., region: Mapping[str, slice[Any, Any, Any] | Literal['auto']] | Literal['auto'] | None = ..., safe_chunks: bool = ..., storage_options: dict[str, str] | None = ..., zarr_version: int | None = ..., zarr_format: int | None = ..., write_empty_chunks: bool | None = ..., chunkmanager_store_kwargs: dict[str, Any] | None = ...) -> ZarrStore
+ xarray/tests/test_backends.py:3007: note:     def to_zarr(self, store: MutableMapping[Any, Any] | str | PathLike[str] | None = ..., chunk_store: MutableMapping[Any, Any] | str | PathLike[Any] | None = ..., mode: Literal['w', 'w-', 'a', 'a-', 'r+', 'r'] | None = ..., synchronizer: Any = ..., group: str | None = ..., encoding: Mapping[Any, Any] | None = ..., *, compute: Literal[False], consolidated: bool | None = ..., append_dim: Hashable | None = ..., region: Mapping[str, slice[Any, Any, Any] | Literal['auto']] | Literal['auto'] | None = ..., safe_chunks: bool = ..., storage_options: dict[str, str] | None = ..., zarr_version: int | None = ..., zarr_format: int | None = ..., write_empty_chunks: bool | None = ..., chunkmanager_store_kwargs: dict[str, Any] | None = ...) -> Any
+ xarray/tests/test_backends.py:3007: error: Argument 1 to "isel" of "Dataset" has incompatible type "object"; expected "Mapping[Any, Any] | None"  [arg-type]

jax (https://github.com/google/jax)
+ jax/_src/numpy/lax_numpy.py:1786: error: Argument 2 to "slice" has incompatible type "int"; expected "None"  [arg-type]
+ jax/experimental/sparse/bcoo.py:1990: error: Argument 2 to "slice" has incompatible type "int"; expected "None"  [arg-type]
+ jax/experimental/sparse/bcoo.py:1991: error: Argument 2 to "slice" has incompatible type "int"; expected "None"  [arg-type]
+ jax/experimental/sparse/bcoo.py:1995: error: Argument 2 to "slice" has incompatible type "int"; expected "None"  [arg-type]

operator (https://github.com/canonical/operator)
- ops/framework.py:1304: note:          def __getitem__(self, slice, /) -> MutableSequence[Any]
+ ops/framework.py:1304: note:          def __getitem__(self, slice[Any, Any, Any], /) -> MutableSequence[Any]
- ops/framework.py:1304: note:          def __getitem__(self, slice, /) -> Sequence[Any]
+ ops/framework.py:1304: note:          def __getitem__(self, slice[Any, Any, Any], /) -> Sequence[Any]
- ops/framework.py:1307: note:          def __setitem__(self, slice, Iterable[Any], /) -> None
+ ops/framework.py:1307: note:          def __setitem__(self, slice[Any, Any, Any], Iterable[Any], /) -> None
- ops/framework.py:1311: note:          def __delitem__(self, slice, /) -> None
+ ops/framework.py:1311: note:          def __delitem__(self, slice[Any, Any, Any], /) -> None

colour (https://github.com/colour-science/colour)
- colour/continuous/signal.py:843: error: No overload variant of "__call__" of "_ComparisonOpLE" matches argument type "slice"  [call-overload]
+ colour/continuous/signal.py:843: error: No overload variant of "__call__" of "_ComparisonOpLE" matches argument type "slice[Any, Any, Any]"  [call-overload]
- colour/continuous/signal.py:844: error: No overload variant of "__call__" of "_ComparisonOpGE" matches argument type "slice"  [call-overload]
+ colour/continuous/signal.py:844: error: No overload variant of "__call__" of "_ComparisonOpGE" matches argument type "slice[Any, Any, Any]"  [call-overload]

pandas-stubs (https://github.com/pandas-dev/pandas-stubs)
+ tests/test_frame.py:224: error: Expression is of type "Any", not "DataFrame"  [assert-type]
+ tests/test_frame.py:225: error: Expression is of type "Any", not "DataFrame"  [assert-type]

kornia (https://github.com/kornia/kornia)
+ kornia/contrib/models/sam/architecture/mask_decoder.py:92: error: Argument 2 to "slice" has incompatible type "int"; expected "None"  [arg-type]

dd-trace-py (https://github.com/DataDog/dd-trace-py)
- ddtrace/settings/config.py:888: note:     def __getitem__(self, SupportsIndex | slice, /) -> str
+ ddtrace/settings/config.py:888: note:     def __getitem__(self, SupportsIndex | slice[Any, Any, Any], /) -> str

manticore (https://github.com/trailofbits/manticore)
- tests/wasm/json2mc.py:103: note:     def __getitem__(self, slice, /) -> list[Any]
+ tests/wasm/json2mc.py:103: note:     def __getitem__(self, slice[Any, Any, Any], /) -> list[Any]
+ manticore/native/memory.py:229: error: Unsupported operand types for <= ("int" and "None")  [operator]
+ manticore/native/memory.py:229: note: Left operand is of type "Any | None"

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Any it is...

bb9252f

github-actions Bot commented Oct 24, 2024

Copy link

Copy Markdown

Contributor

Diff from mypy_primer, showing the effect of this PR on open source code:

werkzeug (https://github.com/pallets/werkzeug)
- tests/test_wrappers.py:522: note:     def __setitem__(self, slice, Iterable[tuple[str, str]], /) -> None
+ tests/test_wrappers.py:522: note:     def __setitem__(self, slice[Any, Any, Any], Iterable[tuple[str, str]], /) -> None
- tests/test_wrappers.py:563: note:     def __setitem__(self, slice, Iterable[tuple[str, str]], /) -> None
+ tests/test_wrappers.py:563: note:     def __setitem__(self, slice[Any, Any, Any], Iterable[tuple[str, str]], /) -> None

prefect (https://github.com/PrefectHQ/prefect)
- src/prefect/utilities/annotations.py:41: note:          def __getitem__(self, slice, /) -> tuple[Never, ...]
+ src/prefect/utilities/annotations.py:41: note:          def __getitem__(self, slice[Any, Any, Any], /) -> tuple[Never, ...]
- src/prefect/utilities/annotations.py:41: note:          def __getitem__(self, slice, /) -> Sequence[Never]
+ src/prefect/utilities/annotations.py:41: note:          def __getitem__(self, slice[Any, Any, Any], /) -> Sequence[Never]
- src/prefect/cli/cloud/__init__.py:326: note:     def __getitem__(self, SupportsIndex | slice, /) -> str
+ src/prefect/cli/cloud/__init__.py:326: note:     def __getitem__(self, SupportsIndex | slice[Any, Any, Any], /) -> str
- src/prefect/cli/deploy.py:1132: note:     def __setitem__(self, slice, Iterable[dict[Any, Any]], /) -> None
+ src/prefect/cli/deploy.py:1132: note:     def __setitem__(self, slice[Any, Any, Any], Iterable[dict[Any, Any]], /) -> None
- src/prefect/cli/deploy.py:1158: note:     def __setitem__(self, slice, Iterable[dict[Any, Any]], /) -> None
+ src/prefect/cli/deploy.py:1158: note:     def __setitem__(self, slice[Any, Any, Any], Iterable[dict[Any, Any]], /) -> None
- src/prefect/cli/deploy.py:1166: note:     def __setitem__(self, slice, Iterable[dict[Any, Any]], /) -> None
+ src/prefect/cli/deploy.py:1166: note:     def __setitem__(self, slice[Any, Any, Any], Iterable[dict[Any, Any]], /) -> None
- src/prefect/cli/deploy.py:1183: note:     def __getitem__(self, slice, /) -> list[dict[Any, Any]]
+ src/prefect/cli/deploy.py:1183: note:     def __getitem__(self, slice[Any, Any, Any], /) -> list[dict[Any, Any]]

streamlit (https://github.com/streamlit/streamlit)
- lib/tests/streamlit/elements/lib/column_config_utils_test.py:385:13: note:     def __getitem__(self, Union[SupportsIndex, slice], /) -> str
+ lib/tests/streamlit/elements/lib/column_config_utils_test.py:385:13: note:     def __getitem__(self, Union[SupportsIndex, slice[Any, Any, Any]], /) -> str
- lib/tests/streamlit/runtime/state/query_params_test.py:264:37: note:         def __getitem__(self, slice, /) -> Tuple[Any, ...]
+ lib/tests/streamlit/runtime/state/query_params_test.py:264:37: note:         def __getitem__(self, slice[Any, Any, Any], /) -> Tuple[Any, ...]

speedrun.com_global_scoreboard_webapp (https://github.com/Avasam/speedrun.com_global_scoreboard_webapp)
- backend/api/tournament_scheduler_api.py:327: note:     def __getitem__(self, slice, /) -> list[Any]
+ backend/api/tournament_scheduler_api.py:327: note:     def __getitem__(self, slice[Any, Any, Any], /) -> list[Any]
- backend/api/tournament_scheduler_api.py:331: note:     def __getitem__(self, slice, /) -> list[Any]
+ backend/api/tournament_scheduler_api.py:331: note:     def __getitem__(self, slice[Any, Any, Any], /) -> list[Any]
- backend/api/tournament_scheduler_api.py:335: note:     def __getitem__(self, slice, /) -> list[Any]
+ backend/api/tournament_scheduler_api.py:335: note:     def __getitem__(self, slice[Any, Any, Any], /) -> list[Any]

ibis (https://github.com/ibis-project/ibis)
- ibis/selectors.py:678: error: Incompatible types in assignment (expression has type "Slice", variable has type "str | int | slice | Iterable[int | str]")  [assignment]
+ ibis/selectors.py:678: error: Incompatible types in assignment (expression has type "Slice", variable has type "str | int | slice[Any, Any, Any] | Iterable[int | str]")  [assignment]
- ibis/selectors.py:679: error: Argument 1 to "ColumnIndex" has incompatible type "int | slice | Iterable[int | str]"; expected "str | int | Slice | tuple[int | str, ...]"  [arg-type]
+ ibis/selectors.py:679: error: Argument 1 to "ColumnIndex" has incompatible type "int | slice[Any, Any, Any] | Iterable[int | str]"; expected "str | int | Slice | tuple[int | str, ...]"  [arg-type]

pandas (https://github.com/pandas-dev/pandas)
+ pandas/core/array_algos/transforms.py:41: error: Argument 2 to "slice" has incompatible type "int"; expected "None"  [arg-type]
+ pandas/core/algorithms.py:1387: error: Argument 2 to "slice" has incompatible type "int"; expected "None"  [arg-type]
+ pandas/core/algorithms.py:1387: error: Argument 1 to "slice" has incompatible type "int"; expected "None"  [arg-type]
+ pandas/core/algorithms.py:1387: error: Argument 2 to "slice" has incompatible type "None"; expected "int"  [arg-type]
+ pandas/core/algorithms.py:1398: error: Argument 1 to "slice" has incompatible type "None"; expected "int"  [arg-type]
+ pandas/core/algorithms.py:1398: error: Argument 2 to "slice" has incompatible type "int"; expected "None"  [arg-type]
+ pandas/core/algorithms.py:1402: error: Argument 2 to "slice" has incompatible type "int"; expected "None"  [arg-type]
+ pandas/core/algorithms.py:1402: error: Argument 1 to "slice" has incompatible type "int"; expected "None"  [arg-type]
+ pandas/core/algorithms.py:1402: error: Argument 2 to "slice" has incompatible type "None"; expected "int"  [arg-type]

discord.py (https://github.com/Rapptz/discord.py)
- discord/http.py:233: note:     def __setitem__(self, slice, Iterable[Embed], /) -> None
+ discord/http.py:233: note:     def __setitem__(self, slice[Any, Any, Any], Iterable[Embed], /) -> None

freqtrade (https://github.com/freqtrade/freqtrade)
+ freqtrade/exchange/exchange.py:2901: error: Argument 1 to "slice" has incompatible type "None"; expected "int"  [arg-type]

xarray (https://github.com/pydata/xarray)
+ xarray/core/dataset.py: note: In member "tail" of class "Dataset":
+ xarray/core/dataset.py:3412: error: Argument 1 to "slice" has incompatible type "int"; expected "None"  [arg-type]
+ xarray/core/dataset.py: note: At top level:
+ xarray/core/dataset.py: note: In member "diff" of class "Dataset":
+ xarray/core/dataset.py:7957: error: Incompatible types in assignment (expression has type "dict[Hashable, slice[None, int, Any]]", variable has type "dict[Hashable, slice[int, None, Any]]")  [assignment]
+ xarray/core/dataset.py: note: At top level:

jax (https://github.com/google/jax)
+ jax/_src/numpy/lax_numpy.py:1786: error: Argument 2 to "slice" has incompatible type "int"; expected "None"  [arg-type]
+ jax/experimental/sparse/bcoo.py:1990: error: Argument 2 to "slice" has incompatible type "int"; expected "None"  [arg-type]
+ jax/experimental/sparse/bcoo.py:1991: error: Argument 2 to "slice" has incompatible type "int"; expected "None"  [arg-type]
+ jax/experimental/sparse/bcoo.py:1995: error: Argument 2 to "slice" has incompatible type "int"; expected "None"  [arg-type]

operator (https://github.com/canonical/operator)
- ops/framework.py:1304: note:          def __getitem__(self, slice, /) -> MutableSequence[Any]
+ ops/framework.py:1304: note:          def __getitem__(self, slice[Any, Any, Any], /) -> MutableSequence[Any]
- ops/framework.py:1304: note:          def __getitem__(self, slice, /) -> Sequence[Any]
+ ops/framework.py:1304: note:          def __getitem__(self, slice[Any, Any, Any], /) -> Sequence[Any]
- ops/framework.py:1307: note:          def __setitem__(self, slice, Iterable[Any], /) -> None
+ ops/framework.py:1307: note:          def __setitem__(self, slice[Any, Any, Any], Iterable[Any], /) -> None
- ops/framework.py:1311: note:          def __delitem__(self, slice, /) -> None
+ ops/framework.py:1311: note:          def __delitem__(self, slice[Any, Any, Any], /) -> None

colour (https://github.com/colour-science/colour)
- colour/continuous/signal.py:843: error: No overload variant of "__call__" of "_ComparisonOpLE" matches argument type "slice"  [call-overload]
+ colour/continuous/signal.py:843: error: No overload variant of "__call__" of "_ComparisonOpLE" matches argument type "slice[Any, Any, Any]"  [call-overload]
- colour/continuous/signal.py:844: error: No overload variant of "__call__" of "_ComparisonOpGE" matches argument type "slice"  [call-overload]
+ colour/continuous/signal.py:844: error: No overload variant of "__call__" of "_ComparisonOpGE" matches argument type "slice[Any, Any, Any]"  [call-overload]

pandas-stubs (https://github.com/pandas-dev/pandas-stubs)
+ tests/test_frame.py:224: error: Expression is of type "Any", not "DataFrame"  [assert-type]
+ tests/test_frame.py:225: error: Expression is of type "Any", not "DataFrame"  [assert-type]

kornia (https://github.com/kornia/kornia)
+ kornia/contrib/models/sam/architecture/mask_decoder.py:92: error: Argument 2 to "slice" has incompatible type "int"; expected "None"  [arg-type]

dd-trace-py (https://github.com/DataDog/dd-trace-py)
- ddtrace/settings/config.py:888: note:     def __getitem__(self, SupportsIndex | slice, /) -> str
+ ddtrace/settings/config.py:888: note:     def __getitem__(self, SupportsIndex | slice[Any, Any, Any], /) -> str

manticore (https://github.com/trailofbits/manticore)
- tests/wasm/json2mc.py:103: note:     def __getitem__(self, slice, /) -> list[Any]
+ tests/wasm/json2mc.py:103: note:     def __getitem__(self, slice[Any, Any, Any], /) -> list[Any]

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

AlexWaygood commented Oct 24, 2024

Copy link

Copy Markdown

Member

I fixed the failing test using @hamdanal's excellent suggestion and merged in main. Now it's just a matter of figuring out whether the new primer hits are acceptable or not. @srittau analysed a bunch of these in #11637 (comment), but there seem to be some new ones now. freqtrade and xarray aren't too concerning; these are places where users will have to add explicit annotations, but it's not so awful. These are a bit concerning to me, however:

pandas-stubs (https://github.com/pandas-dev/pandas-stubs)
+ tests/test_frame.py:224: error: Expression is of type "Any", not "DataFrame"  [assert-type]
+ tests/test_frame.py:225: error: Expression is of type "Any", not "DataFrame"  [assert-type]

The failing assert_type calls are here. I'm not sure I understand why mypy is now inferring Any for df[1:], as this should be covered by the second overload for DataFrame.__getitem__ here, which accepts a union including slice and returns DataFrame.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          There's no problem in this universe that cannot be fixed by adding mo…

b98c8fa

…re overloads

JukkaL commented Oct 24, 2024

Copy link

Copy Markdown

Contributor

If you can narrow down some false positives to a mypy bug, it would help if you can file a mypy issue and include a link to this PR.

AlexWaygood reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

github-actions Bot commented Oct 24, 2024

Copy link

Copy Markdown

Contributor

Diff from mypy_primer, showing the effect of this PR on open source code:

prefect (https://github.com/PrefectHQ/prefect)
- src/prefect/utilities/annotations.py:41: note:          def __getitem__(self, slice, /) -> tuple[Never, ...]
+ src/prefect/utilities/annotations.py:41: note:          def __getitem__(self, slice[int | Any, int | Any, int | Any], /) -> tuple[Never, ...]
- src/prefect/utilities/annotations.py:41: note:          def __getitem__(self, slice, /) -> Sequence[Never]
+ src/prefect/utilities/annotations.py:41: note:          def __getitem__(self, slice[int | Any, int | Any, int | Any], /) -> Sequence[Never]
- src/prefect/cli/cloud/__init__.py:326: note:     def __getitem__(self, SupportsIndex | slice, /) -> str
+ src/prefect/cli/cloud/__init__.py:326: note:     def __getitem__(self, SupportsIndex | slice[int | Any, int | Any, int | Any], /) -> str
- src/prefect/cli/deploy.py:1132: note:     def __setitem__(self, slice, Iterable[dict[Any, Any]], /) -> None
+ src/prefect/cli/deploy.py:1132: note:     def __setitem__(self, slice[int | Any, int | Any, int | Any], Iterable[dict[Any, Any]], /) -> None
- src/prefect/cli/deploy.py:1158: note:     def __setitem__(self, slice, Iterable[dict[Any, Any]], /) -> None
+ src/prefect/cli/deploy.py:1158: note:     def __setitem__(self, slice[int | Any, int | Any, int | Any], Iterable[dict[Any, Any]], /) -> None
- src/prefect/cli/deploy.py:1166: note:     def __setitem__(self, slice, Iterable[dict[Any, Any]], /) -> None
+ src/prefect/cli/deploy.py:1166: note:     def __setitem__(self, slice[int | Any, int | Any, int | Any], Iterable[dict[Any, Any]], /) -> None
- src/prefect/cli/deploy.py:1183: note:     def __getitem__(self, slice, /) -> list[dict[Any, Any]]
+ src/prefect/cli/deploy.py:1183: note:     def __getitem__(self, slice[int | Any, int | Any, int | Any], /) -> list[dict[Any, Any]]

werkzeug (https://github.com/pallets/werkzeug)
- tests/test_wrappers.py:522: note:     def __setitem__(self, slice, Iterable[tuple[str, str]], /) -> None
+ tests/test_wrappers.py:522: note:     def __setitem__(self, slice[int | Any, int | Any, int | Any], Iterable[tuple[str, str]], /) -> None
- tests/test_wrappers.py:563: note:     def __setitem__(self, slice, Iterable[tuple[str, str]], /) -> None
+ tests/test_wrappers.py:563: note:     def __setitem__(self, slice[int | Any, int | Any, int | Any], Iterable[tuple[str, str]], /) -> None

ibis (https://github.com/ibis-project/ibis)
+ ibis/util.py:591: error: Unsupported operand types for + ("IntegerScalar" and "int")  [operator]
+ ibis/util.py:591: note: Right operand is of type "int | Any"
+ ibis/util.py:595: error: Unsupported operand types for + ("IntegerScalar" and "int")  [operator]
+ ibis/util.py:595: note: Right operand is of type "int | Any"
+ ibis/util.py:606: error: Unsupported operand types for - ("int" and "IntegerScalar")  [operator]
+ ibis/util.py:606: note: Left operand is of type "int | Any"
- ibis/util.py:607: error: Incompatible return value type (got "tuple[int | None, Any | int]", expected "tuple[int | IntegerScalar, int | IntegerScalar]")  [return-value]
+ ibis/util.py:607: error: Incompatible return value type (got "tuple[int | None, int | Any]", expected "tuple[int | IntegerScalar, int | IntegerScalar]")  [return-value]
- ibis/selectors.py:678: error: Incompatible types in assignment (expression has type "Slice", variable has type "str | int | slice | Iterable[int | str]")  [assignment]
+ ibis/selectors.py:678: error: Incompatible types in assignment (expression has type "Slice", variable has type "str | int | slice[int | Any, int | Any, int | Any] | Iterable[int | str]")  [assignment]
- ibis/selectors.py:679: error: Argument 1 to "ColumnIndex" has incompatible type "int | slice | Iterable[int | str]"; expected "str | int | Slice | tuple[int | str, ...]"  [arg-type]
+ ibis/selectors.py:679: error: Argument 1 to "ColumnIndex" has incompatible type "int | slice[int | Any, int | Any, int | Any] | Iterable[int | str]"; expected "str | int | Slice | tuple[int | str, ...]"  [arg-type]
+ ibis/expr/types/strings.py:110: error: Argument 2 to "StringSlice" has incompatible type "int | Any"; expected "Value[Integer, Any] | None"  [arg-type]
+ ibis/expr/types/strings.py:110: error: Argument 3 to "StringSlice" has incompatible type "int | Any"; expected "Value[Integer, Any] | None"  [arg-type]
- ibis/expr/types/arrays.py:147: error: Argument 2 to "ArraySlice" has incompatible type "Any | int"; expected "Value[Integer, Any]"  [arg-type]
+ ibis/expr/types/arrays.py:147: error: Argument 2 to "ArraySlice" has incompatible type "int | Any"; expected "Value[Integer, Any]"  [arg-type]
+ ibis/expr/types/arrays.py:147: error: Argument 3 to "ArraySlice" has incompatible type "int | Any"; expected "Value[Integer, Any] | None"  [arg-type]

speedrun.com_global_scoreboard_webapp (https://github.com/Avasam/speedrun.com_global_scoreboard_webapp)
- backend/api/tournament_scheduler_api.py:327: note:     def __getitem__(self, slice, /) -> list[Any]
+ backend/api/tournament_scheduler_api.py:327: note:     def __getitem__(self, slice[int | Any, int | Any, int | Any], /) -> list[Any]
- backend/api/tournament_scheduler_api.py:331: note:     def __getitem__(self, slice, /) -> list[Any]
+ backend/api/tournament_scheduler_api.py:331: note:     def __getitem__(self, slice[int | Any, int | Any, int | Any], /) -> list[Any]
- backend/api/tournament_scheduler_api.py:335: note:     def __getitem__(self, slice, /) -> list[Any]
+ backend/api/tournament_scheduler_api.py:335: note:     def __getitem__(self, slice[int | Any, int | Any, int | Any], /) -> list[Any]

streamlit (https://github.com/streamlit/streamlit)
- lib/tests/streamlit/elements/lib/column_config_utils_test.py:385:13: note:     def __getitem__(self, Union[SupportsIndex, slice], /) -> str
+ lib/tests/streamlit/elements/lib/column_config_utils_test.py:385:13: note:     def __getitem__(self, Union[SupportsIndex, slice[Union[int, Any], Union[int, Any], Union[int, Any]]], /) -> str
- lib/tests/streamlit/runtime/state/query_params_test.py:264:37: note:         def __getitem__(self, slice, /) -> Tuple[Any, ...]
+ lib/tests/streamlit/runtime/state/query_params_test.py:264:37: note:         def __getitem__(self, slice[Union[int, Any], Union[int, Any], Union[int, Any]], /) -> Tuple[Any, ...]

discord.py (https://github.com/Rapptz/discord.py)
- discord/http.py:233: note:     def __setitem__(self, slice, Iterable[Embed], /) -> None
+ discord/http.py:233: note:     def __setitem__(self, slice[int | Any, int | Any, int | Any], Iterable[Embed], /) -> None

operator (https://github.com/canonical/operator)
- ops/framework.py:1304: note:          def __getitem__(self, slice, /) -> MutableSequence[Any]
+ ops/framework.py:1304: note:          def __getitem__(self, slice[int | Any, int | Any, int | Any], /) -> MutableSequence[Any]
- ops/framework.py:1304: note:          def __getitem__(self, slice, /) -> Sequence[Any]
+ ops/framework.py:1304: note:          def __getitem__(self, slice[int | Any, int | Any, int | Any], /) -> Sequence[Any]
- ops/framework.py:1307: note:          def __setitem__(self, slice, Iterable[Any], /) -> None
+ ops/framework.py:1307: note:          def __setitem__(self, slice[int | Any, int | Any, int | Any], Iterable[Any], /) -> None
- ops/framework.py:1311: note:          def __delitem__(self, slice, /) -> None
+ ops/framework.py:1311: note:          def __delitem__(self, slice[int | Any, int | Any, int | Any], /) -> None

colour (https://github.com/colour-science/colour)
- colour/continuous/signal.py:843: error: No overload variant of "__call__" of "_ComparisonOpLE" matches argument type "slice"  [call-overload]
+ colour/continuous/signal.py:843: error: No overload variant of "__call__" of "_ComparisonOpLE" matches argument type "slice[int | Any, int | Any, int | Any]"  [call-overload]
- colour/continuous/signal.py:844: error: No overload variant of "__call__" of "_ComparisonOpGE" matches argument type "slice"  [call-overload]
+ colour/continuous/signal.py:844: error: No overload variant of "__call__" of "_ComparisonOpGE" matches argument type "slice[int | Any, int | Any, int | Any]"  [call-overload]

pandas-stubs (https://github.com/pandas-dev/pandas-stubs)
+ tests/test_frame.py:224: error: Expression is of type "Any", not "DataFrame"  [assert-type]
+ tests/test_frame.py:225: error: Expression is of type "Any", not "DataFrame"  [assert-type]
+ tests/test_frame.py:2170: error: Expression is of type "tuple[Index[int], slice[Any, Any, Any]]", not "tuple[Index[int], slice[int | Any, int | Any, int | Any]]"  [assert-type]

manticore (https://github.com/trailofbits/manticore)
- tests/wasm/json2mc.py:103: note:     def __getitem__(self, slice, /) -> list[Any]
+ tests/wasm/json2mc.py:103: note:     def __getitem__(self, slice[int | Any, int | Any, int | Any], /) -> list[Any]

dd-trace-py (https://github.com/DataDog/dd-trace-py)
- ddtrace/settings/config.py:888: note:     def __getitem__(self, SupportsIndex | slice, /) -> str
+ ddtrace/settings/config.py:888: note:     def __getitem__(self, SupportsIndex | slice[int | Any, int | Any, int | Any], /) -> str

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          more Any again

c0fe293

github-actions Bot commented Oct 24, 2024

Copy link

Copy Markdown

Contributor

Diff from mypy_primer, showing the effect of this PR on open source code:

prefect (https://github.com/PrefectHQ/prefect)
- src/prefect/utilities/annotations.py:41: note:          def __getitem__(self, slice, /) -> tuple[Never, ...]
+ src/prefect/utilities/annotations.py:41: note:          def __getitem__(self, slice[Any, Any, Any], /) -> tuple[Never, ...]
- src/prefect/utilities/annotations.py:41: note:          def __getitem__(self, slice, /) -> Sequence[Never]
+ src/prefect/utilities/annotations.py:41: note:          def __getitem__(self, slice[Any, Any, Any], /) -> Sequence[Never]
- src/prefect/cli/cloud/__init__.py:326: note:     def __getitem__(self, SupportsIndex | slice, /) -> str
+ src/prefect/cli/cloud/__init__.py:326: note:     def __getitem__(self, SupportsIndex | slice[Any, Any, Any], /) -> str
- src/prefect/cli/deploy.py:1132: note:     def __setitem__(self, slice, Iterable[dict[Any, Any]], /) -> None
+ src/prefect/cli/deploy.py:1132: note:     def __setitem__(self, slice[Any, Any, Any], Iterable[dict[Any, Any]], /) -> None
- src/prefect/cli/deploy.py:1158: note:     def __setitem__(self, slice, Iterable[dict[Any, Any]], /) -> None
+ src/prefect/cli/deploy.py:1158: note:     def __setitem__(self, slice[Any, Any, Any], Iterable[dict[Any, Any]], /) -> None
- src/prefect/cli/deploy.py:1166: note:     def __setitem__(self, slice, Iterable[dict[Any, Any]], /) -> None
+ src/prefect/cli/deploy.py:1166: note:     def __setitem__(self, slice[Any, Any, Any], Iterable[dict[Any, Any]], /) -> None
- src/prefect/cli/deploy.py:1183: note:     def __getitem__(self, slice, /) -> list[dict[Any, Any]]
+ src/prefect/cli/deploy.py:1183: note:     def __getitem__(self, slice[Any, Any, Any], /) -> list[dict[Any, Any]]

ibis (https://github.com/ibis-project/ibis)
- ibis/selectors.py:678: error: Incompatible types in assignment (expression has type "Slice", variable has type "str | int | slice | Iterable[int | str]")  [assignment]
+ ibis/selectors.py:678: error: Incompatible types in assignment (expression has type "Slice", variable has type "str | int | slice[Any, Any, Any] | Iterable[int | str]")  [assignment]
- ibis/selectors.py:679: error: Argument 1 to "ColumnIndex" has incompatible type "int | slice | Iterable[int | str]"; expected "str | int | Slice | tuple[int | str, ...]"  [arg-type]
+ ibis/selectors.py:679: error: Argument 1 to "ColumnIndex" has incompatible type "int | slice[Any, Any, Any] | Iterable[int | str]"; expected "str | int | Slice | tuple[int | str, ...]"  [arg-type]

werkzeug (https://github.com/pallets/werkzeug)
- tests/test_wrappers.py:522: note:     def __setitem__(self, slice, Iterable[tuple[str, str]], /) -> None
+ tests/test_wrappers.py:522: note:     def __setitem__(self, slice[Any, Any, Any], Iterable[tuple[str, str]], /) -> None
- tests/test_wrappers.py:563: note:     def __setitem__(self, slice, Iterable[tuple[str, str]], /) -> None
+ tests/test_wrappers.py:563: note:     def __setitem__(self, slice[Any, Any, Any], Iterable[tuple[str, str]], /) -> None

streamlit (https://github.com/streamlit/streamlit)
- lib/tests/streamlit/elements/lib/column_config_utils_test.py:385:13: note:     def __getitem__(self, Union[SupportsIndex, slice], /) -> str
+ lib/tests/streamlit/elements/lib/column_config_utils_test.py:385:13: note:     def __getitem__(self, Union[SupportsIndex, slice[Any, Any, Any]], /) -> str
- lib/tests/streamlit/runtime/state/query_params_test.py:264:37: note:         def __getitem__(self, slice, /) -> Tuple[Any, ...]
+ lib/tests/streamlit/runtime/state/query_params_test.py:264:37: note:         def __getitem__(self, slice[Any, Any, Any], /) -> Tuple[Any, ...]

speedrun.com_global_scoreboard_webapp (https://github.com/Avasam/speedrun.com_global_scoreboard_webapp)
- backend/api/tournament_scheduler_api.py:327: note:     def __getitem__(self, slice, /) -> list[Any]
+ backend/api/tournament_scheduler_api.py:327: note:     def __getitem__(self, slice[Any, Any, Any], /) -> list[Any]
- backend/api/tournament_scheduler_api.py:331: note:     def __getitem__(self, slice, /) -> list[Any]
+ backend/api/tournament_scheduler_api.py:331: note:     def __getitem__(self, slice[Any, Any, Any], /) -> list[Any]
- backend/api/tournament_scheduler_api.py:335: note:     def __getitem__(self, slice, /) -> list[Any]
+ backend/api/tournament_scheduler_api.py:335: note:     def __getitem__(self, slice[Any, Any, Any], /) -> list[Any]

discord.py (https://github.com/Rapptz/discord.py)
- discord/http.py:233: note:     def __setitem__(self, slice, Iterable[Embed], /) -> None
+ discord/http.py:233: note:     def __setitem__(self, slice[Any, Any, Any], Iterable[Embed], /) -> None

operator (https://github.com/canonical/operator)
- ops/framework.py:1304: note:          def __getitem__(self, slice, /) -> MutableSequence[Any]
+ ops/framework.py:1304: note:          def __getitem__(self, slice[Any, Any, Any], /) -> MutableSequence[Any]
- ops/framework.py:1304: note:          def __getitem__(self, slice, /) -> Sequence[Any]
+ ops/framework.py:1304: note:          def __getitem__(self, slice[Any, Any, Any], /) -> Sequence[Any]
- ops/framework.py:1307: note:          def __setitem__(self, slice, Iterable[Any], /) -> None
+ ops/framework.py:1307: note:          def __setitem__(self, slice[Any, Any, Any], Iterable[Any], /) -> None
- ops/framework.py:1311: note:          def __delitem__(self, slice, /) -> None
+ ops/framework.py:1311: note:          def __delitem__(self, slice[Any, Any, Any], /) -> None

colour (https://github.com/colour-science/colour)
- colour/continuous/signal.py:843: error: No overload variant of "__call__" of "_ComparisonOpLE" matches argument type "slice"  [call-overload]
+ colour/continuous/signal.py:843: error: No overload variant of "__call__" of "_ComparisonOpLE" matches argument type "slice[Any, Any, Any]"  [call-overload]
- colour/continuous/signal.py:844: error: No overload variant of "__call__" of "_ComparisonOpGE" matches argument type "slice"  [call-overload]
+ colour/continuous/signal.py:844: error: No overload variant of "__call__" of "_ComparisonOpGE" matches argument type "slice[Any, Any, Any]"  [call-overload]

pandas-stubs (https://github.com/pandas-dev/pandas-stubs)
+ tests/test_frame.py:224: error: Expression is of type "Any", not "DataFrame"  [assert-type]
+ tests/test_frame.py:225: error: Expression is of type "Any", not "DataFrame"  [assert-type]

manticore (https://github.com/trailofbits/manticore)
- tests/wasm/json2mc.py:103: note:     def __getitem__(self, slice, /) -> list[Any]
+ tests/wasm/json2mc.py:103: note:     def __getitem__(self, slice[Any, Any, Any], /) -> list[Any]

dd-trace-py (https://github.com/DataDog/dd-trace-py)
- ddtrace/settings/config.py:888: note:     def __getitem__(self, SupportsIndex | slice, /) -> str
+ ddtrace/settings/config.py:888: note:     def __getitem__(self, SupportsIndex | slice[Any, Any, Any], /) -> str

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

AlexWaygood commented Oct 24, 2024

Copy link

Copy Markdown

Member

The pandas-stubs errors I discussed in #11637 (comment) are now the only new false positives this PR introduces. I would say the cost-benefit is now in this PR's favour. (For one thing, we'd possibly find it quite useful for red-knot.)

@JukkaL, I'll see if I can narrow down the strange pandas-stubs primer hits to a mypy bug.

JukkaL reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

AlexWaygood marked this pull request as ready for review

October 24, 2024 13:17

AlexWaygood requested a review from srittau

October 24, 2024 13:17

srittau approved these changes

Oct 24, 2024

View reviewed changes

srittau left a comment

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can always refine this later, this is a good start!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

AlexWaygood approved these changes

Oct 24, 2024

View reviewed changes

srittau merged commit 65405e9 into python:main

Oct 24, 2024

randolf-scholz reviewed

Oct 24, 2024

View reviewed changes

Comment thread

stdlib/builtins.pyi Resolved

Uh oh!

There was an error while loading. Please reload this page.

randolf-scholz mentioned this pull request

Oct 24, 2024

Make all params positional-only in slice.__new__ #12900

Merged

Sachaa-Thanasius deleted the generic-slice branch

October 25, 2024 10:50

AlexWaygood mentioned this pull request

Nov 12, 2024

Change in inference of overloads involving Hashable and slice now that slice is generic python/mypy#18149

Closed

AlexWaygood commented Nov 12, 2024

Copy link

Copy Markdown

Member

@JukkaL, I'll see if I can narrow down the strange pandas-stubs primer hits to a mypy bug.

@JukkaL I finally found some time to minimize this: python/mypy#18149

JukkaL reacted with heart emoji

All reactions

❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

brianschubert mentioned this pull request

Nov 18, 2024

Infer generic type arguments for slice expressions python/mypy#18160

Merged

hauntsaninja pushed a commit to python/mypy that referenced this pull request

Nov 19, 2024


          Infer generic type arguments for slice expressions (#18160)

6759dbd

Fixes  #18149

Slices were made generic in
python/typeshed#11637. Currently, all slice
expressions are inferred to have type `slice[Any, Any, Any]`. This PR
fills in the generic type arguments more appropriately using
start/stop/stride expression types.

Given
```python
class Foo:
    def __getitem__[T](self, item: T) -> T: return item

x = Foo()
reveal_type(x[1:])
```
Before:
```none
main.py:5: note: Revealed type is "builtins.slice[Any, Any, Any]"
```
After:
```none
main.py:5: note: Revealed type is "builtins.slice[builtins.int, None, None]"
```

Gobot1234 mentioned this pull request

Dec 29, 2024

Make slice generic python/cpython#128335

Closed

gandhis1 mentioned this pull request

Jan 3, 2025

Mypy complains about slicing a DateTimeIndex pandas-dev/pandas-stubs#397

Closed

Skylion007 mentioned this pull request

Feb 1, 2025

Make fx.node.map_arg() and .map_aggregate() generic pytorch/pytorch#146248

Closed

obskyr mentioned this pull request

Mar 20, 2025

Make the built-in slice type generic in terms of its start, stop, and step #10174

Closed

Reviewers

srittau

srittau approved these changes

AlexWaygood

AlexWaygood approved these changes

+1 more reviewer

randolf-scholz

randolf-scholz left review comments

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

builtins.slice should be generic

Uh oh!

There was an error while loading. Please reload this page.

8 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

Sachaa-Thanasius commented Mar 20, 2024 • edited by srittau Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

JelleZijlstra commented Mar 20, 2024

Uh oh!

cdce8p commented Mar 20, 2024

Uh oh!

Sachaa-Thanasius commented Mar 20, 2024

Uh oh!

JelleZijlstra commented Mar 20, 2024

Uh oh!

Sachaa-Thanasius commented Mar 21, 2024

Uh oh!

Sachaa-Thanasius commented Mar 21, 2024

Uh oh!

This comment has been minimized.

cdce8p commented Mar 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Sachaa-Thanasius commented Apr 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

srittau commented Apr 24, 2024

Uh oh!

Sachaa-Thanasius commented Apr 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hamdanal commented Apr 27, 2024

Uh oh!

Sachaa-Thanasius commented May 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 24, 2024

Uh oh!

github-actions Bot commented Oct 24, 2024

Uh oh!

github-actions Bot commented Oct 24, 2024

Uh oh!

AlexWaygood commented Oct 24, 2024

Uh oh!

JukkaL commented Oct 24, 2024

Uh oh!

github-actions Bot commented Oct 24, 2024

Uh oh!

github-actions Bot commented Oct 24, 2024

Uh oh!

AlexWaygood commented Oct 24, 2024

Uh oh!

srittau left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

AlexWaygood commented Nov 12, 2024

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Sachaa-Thanasius commented Mar 20, 2024 •

edited by srittau

Loading

Uh oh!

There was an error while loading. Please reload this page.

cdce8p commented Mar 21, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Sachaa-Thanasius commented Apr 24, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Sachaa-Thanasius commented Apr 24, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Sachaa-Thanasius commented May 3, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.