GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Improve type annotations in Flask-Cors stubs by ashm-dev · Pull Request #12596 · python/typeshed

Conversation

@ashm-dev

@ashm-dev ashm-dev commented Aug 26, 2024

Copy link
Copy Markdown
Contributor

@srittau As promised, I have added the constants.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
ashm-dev added 2 commits August 26, 2024 22:23
@ashm-dev
Improve type annotations in Flask-Cors stubs
fe7a3a5
@ashm-dev
Improve type annotations in Flask-Cors stubs
0ab362c
@github-actions

This comment has been minimized.

Sign in to view
srittau
srittau reviewed Aug 26, 2024
View reviewed changes
Comment thread stubs/Flask-Cors/flask_cors/core.pyi Outdated
RegexObject: type[Pattern[str]]
DEFAULT_OPTIONS: _Options

ACL_ORIGIN: Final[str] = "Access-Control-Allow-Origin"

@srittau srittau Aug 26, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: If you have a default, you don't need to specify the type:

ACL_ORIGIN: Final = "Access-Control-Allow-Origin"

(Here and below.)

We should really have a flake8 warning for that. I filed PyCQA/flake8-pyi#499.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@ashm-dev ashm-dev Aug 26, 2024

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, everything will be fine now!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ashm-dev
Improve type annotations in Flask-Cors stubs
fc1526a
@github-actions

github-actions Bot commented Aug 26, 2024

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ashm-dev
ashm-dev requested a review from srittau August 27, 2024 08:01
srittau
srittau approved these changes Aug 27, 2024
View reviewed changes

@srittau srittau left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ashm-dev reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@srittau
srittau merged commit f58dac1 into python:main Aug 27, 2024
@ashm-dev
ashm-dev deleted the flask-cors branch August 27, 2024 08:48
max-muoto pushed a commit to max-muoto/typeshed that referenced this pull request Sep 8, 2024
@ashm-dev @max-muoto
[Flask-Cors] Mark constants using Final (python#12596)
d0b6be2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srittau srittau srittau approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@ashm-dev @srittau
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.