GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Remove corus stubs by ashm-dev · Pull Request #14153 · python/typeshed

Conversation

@ashm-dev

@ashm-dev ashm-dev commented May 26, 2025

Copy link
Copy Markdown
Contributor

Closes #14143

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ashm-dev
Remove corus stubs
c3d465c
@github-actions

This comment has been minimized.

Sign in to view
@ashm-dev
Merge branch 'main' into remove/corus
73b8fa0
@github-actions

github-actions Bot commented May 26, 2025

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
srittau
srittau approved these changes May 26, 2025
View reviewed changes

@srittau srittau left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@srittau
srittau merged commit 7ee4d5b into python:main May 26, 2025
@AlexWaygood

AlexWaygood commented May 26, 2025

Copy link
Copy Markdown
Member

don't we usually make a PR setting the no_longer_updated field in the METADATA.toml file first, as per https://github.com/python/typeshed/blob/main/CONTRIBUTING.md#third-party-library-removal-policy?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@srittau

srittau commented May 26, 2025

Copy link
Copy Markdown
Collaborator

Whoops, you're right. I'm currently not on a PC so I can't revert this and redo it the right way, but any PR fixing my mistake is welcome!
AlexWaygood reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
AlexWaygood added a commit that referenced this pull request May 26, 2025
@AlexWaygood
Revert "Remove corus stubs (#14153)"
cefaa8d 
This reverts commit 7ee4d5b.
@AlexWaygood AlexWaygood mentioned this pull request May 26, 2025
Revert "Remove corus stubs" #14158
Merged
@ashm-dev
ashm-dev deleted the remove/corus branch May 26, 2025 19:04
@sobolevn sobolevn mentioned this pull request May 26, 2025
[corus] set no_longer_updated #14160
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srittau srittau srittau approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove corus

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@ashm-dev @AlexWaygood @srittau
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.