GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Let ctypes._CData.from_buffer[_copy] accept any buffer object by dgelessus · Pull Request #2610 · python/typeshed

Conversation

@dgelessus

@dgelessus dgelessus commented Nov 20, 2018

Copy link
Copy Markdown
Contributor

Fixes the issue discussed here: #1906 (comment)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@dgelessus
Let ctypes._CData.from_buffer[_copy] accept any buffer object
9a4bfe9 
Fixes the issue discussed here:
python#1906 (comment)
@dgelessus dgelessus mentioned this pull request Nov 20, 2018
Try to re-add stubs for ctypes #1906
Merged
eric-wieser
eric-wieser approved these changes Nov 20, 2018
View reviewed changes
@srittau

srittau commented Nov 20, 2018

Copy link
Copy Markdown
Collaborator

Relevant: python/typing#593.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
JelleZijlstra
JelleZijlstra approved these changes Nov 20, 2018
View reviewed changes
@JelleZijlstra

JelleZijlstra commented Nov 20, 2018

Copy link
Copy Markdown
Member

This seems OK for now; we may have to tweak it if/when we add buffer support to typing.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra
JelleZijlstra merged commit 45d4e88 into python:master Nov 20, 2018
@JelleZijlstra JelleZijlstra mentioned this pull request Nov 20, 2018
Buffer protocol types python/typing#593
Closed
yedpodtrzitko pushed a commit to yedpodtrzitko/typeshed that referenced this pull request Jan 23, 2019
@dgelessus Jiri Suchan
Let ctypes._CData.from_buffer[_copy] accept any buffer object (python…
69f0702 
…#2610)

Fixes the issue discussed here:
python#1906 (comment)
hauntsaninja pushed a commit to hauntsaninja/typeshed that referenced this pull request Jan 30, 2020
hauntsaninja
fcntl: type buffers better
c8808ac 
Follows the approach in python#2610
hauntsaninja pushed a commit to hauntsaninja/typeshed that referenced this pull request Feb 5, 2020
hauntsaninja
fcntl: type buffers better
4d89247 
Follows the approach in python#2610
JelleZijlstra pushed a commit that referenced this pull request Feb 22, 2020
@hauntsaninja
fcntl: various improvements (#3680)
1b7eadc 
* fcntl: mark positional-only args

* fcntl: use overload for fcntl.fcntl

The comment about depending on the type of arg seems incorrect
bf50135

I checked the docs and examples, CPython implementation and CPython tests, but
I might be missing something

* fcntl: use overload for fcntl.ioctl

Based off of docs and examples

* fcntl: type buffers better

Follows the approach in #2610
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes
+1 more reviewer
@eric-wieser eric-wieser eric-wieser approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@dgelessus @srittau @JelleZijlstra @eric-wieser
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.