GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — asyncore: improve bytes handling by sobolevn · Pull Request #9034 · python/typeshed

Conversation

@sobolevn

@sobolevn sobolevn commented Oct 29, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Source: https://github.com/python/cpython/blob/7ea10567afe38e7770e82b4642c0b01659acaad5/Lib/asyncore.py

asyncore.send calls socket.send: https://github.com/python/cpython/blob/7ea10567afe38e7770e82b4642c0b01659acaad5/Lib/asyncore.py#L363

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
sobolevn added 2 commits October 29, 2022 14:38
@sobolevn
asyncore: improve bytes handling
8ecea25
@sobolevn
Update asyncore.pyi
2fe622e
@AlexWaygood

AlexWaygood commented Oct 29, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

I don't really want to spend my time reviewing a PR like this for a module that's long-deprecated and about to be removed :(

Same goes for #9035
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

This comment has been minimized.

Sign in to view
@sobolevn
Update asyncore.pyi
55a306d
@github-actions

github-actions Bot commented Oct 29, 2022

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sobolevn

sobolevn commented Oct 29, 2022

Copy link
Copy Markdown
Member Author

Yeah, I can totally understand, sometimes I feel this too!
(I even have a backlog of things to review) 😆

But, since typeshed still supports >=3.7, people are and will still use these modules.
This is why I even bothered creating this PR.

Maybe someone else will review it! If you feel like it, closing these two PRs is always an option.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hauntsaninja hauntsaninja mentioned this pull request Oct 29, 2022
Track review of bytes types #9006
Open
@AlexWaygood

AlexWaygood commented Oct 30, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Yeah, to be clear — I've no objections to other maintainers reviewing and merging this if they want to :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra
JelleZijlstra merged commit b24a22c into python:master Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@sobolevn @AlexWaygood @JelleZijlstra
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.