GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — binhex: improve bytes handling by sobolevn · Pull Request #9035 · python/typeshed

Conversation

@sobolevn

@sobolevn sobolevn commented Oct 29, 2022

Copy link
Copy Markdown
Member

Source: https://github.com/python/cpython/blob/85f88f63d96b07208c98a725391af7cb710fe06b/Lib/binhex.py#L216-L234

Both write and write_rsrc calls io.open(..., 'wb').write(data)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
sobolevn and others added 2 commits October 29, 2022 14:45
@sobolevn
binhex: improve bytes handling
8c56619
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
8c1a06c
@AlexWaygood AlexWaygood mentioned this pull request Oct 29, 2022
asyncore: improve bytes handling #9034
Merged
@github-actions

This comment has been minimized.

Sign in to view
hauntsaninja
hauntsaninja requested changes Oct 29, 2022
View reviewed changes

@hauntsaninja hauntsaninja left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it calls len. I'd say we should add a _BufferWithLen: TypeAlias = ReadableBuffer to _typeshed (or at least add a comment). This would have been useful in at least one other place

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
sobolevn and others added 3 commits October 29, 2022 21:54
@sobolevn
Address review
c5b7a17
@sobolevn
Merge branch 'bytes-binhex' of https://github.com/sobolevn/typeshed i…
09cc014 
…nto bytes-binhex
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
9da2284
@github-actions

This comment has been minimized.

Sign in to view
@sobolevn
Update binhex.pyi
20eb466
@github-actions

This comment has been minimized.

Sign in to view
@sobolevn
Update __init__.pyi
67b4990
hauntsaninja
hauntsaninja approved these changes Oct 29, 2022
View reviewed changes

@hauntsaninja hauntsaninja left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hauntsaninja hauntsaninja mentioned this pull request Oct 29, 2022
Track review of bytes types #9006
Open
@github-actions

github-actions Bot commented Oct 29, 2022

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra
JelleZijlstra merged commit a96cb58 into python:master Oct 30, 2022
@AlexWaygood

AlexWaygood commented Oct 30, 2022

Copy link
Copy Markdown
Member

Looks like it calls len. I'd say we should add a _BufferWithLen: TypeAlias = ReadableBuffer to _typeshed (or at least add a comment). This would have been useful in at least one other place

I agree with adding this, but why the leading underscore, out of interest?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hauntsaninja

hauntsaninja commented Oct 30, 2022

Copy link
Copy Markdown
Collaborator

Oh, I don't remember exactly what rules we have for _typeshed, but I wanted to mark as "private / experimental / do not use"... The type doesn't really correspond to its name, it's currently incorrectly typed (e.g. since ReadableBuffer includes pickle.PickleBuffer), we don't know the fate of PEP 688, etc.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sobolevn

sobolevn commented Oct 30, 2022

Copy link
Copy Markdown
Member Author

but I wanted to mark as "private / experimental / do not use"...

+1
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood

AlexWaygood commented Oct 30, 2022

Copy link
Copy Markdown
Member

Cool, that makes sense!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@sobolevn @AlexWaygood @hauntsaninja @JelleZijlstra
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.