GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix various things with `Literal` by AlexWaygood · Pull Request #145 · python/typing_extensions

Conversation

@AlexWaygood

@AlexWaygood AlexWaygood commented Apr 17, 2023

Copy link
Copy Markdown
Member

Fixes #113. Closes #144.

Backports python/cpython#23294 and python/cpython#23383, both originally by Yurii Karabas.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
AlexWaygood added 2 commits April 16, 2023 20:13
@AlexWaygood
Add failing test cases
ba96d1b
@AlexWaygood
Backport the fixes; add docs
5fcad73
@AlexWaygood AlexWaygood mentioned this pull request Apr 17, 2023
Use typing_extensions.Literal for 3.8 due to unresolved bugs in CPython #144
Closed
JelleZijlstra
JelleZijlstra reviewed Apr 17, 2023
View reviewed changes
Comment thread CHANGELOG.md
A side effect of one of the changes is that equality comparisons of `Literal`
objects will now raise a `TypeError` if one of the `Literal` objects being
compared has a mutable parameter. (Using mutable parameters with `Literal` is
not supported by PEP 586 or by any major static type checkers.)

@JelleZijlstra JelleZijlstra Apr 17, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice dig against pyanalyze :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@AlexWaygood AlexWaygood Apr 17, 2023

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh entirely unintentional!! I can take this out if you like :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@JelleZijlstra JelleZijlstra Apr 17, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah, it's true.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
JelleZijlstra
JelleZijlstra approved these changes Apr 17, 2023
View reviewed changes
@JelleZijlstra

JelleZijlstra commented Apr 17, 2023

Copy link
Copy Markdown
Member

Seems like something's broken on 3.9.0.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
AlexWaygood
AlexWaygood commented Apr 17, 2023
View reviewed changes
Comment thread src/test_typing_extensions.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood
fix lint
536415d
@AlexWaygood

AlexWaygood commented Apr 17, 2023

Copy link
Copy Markdown
Member Author

Seems like something's broken on 3.9.0.

A result of python/cpython#19620. I'm looking at it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood
Fix 3.9.0?
ef7fd98
@AlexWaygood
AlexWaygood requested a review from JelleZijlstra April 17, 2023 17:42
JelleZijlstra
JelleZijlstra approved these changes Apr 17, 2023
View reviewed changes
@JelleZijlstra
JelleZijlstra merged commit 8bff0a3 into python:main Apr 17, 2023
@AlexWaygood
AlexWaygood deleted the literal-fixes branch April 17, 2023 18:04
@AlexWaygood AlexWaygood mentioned this pull request Aug 9, 2025
Add breakpoint comments to version_info checks #642
Merged
@AlexWaygood AlexWaygood mentioned this pull request Aug 12, 2026
Remove obsolete Literal deduplication assertion #785
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

(🐞) Literal doesn't flatten it's arguments

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@AlexWaygood @JelleZijlstra
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.