GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||
GeezerVison is showing github.com — Add breakpoint comments to version_info checks by donbarbos · Pull Request #642 · python/typing_extensions Conversation
Contributor
I believe that this change brings more clarity to code, and I just checked comment PRs according to 'Release Schedule' PEPs for 3.10, 3.11, 3.12, 3.13, 3.14 versions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
AlexWaygood
reviewed
Comment on lines
+173
to
+174
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I like the comments you're adding to link to the CPython PRs, but I'd leave the
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sorry, but I’m not quite sure what kind of breakages could occur in this case, especially for
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sure, sorry for being vague! In #145, for example, I made it so that
I don't think it's very likely that the specific changes you proposed here would cause that kind of breakage! But over the years of maintaining typing_extensions, I've come to realise that you really can't predict what kind of assumptions people are making about things like this -- I had no idea that change would break pydantic! So it's better not to make changes like this unless they're actually fixing something :-)
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
JelleZijlstra
approved these changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | ||||||
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |