GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Backport tests of `Union` + `Literal` from CPython by sobolevn · Pull Request #152 · python/typing_extensions

Conversation

@sobolevn

@sobolevn sobolevn commented Apr 24, 2023

Copy link
Copy Markdown
Member

This PR is the backport of two my CPython's PR:

  1. gh-103592: Add tests of Literal with Enum and Union of Literals cpython#103706 (merged)
  2. gh-103746: Test types.UnionType and Literal types together cpython#103747 (not merged yet)

Sorry, I often forget to do the backport when I write new tests.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
sobolevn added 3 commits April 24, 2023 11:45
@sobolevn
Backport tests of Union + Literal from CPython
203dfd8
@sobolevn
Fix CI
e751709
@sobolevn
Fix lint
4731c17
@sobolevn

sobolevn commented Apr 24, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Hm, I need to ignore | tests for older versions.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sobolevn
Fix CI
b7e377f
@JelleZijlstra

JelleZijlstra commented Apr 24, 2023

Copy link
Copy Markdown
Member

Thanks! Let's wait until python/cpython#103747 is merged in case there are changes.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sobolevn

sobolevn commented Apr 24, 2023

Copy link
Copy Markdown
Member Author

It is merged now :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra
JelleZijlstra merged commit 0b8de38 into python:main Apr 24, 2023
ShaneMurphy2 pushed a commit to ShaneMurphy2/typing_extensions that referenced this pull request May 17, 2023
@sobolevn @ShaneMurphy2
Backport tests of Union + Literal from CPython (python#152)
eed0987
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@sobolevn @JelleZijlstra
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.