GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Fix compact decimal plural selection after rounding by 0718lol · Pull Request #1430 · python-babel/babel

Conversation

0718lol commented Nov 4, 2026

Copy link

Copy Markdown

Fixes #1429.

Select compact decimal plural forms using the rounded displayed value rather than the unrounded scaled value. Normalize optional fractional zeros before plural selection, since they are not displayed. For example, Russian 1100 now renders as 1 тысяча instead of 1 тысячи, and Polish 1900 renders as 2 tysiące instead of 2 tysiąca.

Add 11 regression cases covering positive and negative values, retained fractions, trimmed zeros, and five locales. Update the existing Italian 1234 expectation from 1 mila to mille, matching the rounded-value plural rule and Node's Intl formatter. The separate exact-1 pattern selection is unchanged.

Validation: CLDR 48.2 imported using the repository script; Python 3.12.15 on macOS; full suite: 7856 passed, 8 skipped, 2 xfailed. Ruff and git diff --check pass. The new regression tests fail on the original implementation.

Developed and tested with Codex assistance.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Fix compact decimal plural selection after rounding

cdf6870

akx added bug area/numbers AI Assisted labels

Nov 4, 2026

akx requested changes

Nov 4, 2026

View reviewed changes

Comment thread

babel/numbers.py Outdated

		plural_form = locale.plural_form(plural_number)
		if plural_form not in compact_format:
		plural_form = "other"
		if scaled == 1 and "1" in compact_format:

akx Nov 4, 2026

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also use the rounded value here:

Suggested change

	if scaled == 1 and "1" in compact_format:
	if rounded == 1 and "1" in compact_format:

and then change the tests accordingly and add

    ('fr', 1234, 0, 'mille'),
    ('fr', -1234, 0, '-1 millier'),

to the tests (this ought to match what Node ICU does).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

akx self-assigned this

Nov 4, 2026

akx added this to the Babel 2.19 milestone

Nov 4, 2026

0718lol commented Nov 4, 2026 via email

Copy link

Copy Markdown

Author

可以的我觉得你的想法很有道理

…

---Original--- From: "Aarni ***@***.***> Date: Wed, Nov 4, 2026 21:54 PM To: ***@***.***>; Cc: ***@***.******@***.***>; Subject: Re: [python-babel/babel] Fix compact decimal plural selection after rounding (PR #1430) @akx requested changes on this pull request. In babel/numbers.py: > @@ -692,8 +692,10 @@ def _get_compact_format( if index > 0 and abs(rounded) * divisor >= magnitudes[index - 1]: bumped = decimal.Decimal(magnitudes[index - 1]).copy_sign(number) return _get_compact_format(bumped, compact_format, locale, fraction_digits) - # if the remaining number is singular, use the singular format - plural_form = locale.plural_form(abs(scaled)) + # Select the plural form from the displayed number. Optional trailing + # fractional zeros are not rendered by the compact pattern. + plural_number = abs(rounded).normalize() + plural_form = locale.plural_form(plural_number) if plural_form not in compact_format: plural_form = "other" if scaled == 1 and "1" in compact_format: Let's also use the rounded value here: ⬇️ Suggested change - if scaled == 1 and "1" in compact_format: + if rounded == 1 and "1" in compact_format: and then change the tests accordingly and add ('fr', 1234, 0, 'mille'), ('fr', -1234, 0, '-1 millier'), to the tests (this ought to match what Node ICU does). — Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today! You are receiving this because you authored the thread.Message ID: ***@***.***>

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

akx commented Nov 5, 2026

Copy link

Copy Markdown

Member

@0718lol Sorry, I can't read that (without Google Translate anyway). Are you able to enact the changes requested?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Use the rounded value for the compact "1" special-case selection

f6411c5

As requested in review: the special case should test the rounded display
value instead of the scaled input, so e.g. fr 1234 with fraction_digits=0
formats as 'mille' (matching Node ICU), while fr -1234 keeps '-1 millier'.

Adds the two French cases to test_compact_plural_uses_displayed_number and
updates the matching expectation in test_compact.

0718lol commented Nov 8, 2026

Copy link

Copy Markdown

Author

Done, pushed as f6411c5:

babel/numbers.py: the special case now tests the rounded display value (if rounded == 1 ...), exactly as suggested.
Added ('fr', 1234, 0, 'mille') and ('fr', -1234, 0, '-1 millier') to test_compact_plural_uses_displayed_number — both behave as you described.
Updated the pre-existing expectation in tests/test_numbers_format_decimal.py::test_compact (fr 1234 is now 'mille', matching Node ICU and the Italian case right above it).

Verification: the two new cases fail before the change and pass after. Full tests/ run: 6689 passed, 1180 skipped, 1 xfailed, and one failure in test_extract.py::test_input_paths_is_treated_as_list that I verified also fails on the unmodified branch HEAD locally (it is triggered by my checkout directory name containing --, not by this patch).

Sorry for the earlier reply in Chinese. This update was prepared with AI assistance under my direction, as disclosed in the PR description.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

akx requested review from akx and a balanced review from Copilot and removed request for akx

November 9, 2026 09:47

Copilot started reviewing on behalf of akx

November 9, 2026 09:47

View session

Copilot AI reviewed

Nov 9, 2026

View reviewed changes

Copilot AI left a comment

Copy link

Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The exact-1 pattern now applies to scaled values that round to 1, contradicting the description and requiring either a description update or restoration of the exact comparison.

1 open issue

Exact-1 pattern selection now includes scaled values that round to 1 · New

What changed in this PR

Updates Babel’s compact decimal formatting to select plural forms from the rounded displayed value, addressing #1429.

Changes:

Uses rounded values with optional trailing zeros removed for plural selection.
Extends literal exact-1 pattern selection to values that round to 1.
Adds 13 regression cases across five locales and updates Italian and French expectations.

File	Description
tests/test_numbers.py	Adds coverage for rounding, signs, retained fractions, and trimmed zeros.
tests/test_numbers_format_decimal.py	Updates Italian and French compact-format expectations.
babel/numbers.py	Uses normalized rounded values for plural rules and rounded values for exact-`1` matching.

_{Review effort: Balanced}

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

babel/numbers.py

		if plural_form not in compact_format:
		plural_form = "other"
		if scaled == 1 and "1" in compact_format:
		if rounded == 1 and "1" in compact_format:

manav4u mentioned this pull request

Nov 10, 2026

Use the plural pattern for exact millions in compact formats #1454

Open

This branch has not been deployed

No deployments

Reviewers

Copilot code review Copilot

Copilot review effort

Applies to this pull request for everyone.Learn more about Copilot code review.

Copilot left review comments

akx

akx requested changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

akx

Labels

AI Assisted area/numbers bug

Projects

None yet

Milestone

Babel 2.19

Development

Successfully merging this pull request may close these issues.

Compact decimal plural forms use the value before rounding

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.