GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix #269: add C99 flag for intel compilers by telamonian · Pull Request #271 · python-cmake-buildsystem/python-cmake-buildsystem

Conversation

@telamonian

@telamonian telamonian commented Sep 17, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Fixes #269

The intel C compiler defaults to -std=gnu98, which apparently causes problems with recent cpython source. Judging by the existing code in CMakeLists.txt and this issue on the core cpython repo, somewhere around cpy3.6 cpython moved on to C99.

This PR ensures that if intel compilers are being used on cpy>=3.6 source, the -std=C99 flag will be added

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@telamonian
Fix python-cmake-buildsystem#269: add C99 flag for intel compilers
b9354ae
The intel C compiler [defaults to `-std=gnu98`](https://software.intel.com/content/www/us/en/develop/documentation/cpp-compiler-developer-guide-and-reference/top/compiler-reference/compiler-options/compiler-option-details/language-options/std-qstd.html#std-qstd_GUID-338F4C2A-560C-4338-8ACF-C4B022A7C865), which apparently causes problems with recent cpython source. Judging by the existing code in `CMakeLists.txt` and [this issue on the core cpython repo](python/cpython#568), somewhere around cpy3.6 cpython moved on to C99.

This PR ensures that if intel compilers are being used on cpy>=3.6 source, the `-std=C99` flag will be added
@telamonian

telamonian commented Sep 17, 2020

Copy link
Copy Markdown
Author

@certik It's been a while since I've had personal access to the intel compiler suite, so I have no actual way of testing this PR out myself. However, I'm pretty sure it will solve your problem? Can you please try it out and let us know?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@telamonian telamonian mentioned this pull request Sep 17, 2020
Fails to compile with icc #269
Open
@certik

certik commented Sep 17, 2020

Copy link
Copy Markdown

Thanks, I'll give it a shot soon!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@concatime

concatime commented Nov 17, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Why not simply add set(CMAKE_C_STANDARD 99), independently of the compiler used ?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@concatime

concatime commented Nov 17, 2020

Copy link
Copy Markdown
Contributor

Or a simple patch:

diff --git a/Parser/grammar.c b/Parser/grammar.c
index 75fd5b9cde..1a4d585026 100644
--- a/Parser/grammar.c
+++ b/Parser/grammar.c
@@ -33,8 +33,9 @@ freegrammar(grammar *g)
 {
     int i;
     for (i = 0; i < g->g_ndfas; i++) {
+        int j;
         free(g->g_dfa[i].d_name);
-        for (int j = 0; j < g->g_dfa[i].d_nstates; j++)
+        for (j = 0; j < g->g_dfa[i].d_nstates; j++)
             PyObject_FREE(g->g_dfa[i].d_state[j].s_arc);
         PyObject_FREE(g->g_dfa[i].d_state);
     }
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fails to compile with icc

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@telamonian @certik @concatime
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.