GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Indicate pull request source in CDash Build Name. by thewtex · Pull Request #84 · python-cmake-buildsystem/python-cmake-buildsystem

Conversation

@thewtex

@thewtex thewtex commented Aug 24, 2015

Copy link
Copy Markdown
Contributor

The pull request number is added as documented for Travis at
http://docs.travis-ci.com/user/environment-variables/#Default-Environment-Variables

The pull request title and number is added as documented for Appveyor at
http://www.appveyor.com/docs/environment-variables

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@thewtex
Indicate pull request source in CDash Build Name.
a3261bf 
The pull request number is added as documented for Travis at
http://docs.travis-ci.com/user/environment-variables/#Default-Environment-Variables

The pull request title and number is added as documented for Appveyor at
http://www.appveyor.com/docs/environment-variables
jcfr
jcfr reviewed Aug 24, 2015
View reviewed changes
Comment thread appveyor_dashboard.cmake

@jcfr jcfr Aug 24, 2015

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo # -> $

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@thewtex thewtex Aug 24, 2015

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The # was intended to indicate the pull request number. I can remove it if preferred.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@jcfr jcfr Aug 24, 2015

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see ... should it be escaped ? I just want to make sure it is not considered as a CMake comment.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@thewtex thewtex Aug 24, 2015

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using cmake -P with this content:

set(var_with_hash "this_has_a_#")
message(${var_with_hash})

verifies it should be OK.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jcfr

jcfr commented Aug 24, 2015

Copy link
Copy Markdown
Contributor

I see looking at the travis error, it tried to build the dashboard branch .. and it failed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jcfr added a commit that referenced this pull request Aug 24, 2015
@jcfr
Merge pull request #84 from thewtex/pull-request-in-build-name
0641976 
Indicate pull request source in CDash Build Name.
@jcfr
jcfr merged commit 0641976 into python-cmake-buildsystem:dashboard Aug 24, 2015
@jcfr jcfr mentioned this pull request Aug 25, 2015
Include topic branch name in Travis-CI and AppVeyor-CI CTest Build Name #83
Closed
o01eg pushed a commit to o01eg/python-cmake-buildsystem that referenced this pull request May 24, 2026
@jcfr
Merge pull request python-cmake-buildsystem#84 from thewtex/pull-requ…
762a82e 
…est-in-build-name

Indicate pull request source in CDash Build Name.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@thewtex @jcfr
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.