Description

NikolaiVChr

opened on Jun 29, 2024

Issue body actions

When mouse clicking in root locus plot outside in the border region of the window I get this:

Traceback (most recent call last):
  File "C:\Users\me\PycharmProjects\f\venv\lib\site-packages\matplotlib\cbook.py", line 298, in process
    func(*args, **kwargs)
  File "C:\Users\me\PycharmProjects\f\venv\lib\site-packages\control\pzmap.py", line 470, in _click_dispatcher
    K, s = _find_root_locus_gain(event, sys, ax)
  File "C:\Users\me\PycharmProjects\f\venv\lib\site-packages\control\pzmap.py", line 531, in _find_root_locus_gain
    return None, s
UnboundLocalError: local variable 's' referenced before assignment

Activity

1. murrayrm commented on Jun 29, 2024

   

   murrayrm

   on Jun 29, 2024

   Member

   More actions

   This worked OK for me on the main branch with Python 3.12 and matplotlib 3.8.4 using iPython.

   Can you post the versions of Python, control and matplotlib that you are using, along with the execution environment (python, iPython, Jupyter) that you are using, so we can narrow things down?
2. NikolaiVChr commented on Jun 30, 2024

   

   NikolaiVChr

   on Jun 30, 2024

   Author

   More actions

   Control v0.10.0
   Numpy 1.26.4
   Scipy 1.14.0
   matplotlib 2.9.0
   PyCharm 2023.2.3
   Python 3.10

   Python env
3. murrayrm

   self-assigned this

   on Jun 30, 2024
4. murrayrm

   added

   bug

   on Jun 30, 2024
5. murrayrm

   added this to the 0.10.1 milestone on Jun 30, 2024
6. murrayrm

   added a commit that references this issue on Jun 30, 2024

   fix bug in root_locus_plot identified by @NikolaiVChr in issue python…

   aaa2aba
7. murrayrm

   linked a pull request that will close this issuefix bug in root_locus_plot identified by @NikolaiVChr in issue #1016 #1021on Jun 30, 2024
8. murrayrm

   closed this as completedin #1021on Jul 7, 2024
9. murrayrm

   added a commit that references this issue on Jul 7, 2024

   Merge pull request #1021 from murrayrm/rlocus_bug-30Jun2024

   f49dbcf

Issue actions