Description

forgi86

opened on Mar 25, 2021

Issue body actions

Among the frequency-domain analysis functions, a singular values plot is missing in the current version
of python-control. Is there any plan to include it? I think it is very common and useful for MIMO system analysis.

Activity

1. bnavigator

   added

   enhancement

   on Mar 25, 2021
2. bnavigator commented on Mar 25, 2021

   

   bnavigator

   on Mar 25, 2021

   Contributor

   More actions

   I think it depends on what exactly you want to see implemented.

   A simple wrapper of feeding MIMO transfer functions or FrequencyResponseData objects into numpy.linalg.svd and then calling a Matplotlib plot function does not really add any value over calling those functions directly, does it?
3. forgi86 commented on Mar 25, 2021

   

   forgi86

   on Mar 25, 2021

   ContributorAuthor

   More actions

   The matlab equivalent (function sigma) does this plot on an automatically adjusted logarithmic frequency scale, with singular values in dB, etc. Eventually it should look like a bode plot, but with singular values instead. Sure you can build this plot from scratch, but it takes some time boilerplate code. Today for instance I needed it while working in Python, but I was lazy so I switched to the commercial software :) So I think wrapping it up in a nice way would add some value!
4. bnavigator commented on Mar 26, 2021

   

   bnavigator

   on Mar 26, 2021

   Contributor

   More actions

   Sounds reasonable. You are always welcome to submit a PR.
5. forgi86 commented on Mar 26, 2021

   

   forgi86

   on Mar 26, 2021

   ContributorAuthor

   More actions

   OK maybe I'll try to do it when I have time!

   Reacted by Ben Greiner
6. sawyerbfuller

   linked a pull request that will close this issuea first implementation of the singular value plot as discussed in #592 #593on Apr 20, 2021
7. bnavigator

   closed this as completedin #593on Apr 29, 2021
8. bnavigator

   added a commit that references this issue on Apr 29, 2021

   Merge pull request #593 from forgi86/singular-values-plot

   db174b7

Issue actions