GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — CI: explicitly include defaults channel by slivingston · Pull Request #1129 · python-control/python-control

Conversation

@slivingston

@slivingston slivingston commented Feb 17, 2025

Copy link
Copy Markdown
Member

This change is motivated by that of commit 814f414 (from PR #1128)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
slivingston added a commit to slivingston/Slycot that referenced this pull request Feb 17, 2025
@slivingston
CI: explicitly include defaults channel
fd6be99 
Similar to changes from
python-control/python-control#1129
python-control/python-control#1128
@coveralls

coveralls commented Feb 17, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Coverage Status

coverage: 94.744%. remained the same
when pulling 6c628f0 on slivingston:ci-add-defaults-miniforge
into 061749d on python-control:main.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@slivingston
CI: explicitly include defaults channel
3079721 
This change is motivated by that of commit 814f414
@slivingston
slivingston force-pushed the ci-add-defaults-miniforge branch from 7499bd5 to 3079721 Compare February 17, 2025 00:38
slivingston added a commit to slivingston/Slycot that referenced this pull request Feb 17, 2025
@slivingston
CI: explicitly include defaults channel
03bff79 
Similar to changes from
python-control/python-control#1129
python-control/python-control#1128
@murrayrm

murrayrm commented Feb 17, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

@slivingston Despite the claim that all checks completed, in fact the conda-based tests did not complete. See OS/BLAS test matrix run. It looks like the conda test matrix gets created but does not run.

The error is

Error when evaluating 'strategy' for job 'test-conda'. 
.github/workflows/os-blas-test-matrix.yml (Line: 277, Col: 15): 
Error parsing fromJson,.github/workflows/os-blas-test-matrix.yml (Line: 277, Col: 15): 
Error reading JToken from JsonReader. Path '', line 0, position 0.,.github/workflows/os-blas-test-matrix.yml (Line: 277, Col: 15): 
Unexpected value ''

???
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@slivingston

slivingston commented Feb 17, 2025

Copy link
Copy Markdown
Member Author

@slivingston Despite the claim that all checks completed, in fact the conda-based tests did not complete. See OS/BLAS test matrix run. It looks like the conda test matrix gets created but does not run.

The error is

Error when evaluating 'strategy' for job 'test-conda'. 
.github/workflows/os-blas-test-matrix.yml (Line: 277, Col: 15): 
Error parsing fromJson,.github/workflows/os-blas-test-matrix.yml (Line: 277, Col: 15): 
Error reading JToken from JsonReader. Path '', line 0, position 0.,.github/workflows/os-blas-test-matrix.yml (Line: 277, Col: 15): 
Unexpected value ''

???

Good catch. Yes, I am investigating this and a similar change for Slycot on which I am working.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@slivingston
slivingston marked this pull request as draft February 17, 2025 04:26
@slivingston

slivingston commented Feb 17, 2025

Copy link
Copy Markdown
Member Author

It looks like the same hidden error happened 2 weeks ago in a different PR: https://github.com/python-control/python-control/actions/runs/13107250760
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@slivingston
CI: fix missing import
9b228b1
@slivingston
slivingston force-pushed the ci-add-defaults-miniforge branch from 8f33d82 to 9b228b1 Compare February 17, 2025 05:47
@slivingston
slivingston marked this pull request as ready for review February 17, 2025 07:46
@slivingston

slivingston commented Feb 17, 2025

Copy link
Copy Markdown
Member Author

Commit 1ceeeea deleted required imports in a test matrix generation script, resulting in an uncaught exception. The backtrace from Python would then be used as the saved output in a step of the workflow file. One of the next jobs tries to parse this output as JSON, hence the error from JsonReader. This is treated as a syntax error in the workflow file, thus an incomplete rather than a failed job.

I modified the workflow files so that errors from the test matrix generation scripts surface clearly as failed jobs.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@slivingston
slivingston force-pushed the ci-add-defaults-miniforge branch from 7d4a01f to baaae00 Compare February 17, 2025 08:03
@slivingston
slivingston marked this pull request as draft February 17, 2025 08:03
@slivingston

slivingston commented Feb 17, 2025

Copy link
Copy Markdown
Member Author

...actually, still debugging. I will finish it in the morning.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@slivingston
slivingston force-pushed the ci-add-defaults-miniforge branch from baaae00 to 04d729e Compare February 17, 2025 18:37
@slivingston
CI: detect errors from set-...-test-matrix scripts
6c628f0
@slivingston
slivingston force-pushed the ci-add-defaults-miniforge branch from 04d729e to 6c628f0 Compare February 17, 2025 19:03
@slivingston
slivingston marked this pull request as ready for review February 17, 2025 19:36
@slivingston

slivingston commented Feb 17, 2025

Copy link
Copy Markdown
Member Author

This is ready for review.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bnavigator

bnavigator commented Feb 17, 2025

Copy link
Copy Markdown
Contributor

Sorry for the extra delete in 1ceeeea
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bnavigator
bnavigator approved these changes Feb 17, 2025
View reviewed changes
@murrayrm
murrayrm merged commit d11f05d into python-control:main Feb 17, 2025
@slivingston slivingston mentioned this pull request Feb 17, 2025
CI: skip docstrings_test.py and add defaults channel python-control/Slycot#247
Merged
@slivingston

slivingston commented Feb 17, 2025

Copy link
Copy Markdown
Member Author

Sorry for the extra delete

@bnavigator No worries! I only intended to find the origin, not accuse anyone.
bnavigator reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@slivingston
slivingston deleted the ci-add-defaults-miniforge branch February 17, 2025 23:18
@murrayrm murrayrm added this to the 0.10.2 milestone Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnavigator bnavigator bnavigator approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.10.2

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@slivingston @coveralls @murrayrm @bnavigator
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.