GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — BugFix: `place_acker` output should be 2D array by guptavaibhav0 · Pull Request #1181 · python-control/python-control

Conversation

@guptavaibhav0

@guptavaibhav0 guptavaibhav0 commented Sep 9, 2025

Copy link
Copy Markdown
Contributor

place_acker function's output is a 1D array, while it should be a 2D array as described in its doc string.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@guptavaibhav0
BugFix: place_acker output should be 2D matrix
37ccb27
@coveralls

coveralls commented Sep 9, 2025

Copy link
Copy Markdown

Coverage Status

coverage: 94.734%. remained the same
when pulling 37ccb27 on guptavaibhav0:main
into abeb0e4 on python-control:main.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@murrayrm

murrayrm commented Nov 9, 2025

Copy link
Copy Markdown
Member

Good fix, @guptavaibhav0! Can you also update the unit test in statefbk_test.py so that it exhibits the error. On line 273, if you change

ss(sys.A - sys.B * K, sys.B, sys.C, sys.D)

to read

ss(sys.A - sys.B @ K, sys.B, sys.C, sys.D)

then the previous code will generate an error.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@murrayrm

murrayrm commented Jan 19, 2026

Copy link
Copy Markdown
Member

Alternative fix in #1195 with unit tests to catch the bug.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@murrayrm murrayrm closed this Jan 19, 2026
@murrayrm murrayrm mentioned this pull request Jan 19, 2026
fix return shape for place_acker (#1190) #1195
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@guptavaibhav0 @coveralls @murrayrm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.