GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix return shape for place_acker (#1190) by murrayrm · Pull Request #1195 · python-control/python-control

Conversation

@murrayrm

@murrayrm murrayrm commented Jan 19, 2026

Copy link
Copy Markdown
Member

Add unit tests to catch the bug in #1190 and fix it. Thanks to @miroslavfikar for pointing out the error.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@murrayrm
fix return shape for place_acker (python-control#1190)
3215681
@murrayrm murrayrm linked an issue Jan 19, 2026 that may be closed by this pull request
bug in place_acker #1190
Closed
This was referenced Jan 19, 2026
bug in place_acker #1190
Closed
BugFix: place_acker output should be 2D array #1181
Closed
@murrayrm

murrayrm commented Jan 19, 2026

Copy link
Copy Markdown
Member Author

Also, this bug was pointed out by @guptavaibhav0 in #1181.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@murrayrm
add mark for slycot in unit test
8c71d6e
@coveralls

coveralls commented Jan 19, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Coverage Status

coverage: 94.734%. remained the same
when pulling cde5cbf on murrayrm:fix_place_acker-19Jan2026
into 4242976 on python-control:main.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@murrayrm
fix deprecated NumPy issues that were causing CI errors
cde5cbf
bnavigator
bnavigator approved these changes Feb 15, 2026
View reviewed changes
@bnavigator
bnavigator merged commit 854f5f7 into python-control:main Feb 15, 2026
24 checks passed

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnavigator bnavigator bnavigator approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug in place_acker

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@murrayrm @coveralls @bnavigator
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.